All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property
@ 2023-05-10  6:56 Alexander Stein
  2023-05-10  6:56 ` [PATCH 2/4] arm64: dts: imx8mp: Add CCM interrupts Alexander Stein
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Alexander Stein @ 2023-05-10  6:56 UTC (permalink / raw
  To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
	linux-clk, devicetree, linux-arm-kernel

All i.MX8M SoC have 2 CCM interrupts, called:
* Interrupt Request 1
* Interrupt Request 2

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Admittedly despite listing them in the interrupt list, there is no
further description.
If it is deemed these IRQs are useless, the corresponding property in
imx8mq.dtsi should be removed instead.

 Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
index 0dbc1433fede..80539f88bc27 100644
--- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
@@ -24,6 +24,9 @@ properties:
   reg:
     maxItems: 1
 
+  interrupts:
+    maxItems: 2
+
   clocks:
     minItems: 6
     maxItems: 7
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/4] arm64: dts: imx8mp: Add CCM interrupts
  2023-05-10  6:56 [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Alexander Stein
@ 2023-05-10  6:56 ` Alexander Stein
  2023-05-10  6:56 ` [PATCH 3/4] arm64: dts: imx8mn: " Alexander Stein
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Alexander Stein @ 2023-05-10  6:56 UTC (permalink / raw
  To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
	linux-clk, devicetree, linux-arm-kernel

Add both CCM interrupts as mentioned in RM.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index b94942305b4c..7a3243bad41f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -528,6 +528,8 @@ snvs_lpgpr: snvs-lpgpr {
 			clk: clock-controller@30380000 {
 				compatible = "fsl,imx8mp-ccm";
 				reg = <0x30380000 0x10000>;
+				interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
 				#clock-cells = <1>;
 				clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>,
 					 <&clk_ext3>, <&clk_ext4>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/4] arm64: dts: imx8mn: Add CCM interrupts
  2023-05-10  6:56 [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Alexander Stein
  2023-05-10  6:56 ` [PATCH 2/4] arm64: dts: imx8mp: Add CCM interrupts Alexander Stein
@ 2023-05-10  6:56 ` Alexander Stein
  2023-05-10  6:56 ` [PATCH 4/4] arm64: dts: imx8mm: " Alexander Stein
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Alexander Stein @ 2023-05-10  6:56 UTC (permalink / raw
  To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
	linux-clk, devicetree, linux-arm-kernel

Add both CCM interrupts as mentioned in RM.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 8be8f090e8b8..964c29701f1c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -636,6 +636,8 @@ snvs_pwrkey: snvs-powerkey {
 			clk: clock-controller@30380000 {
 				compatible = "fsl,imx8mn-ccm";
 				reg = <0x30380000 0x10000>;
+				interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
 				#clock-cells = <1>;
 				clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>,
 					 <&clk_ext3>, <&clk_ext4>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 4/4] arm64: dts: imx8mm: Add CCM interrupts
  2023-05-10  6:56 [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Alexander Stein
  2023-05-10  6:56 ` [PATCH 2/4] arm64: dts: imx8mp: Add CCM interrupts Alexander Stein
  2023-05-10  6:56 ` [PATCH 3/4] arm64: dts: imx8mn: " Alexander Stein
@ 2023-05-10  6:56 ` Alexander Stein
  2023-05-10  8:25 ` [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Alexander Stein @ 2023-05-10  6:56 UTC (permalink / raw
  To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
	linux-clk, devicetree, linux-arm-kernel

Add both CCM interrupts as mentioned in RM.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index d6b36f04f3dc..f56baa52bd10 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -635,6 +635,8 @@ snvs_lpgpr: snvs-lpgpr {
 			clk: clock-controller@30380000 {
 				compatible = "fsl,imx8mm-ccm";
 				reg = <0x30380000 0x10000>;
+				interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
+					     <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
 				#clock-cells = <1>;
 				clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>, <&clk_ext2>,
 					 <&clk_ext3>, <&clk_ext4>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property
  2023-05-10  6:56 [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Alexander Stein
                   ` (2 preceding siblings ...)
  2023-05-10  6:56 ` [PATCH 4/4] arm64: dts: imx8mm: " Alexander Stein
@ 2023-05-10  8:25 ` Krzysztof Kozlowski
  2023-06-12  9:06 ` Abel Vesa
  2023-06-12  9:32 ` Abel Vesa
  5 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-10  8:25 UTC (permalink / raw
  To: Alexander Stein, Abel Vesa, Peng Fan, Michael Turquette,
	Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Shawn Guo, Sascha Hauer, Fabio Estevam
  Cc: Pengutronix Kernel Team, NXP Linux Team, linux-clk, devicetree,
	linux-arm-kernel

On 10/05/2023 08:56, Alexander Stein wrote:
> All i.MX8M SoC have 2 CCM interrupts, called:
> * Interrupt Request 1
> * Interrupt Request 2
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Admittedly despite listing them in the interrupt list, there is no
> further description.
> If it is deemed these IRQs are useless, the corresponding property in
> imx8mq.dtsi should be removed instead.
> 
>  Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 3 +++
>  1 file changed, 3 insertions(+)


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property
  2023-05-10  6:56 [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Alexander Stein
                   ` (3 preceding siblings ...)
  2023-05-10  8:25 ` [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Krzysztof Kozlowski
@ 2023-06-12  9:06 ` Abel Vesa
  2023-06-12  9:32 ` Abel Vesa
  5 siblings, 0 replies; 7+ messages in thread
From: Abel Vesa @ 2023-06-12  9:06 UTC (permalink / raw
  To: Alexander Stein
  Cc: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Fabio Estevam, Pengutronix Kernel Team, NXP Linux Team, linux-clk,
	devicetree, linux-arm-kernel

On 23-05-10 08:56:41, Alexander Stein wrote:
> All i.MX8M SoC have 2 CCM interrupts, called:
> * Interrupt Request 1
> * Interrupt Request 2
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

> ---
> Admittedly despite listing them in the interrupt list, there is no
> further description.
> If it is deemed these IRQs are useless, the corresponding property in
> imx8mq.dtsi should be removed instead.
> 
>  Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> index 0dbc1433fede..80539f88bc27 100644
> --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> @@ -24,6 +24,9 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 2
> +
>    clocks:
>      minItems: 6
>      maxItems: 7
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property
  2023-05-10  6:56 [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Alexander Stein
                   ` (4 preceding siblings ...)
  2023-06-12  9:06 ` Abel Vesa
@ 2023-06-12  9:32 ` Abel Vesa
  5 siblings, 0 replies; 7+ messages in thread
From: Abel Vesa @ 2023-06-12  9:32 UTC (permalink / raw
  To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Fabio Estevam, Alexander Stein
  Cc: Pengutronix Kernel Team, NXP Linux Team, linux-clk, devicetree,
	linux-arm-kernel


On Wed, 10 May 2023 08:56:41 +0200, Alexander Stein wrote:
> All i.MX8M SoC have 2 CCM interrupts, called:
> * Interrupt Request 1
> * Interrupt Request 2
> 
> 

Applied, thanks!

[1/4] dt-bindings: clock: imx8m: Add missing interrupt property
      commit: 6e6bb1639136f36c82efda147b63e2a2197fa3f8

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-06-12  9:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-10  6:56 [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Alexander Stein
2023-05-10  6:56 ` [PATCH 2/4] arm64: dts: imx8mp: Add CCM interrupts Alexander Stein
2023-05-10  6:56 ` [PATCH 3/4] arm64: dts: imx8mn: " Alexander Stein
2023-05-10  6:56 ` [PATCH 4/4] arm64: dts: imx8mm: " Alexander Stein
2023-05-10  8:25 ` [PATCH 1/4] dt-bindings: clock: imx8m: Add missing interrupt property Krzysztof Kozlowski
2023-06-12  9:06 ` Abel Vesa
2023-06-12  9:32 ` Abel Vesa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.