* [PATCH 1/2] maple_tree: Drop the test code for mtree_alloc_{range,rrange}()
@ 2023-05-10 6:10 Peng Zhang
2023-05-10 6:10 ` [PATCH 2/2] maple_tree: Drop mtree_alloc_{range,rrange}() and related functions Peng Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Peng Zhang @ 2023-05-10 6:10 UTC (permalink / raw
To: Liam.Howlett; +Cc: akpm, linux-mm, linux-kernel, maple-tree, Peng Zhang
Drop the test code for mtree_alloc_{range,rrange}() because we are going
to drop them.
Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
---
lib/test_maple_tree.c | 389 ------------------------------------------
1 file changed, 389 deletions(-)
diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
index 9939be34e516e..86d7f742d243e 100644
--- a/lib/test_maple_tree.c
+++ b/lib/test_maple_tree.c
@@ -97,42 +97,6 @@ static void __init *mtree_test_erase(struct maple_tree *mt, unsigned long index)
return mtree_erase(mt, index);
}
-#if defined(CONFIG_64BIT)
-static noinline void __init check_mtree_alloc_range(struct maple_tree *mt,
- unsigned long start, unsigned long end, unsigned long size,
- unsigned long expected, int eret, void *ptr)
-{
-
- unsigned long result = expected + 1;
- int ret;
-
- ret = mtree_alloc_range(mt, &result, ptr, size, start, end,
- GFP_KERNEL);
- MT_BUG_ON(mt, ret != eret);
- if (ret)
- return;
-
- MT_BUG_ON(mt, result != expected);
-}
-
-static noinline void __init check_mtree_alloc_rrange(struct maple_tree *mt,
- unsigned long start, unsigned long end, unsigned long size,
- unsigned long expected, int eret, void *ptr)
-{
-
- unsigned long result = expected + 1;
- int ret;
-
- ret = mtree_alloc_rrange(mt, &result, ptr, size, start, end,
- GFP_KERNEL);
- MT_BUG_ON(mt, ret != eret);
- if (ret)
- return;
-
- MT_BUG_ON(mt, result != expected);
-}
-#endif
-
static noinline void __init check_load(struct maple_tree *mt,
unsigned long index, void *ptr)
{
@@ -635,348 +599,6 @@ static noinline void __init check_find_2(struct maple_tree *mt)
/*MT_BUG_ON(mt, !mtree_empty(mt)); */
}
-
-#if defined(CONFIG_64BIT)
-static noinline void __init check_alloc_rev_range(struct maple_tree *mt)
-{
- /*
- * Generated by:
- * cat /proc/self/maps | awk '{print $1}'|
- * awk -F "-" '{printf "0x%s, 0x%s, ", $1, $2}'
- */
-
- static const unsigned long range[] = {
- /* Inclusive , Exclusive. */
- 0x565234af2000, 0x565234af4000,
- 0x565234af4000, 0x565234af9000,
- 0x565234af9000, 0x565234afb000,
- 0x565234afc000, 0x565234afd000,
- 0x565234afd000, 0x565234afe000,
- 0x565235def000, 0x565235e10000,
- 0x7f36d4bfd000, 0x7f36d4ee2000,
- 0x7f36d4ee2000, 0x7f36d4f04000,
- 0x7f36d4f04000, 0x7f36d504c000,
- 0x7f36d504c000, 0x7f36d5098000,
- 0x7f36d5098000, 0x7f36d5099000,
- 0x7f36d5099000, 0x7f36d509d000,
- 0x7f36d509d000, 0x7f36d509f000,
- 0x7f36d509f000, 0x7f36d50a5000,
- 0x7f36d50b9000, 0x7f36d50db000,
- 0x7f36d50db000, 0x7f36d50dc000,
- 0x7f36d50dc000, 0x7f36d50fa000,
- 0x7f36d50fa000, 0x7f36d5102000,
- 0x7f36d5102000, 0x7f36d5103000,
- 0x7f36d5103000, 0x7f36d5104000,
- 0x7f36d5104000, 0x7f36d5105000,
- 0x7fff5876b000, 0x7fff5878d000,
- 0x7fff5878e000, 0x7fff58791000,
- 0x7fff58791000, 0x7fff58793000,
- };
-
- static const unsigned long holes[] = {
- /*
- * Note: start of hole is INCLUSIVE
- * end of hole is EXCLUSIVE
- * (opposite of the above table.)
- * Start of hole, end of hole, size of hole (+1)
- */
- 0x565234afb000, 0x565234afc000, 0x1000,
- 0x565234afe000, 0x565235def000, 0x12F1000,
- 0x565235e10000, 0x7f36d4bfd000, 0x28E49EDED000,
- };
-
- /*
- * req_range consists of 4 values.
- * 1. min index
- * 2. max index
- * 3. size
- * 4. number that should be returned.
- * 5. return value
- */
- static const unsigned long req_range[] = {
- 0x565234af9000, /* Min */
- 0x7fff58791000, /* Max */
- 0x1000, /* Size */
- 0x7fff5878d << 12, /* First rev hole of size 0x1000 */
- 0, /* Return value success. */
-
- 0x0, /* Min */
- 0x565234AF0 << 12, /* Max */
- 0x3000, /* Size */
- 0x565234AEE << 12, /* max - 3. */
- 0, /* Return value success. */
-
- 0x0, /* Min */
- -1, /* Max */
- 0x1000, /* Size */
- 562949953421311 << 12,/* First rev hole of size 0x1000 */
- 0, /* Return value success. */
-
- 0x0, /* Min */
- 0x7F36D5109 << 12, /* Max */
- 0x4000, /* Size */
- 0x7F36D5106 << 12, /* First rev hole of size 0x4000 */
- 0, /* Return value success. */
-
- /* Ascend test. */
- 0x0,
- 34148798628 << 12,
- 19 << 12,
- 34148797418 << 12,
- 0x0,
-
- /* Too big test. */
- 0x0,
- 18446744073709551615UL,
- 562915594369134UL << 12,
- 0x0,
- -EBUSY,
-
- /* Single space test. */
- 34148798725 << 12,
- 34148798725 << 12,
- 1 << 12,
- 34148798725 << 12,
- 0,
- };
-
- int i, range_count = ARRAY_SIZE(range);
- int req_range_count = ARRAY_SIZE(req_range);
- unsigned long min = 0;
-
- MA_STATE(mas, mt, 0, 0);
-
- mtree_store_range(mt, MTREE_ALLOC_MAX, ULONG_MAX, XA_ZERO_ENTRY,
- GFP_KERNEL);
-#define DEBUG_REV_RANGE 0
- for (i = 0; i < range_count; i += 2) {
- /* Inclusive, Inclusive (with the -1) */
-
-#if DEBUG_REV_RANGE
- pr_debug("\t%s: Insert %lu-%lu\n", __func__, range[i] >> 12,
- (range[i + 1] >> 12) - 1);
-#endif
- check_insert_range(mt, range[i] >> 12, (range[i + 1] >> 12) - 1,
- xa_mk_value(range[i] >> 12), 0);
- mt_validate(mt);
- }
-
-
- mas_lock(&mas);
- for (i = 0; i < ARRAY_SIZE(holes); i += 3) {
-#if DEBUG_REV_RANGE
- pr_debug("Search from %lu-%lu for gap %lu should be at %lu\n",
- min, holes[i+1]>>12, holes[i+2]>>12,
- holes[i] >> 12);
-#endif
- MT_BUG_ON(mt, mas_empty_area_rev(&mas, min,
- holes[i+1] >> 12,
- holes[i+2] >> 12));
-#if DEBUG_REV_RANGE
- pr_debug("Found %lu %lu\n", mas.index, mas.last);
- pr_debug("gap %lu %lu\n", (holes[i] >> 12),
- (holes[i+1] >> 12));
-#endif
- MT_BUG_ON(mt, mas.last + 1 != (holes[i+1] >> 12));
- MT_BUG_ON(mt, mas.index != (holes[i+1] >> 12) - (holes[i+2] >> 12));
- min = holes[i+1] >> 12;
- mas_reset(&mas);
- }
-
- mas_unlock(&mas);
- for (i = 0; i < req_range_count; i += 5) {
-#if DEBUG_REV_RANGE
- pr_debug("\tReverse request %d between %lu-%lu size %lu, should get %lu\n",
- i, req_range[i] >> 12,
- (req_range[i + 1] >> 12),
- req_range[i+2] >> 12,
- req_range[i+3] >> 12);
-#endif
- check_mtree_alloc_rrange(mt,
- req_range[i] >> 12, /* start */
- req_range[i+1] >> 12, /* end */
- req_range[i+2] >> 12, /* size */
- req_range[i+3] >> 12, /* expected address */
- req_range[i+4], /* expected return */
- xa_mk_value(req_range[i] >> 12)); /* pointer */
- mt_validate(mt);
- }
-
- mt_set_non_kernel(1);
- mtree_erase(mt, 34148798727); /* create a deleted range. */
- mtree_erase(mt, 34148798725);
- check_mtree_alloc_rrange(mt, 0, 34359052173, 210253414,
- 34148798725, 0, mt);
-
- mtree_destroy(mt);
-}
-
-static noinline void __init check_alloc_range(struct maple_tree *mt)
-{
- /*
- * Generated by:
- * cat /proc/self/maps|awk '{print $1}'|
- * awk -F "-" '{printf "0x%s, 0x%s, ", $1, $2}'
- */
-
- static const unsigned long range[] = {
- /* Inclusive , Exclusive. */
- 0x565234af2000, 0x565234af4000,
- 0x565234af4000, 0x565234af9000,
- 0x565234af9000, 0x565234afb000,
- 0x565234afc000, 0x565234afd000,
- 0x565234afd000, 0x565234afe000,
- 0x565235def000, 0x565235e10000,
- 0x7f36d4bfd000, 0x7f36d4ee2000,
- 0x7f36d4ee2000, 0x7f36d4f04000,
- 0x7f36d4f04000, 0x7f36d504c000,
- 0x7f36d504c000, 0x7f36d5098000,
- 0x7f36d5098000, 0x7f36d5099000,
- 0x7f36d5099000, 0x7f36d509d000,
- 0x7f36d509d000, 0x7f36d509f000,
- 0x7f36d509f000, 0x7f36d50a5000,
- 0x7f36d50b9000, 0x7f36d50db000,
- 0x7f36d50db000, 0x7f36d50dc000,
- 0x7f36d50dc000, 0x7f36d50fa000,
- 0x7f36d50fa000, 0x7f36d5102000,
- 0x7f36d5102000, 0x7f36d5103000,
- 0x7f36d5103000, 0x7f36d5104000,
- 0x7f36d5104000, 0x7f36d5105000,
- 0x7fff5876b000, 0x7fff5878d000,
- 0x7fff5878e000, 0x7fff58791000,
- 0x7fff58791000, 0x7fff58793000,
- };
- static const unsigned long holes[] = {
- /* Start of hole, end of hole, size of hole (+1) */
- 0x565234afb000, 0x565234afc000, 0x1000,
- 0x565234afe000, 0x565235def000, 0x12F1000,
- 0x565235e10000, 0x7f36d4bfd000, 0x28E49EDED000,
- };
-
- /*
- * req_range consists of 4 values.
- * 1. min index
- * 2. max index
- * 3. size
- * 4. number that should be returned.
- * 5. return value
- */
- static const unsigned long req_range[] = {
- 0x565234af9000, /* Min */
- 0x7fff58791000, /* Max */
- 0x1000, /* Size */
- 0x565234afb000, /* First hole in our data of size 1000. */
- 0, /* Return value success. */
-
- 0x0, /* Min */
- 0x7fff58791000, /* Max */
- 0x1F00, /* Size */
- 0x0, /* First hole in our data of size 2000. */
- 0, /* Return value success. */
-
- /* Test ascend. */
- 34148797436 << 12, /* Min */
- 0x7fff587AF000, /* Max */
- 0x3000, /* Size */
- 34148798629 << 12, /* Expected location */
- 0, /* Return value success. */
-
- /* Test failing. */
- 34148798623 << 12, /* Min */
- 34148798683 << 12, /* Max */
- 0x15000, /* Size */
- 0, /* Expected location */
- -EBUSY, /* Return value failed. */
-
- /* Test filling entire gap. */
- 34148798623 << 12, /* Min */
- 0x7fff587AF000, /* Max */
- 0x10000, /* Size */
- 34148798632 << 12, /* Expected location */
- 0, /* Return value success. */
-
- /* Test walking off the end of root. */
- 0, /* Min */
- -1, /* Max */
- -1, /* Size */
- 0, /* Expected location */
- -EBUSY, /* Return value failure. */
-
- /* Test looking for too large a hole across entire range. */
- 0, /* Min */
- -1, /* Max */
- 4503599618982063UL << 12, /* Size */
- 34359052178 << 12, /* Expected location */
- -EBUSY, /* Return failure. */
-
- /* Test a single entry */
- 34148798648 << 12, /* Min */
- 34148798648 << 12, /* Max */
- 4096, /* Size of 1 */
- 34148798648 << 12, /* Location is the same as min/max */
- 0, /* Success */
- };
- int i, range_count = ARRAY_SIZE(range);
- int req_range_count = ARRAY_SIZE(req_range);
- unsigned long min = 0x565234af2000;
- MA_STATE(mas, mt, 0, 0);
-
- mtree_store_range(mt, MTREE_ALLOC_MAX, ULONG_MAX, XA_ZERO_ENTRY,
- GFP_KERNEL);
- for (i = 0; i < range_count; i += 2) {
-#define DEBUG_ALLOC_RANGE 0
-#if DEBUG_ALLOC_RANGE
- pr_debug("\tInsert %lu-%lu\n", range[i] >> 12,
- (range[i + 1] >> 12) - 1);
- mt_dump(mt, mt_dump_hex);
-#endif
- check_insert_range(mt, range[i] >> 12, (range[i + 1] >> 12) - 1,
- xa_mk_value(range[i] >> 12), 0);
- mt_validate(mt);
- }
-
-
-
- mas_lock(&mas);
- for (i = 0; i < ARRAY_SIZE(holes); i += 3) {
-
-#if DEBUG_ALLOC_RANGE
- pr_debug("\tGet empty %lu-%lu size %lu (%lx-%lx)\n", min >> 12,
- holes[i+1] >> 12, holes[i+2] >> 12,
- min, holes[i+1]);
-#endif
- MT_BUG_ON(mt, mas_empty_area(&mas, min >> 12,
- holes[i+1] >> 12,
- holes[i+2] >> 12));
- MT_BUG_ON(mt, mas.index != holes[i] >> 12);
- min = holes[i+1];
- mas_reset(&mas);
- }
- mas_unlock(&mas);
- for (i = 0; i < req_range_count; i += 5) {
-#if DEBUG_ALLOC_RANGE
- pr_debug("\tTest %d: %lu-%lu size %lu expected %lu (%lu-%lu)\n",
- i/5, req_range[i] >> 12, req_range[i + 1] >> 12,
- req_range[i + 2] >> 12, req_range[i + 3] >> 12,
- req_range[i], req_range[i+1]);
-#endif
- check_mtree_alloc_range(mt,
- req_range[i] >> 12, /* start */
- req_range[i+1] >> 12, /* end */
- req_range[i+2] >> 12, /* size */
- req_range[i+3] >> 12, /* expected address */
- req_range[i+4], /* expected return */
- xa_mk_value(req_range[i] >> 12)); /* pointer */
- mt_validate(mt);
-#if DEBUG_ALLOC_RANGE
- mt_dump(mt, mt_dump_hex);
-#endif
- }
-
- mtree_destroy(mt);
-}
-#endif
-
static noinline void __init check_ranges(struct maple_tree *mt)
{
int i, val, val2;
@@ -3448,17 +3070,6 @@ static int __init maple_tree_seed(void)
check_ranges(&tree);
mtree_destroy(&tree);
-#if defined(CONFIG_64BIT)
- /* These tests have ranges outside of 4GB */
- mt_init_flags(&tree, MT_FLAGS_ALLOC_RANGE);
- check_alloc_range(&tree);
- mtree_destroy(&tree);
-
- mt_init_flags(&tree, MT_FLAGS_ALLOC_RANGE);
- check_alloc_rev_range(&tree);
- mtree_destroy(&tree);
-#endif
-
mt_init_flags(&tree, 0);
check_load(&tree, set[0], NULL); /* See if 5015 -> NULL */
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] maple_tree: Drop mtree_alloc_{range,rrange}() and related functions.
2023-05-10 6:10 [PATCH 1/2] maple_tree: Drop the test code for mtree_alloc_{range,rrange}() Peng Zhang
@ 2023-05-10 6:10 ` Peng Zhang
2023-05-10 6:50 ` Peng Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Peng Zhang @ 2023-05-10 6:10 UTC (permalink / raw
To: Liam.Howlett; +Cc: akpm, linux-mm, linux-kernel, maple-tree, Peng Zhang
Drop mtree_alloc_{range,rrange}(), mas_alloc() and mas_fill_gap().
mtree_alloc_{range,rrange}() currently have no users and can be easily
implemented with mas_empty_area{_rev}(). mas_alloc() and mas_fill_gap()
are just their internal functions, drop them together.
Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
---
include/linux/maple_tree.h | 7 --
lib/maple_tree.c | 177 -------------------------------------
2 files changed, 184 deletions(-)
diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
index 542b09118a09f..3dd6edccf83af 100644
--- a/include/linux/maple_tree.h
+++ b/include/linux/maple_tree.h
@@ -306,13 +306,6 @@ int mtree_insert(struct maple_tree *mt, unsigned long index,
void *entry, gfp_t gfp);
int mtree_insert_range(struct maple_tree *mt, unsigned long first,
unsigned long last, void *entry, gfp_t gfp);
-int mtree_alloc_range(struct maple_tree *mt, unsigned long *startp,
- void *entry, unsigned long size, unsigned long min,
- unsigned long max, gfp_t gfp);
-int mtree_alloc_rrange(struct maple_tree *mt, unsigned long *startp,
- void *entry, unsigned long size, unsigned long min,
- unsigned long max, gfp_t gfp);
-
int mtree_store_range(struct maple_tree *mt, unsigned long first,
unsigned long last, void *entry, gfp_t gfp);
int mtree_store(struct maple_tree *mt, unsigned long index,
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index b37065a6f570d..49dfe81dfa1b6 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5120,46 +5120,6 @@ static inline void mas_awalk(struct ma_state *mas, unsigned long size)
}
}
-/*
- * mas_fill_gap() - Fill a located gap with @entry.
- * @mas: The maple state
- * @entry: The value to store
- * @slot: The offset into the node to store the @entry
- * @size: The size of the entry
- * @index: The start location
- */
-static inline void mas_fill_gap(struct ma_state *mas, void *entry,
- unsigned char slot, unsigned long size, unsigned long *index)
-{
- MA_WR_STATE(wr_mas, mas, entry);
- unsigned char pslot = mte_parent_slot(mas->node);
- struct maple_enode *mn = mas->node;
- unsigned long *pivots;
- enum maple_type ptype;
- /*
- * mas->index is the start address for the search
- * which may no longer be needed.
- * mas->last is the end address for the search
- */
-
- *index = mas->index;
- mas->last = mas->index + size - 1;
-
- /*
- * It is possible that using mas->max and mas->min to correctly
- * calculate the index and last will cause an issue in the gap
- * calculation, so fix the ma_state here
- */
- mas_ascend(mas);
- ptype = mte_node_type(mas->node);
- pivots = ma_pivots(mas_mn(mas), ptype);
- mas->max = mas_safe_pivot(mas, pivots, pslot, ptype);
- mas->min = mas_safe_min(mas, pivots, pslot);
- mas->node = mn;
- mas->offset = slot;
- mas_wr_store_entry(&wr_mas);
-}
-
/*
* mas_sparse_area() - Internal function. Return upper or lower limit when
* searching for a gap in an empty tree.
@@ -5307,74 +5267,6 @@ int mas_empty_area_rev(struct ma_state *mas, unsigned long min,
}
EXPORT_SYMBOL_GPL(mas_empty_area_rev);
-static inline int mas_alloc(struct ma_state *mas, void *entry,
- unsigned long size, unsigned long *index)
-{
- unsigned long min;
-
- mas_start(mas);
- if (mas_is_none(mas) || mas_is_ptr(mas)) {
- mas_root_expand(mas, entry);
- if (mas_is_err(mas))
- return xa_err(mas->node);
-
- if (!mas->index)
- return mas_pivot(mas, 0);
- return mas_pivot(mas, 1);
- }
-
- /* Must be walking a tree. */
- mas_awalk(mas, size);
- if (mas_is_err(mas))
- return xa_err(mas->node);
-
- if (mas->offset == MAPLE_NODE_SLOTS)
- goto no_gap;
-
- /*
- * At this point, mas->node points to the right node and we have an
- * offset that has a sufficient gap.
- */
- min = mas->min;
- if (mas->offset)
- min = mas_pivot(mas, mas->offset - 1) + 1;
-
- if (mas_is_err(mas))
- return xa_err(mas->node);
-
- if (mas->index < min)
- mas->index = min;
-
- mas_fill_gap(mas, entry, mas->offset, size, index);
- return 0;
-
-no_gap:
- return -EBUSY;
-}
-
-static inline int mas_rev_alloc(struct ma_state *mas, unsigned long min,
- unsigned long max, void *entry,
- unsigned long size, unsigned long *index)
-{
- int ret = 0;
-
- ret = mas_empty_area_rev(mas, min, max, size);
- if (ret)
- return ret;
-
- if (mas_is_err(mas))
- return xa_err(mas->node);
-
- if (mas->offset == MAPLE_NODE_SLOTS)
- goto no_gap;
-
- mas_fill_gap(mas, entry, mas->offset, size, index);
- return 0;
-
-no_gap:
- return -EBUSY;
-}
-
/*
* mte_dead_leaves() - Mark all leaves of a node as dead.
* @mas: The maple state
@@ -6481,75 +6373,6 @@ int mtree_insert(struct maple_tree *mt, unsigned long index, void *entry,
}
EXPORT_SYMBOL(mtree_insert);
-int mtree_alloc_range(struct maple_tree *mt, unsigned long *startp,
- void *entry, unsigned long size, unsigned long min,
- unsigned long max, gfp_t gfp)
-{
- int ret = 0;
-
- MA_STATE(mas, mt, min, min);
- if (!mt_is_alloc(mt))
- return -EINVAL;
-
- if (WARN_ON_ONCE(mt_is_reserved(entry)))
- return -EINVAL;
-
- if (min > max)
- return -EINVAL;
-
- if (max < size)
- return -EINVAL;
-
- if (!size)
- return -EINVAL;
-
- mtree_lock(mt);
-retry:
- mas.offset = 0;
- mas.index = min;
- mas.last = max - size + 1;
- ret = mas_alloc(&mas, entry, size, startp);
- if (mas_nomem(&mas, gfp))
- goto retry;
-
- mtree_unlock(mt);
- return ret;
-}
-EXPORT_SYMBOL(mtree_alloc_range);
-
-int mtree_alloc_rrange(struct maple_tree *mt, unsigned long *startp,
- void *entry, unsigned long size, unsigned long min,
- unsigned long max, gfp_t gfp)
-{
- int ret = 0;
-
- MA_STATE(mas, mt, min, max - size + 1);
- if (!mt_is_alloc(mt))
- return -EINVAL;
-
- if (WARN_ON_ONCE(mt_is_reserved(entry)))
- return -EINVAL;
-
- if (min > max)
- return -EINVAL;
-
- if (max < size - 1)
- return -EINVAL;
-
- if (!size)
- return -EINVAL;
-
- mtree_lock(mt);
-retry:
- ret = mas_rev_alloc(&mas, min, max, entry, size, startp);
- if (mas_nomem(&mas, gfp))
- goto retry;
-
- mtree_unlock(mt);
- return ret;
-}
-EXPORT_SYMBOL(mtree_alloc_rrange);
-
/**
* mtree_erase() - Find an index and erase the entire range.
* @mt: The maple tree
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] maple_tree: Drop mtree_alloc_{range,rrange}() and related functions.
2023-05-10 6:10 ` [PATCH 2/2] maple_tree: Drop mtree_alloc_{range,rrange}() and related functions Peng Zhang
@ 2023-05-10 6:50 ` Peng Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Peng Zhang @ 2023-05-10 6:50 UTC (permalink / raw
To: Liam.Howlett; +Cc: akpm, linux-mm, linux-kernel, maple-tree, Peng Zhang
在 2023/5/10 14:10, Peng Zhang 写道:
> Drop mtree_alloc_{range,rrange}(), mas_alloc() and mas_fill_gap().
> mtree_alloc_{range,rrange}() currently have no users and can be easily
> implemented with mas_empty_area{_rev}(). mas_alloc() and mas_fill_gap()
> are just their internal functions, drop them together.
>
> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
Sorry for missing mas_rev_alloc(), change the commit message to the
following:
Drop mtree_alloc_{range,rrange}(), mas_{rev_}alloc() and mas_fill_gap().
mtree_alloc_{range,rrange}() currently have no users and can be easily
implemented with mas_empty_area{_rev}(). mas_{rev_}alloc() and
mas_fill_gap() are just their internal functions, drop them together.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-10 6:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-10 6:10 [PATCH 1/2] maple_tree: Drop the test code for mtree_alloc_{range,rrange}() Peng Zhang
2023-05-10 6:10 ` [PATCH 2/2] maple_tree: Drop mtree_alloc_{range,rrange}() and related functions Peng Zhang
2023-05-10 6:50 ` Peng Zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.