* [PATCH] iio: dac: build ad5758 driver when AD5758 is selected
@ 2023-05-08 4:02 Lukas Bulwahn
2023-05-13 18:19 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2023-05-08 4:02 UTC (permalink / raw
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Stefan Popa, linux-iio
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 28d1a7ac2a0d ("iio: dac: Add AD5758 support") adds the config AD5758
and the corresponding driver ad5758.c. In the Makefile, the ad5758 driver
is however included when AD5755 is selected, not when AD5758 is selected.
Probably, this was simply a mistake that happened by copy-and-paste and
forgetting to adjust the actual line. Surprisingly, no one has ever noticed
that this driver is actually only included when AD5755 is selected and that
the config AD5758 has actually no effect on the build.
Fixes: 28d1a7ac2a0d ("iio: dac: Add AD5758 support")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/iio/dac/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile
index 6c74fea21736..addd97a78838 100644
--- a/drivers/iio/dac/Makefile
+++ b/drivers/iio/dac/Makefile
@@ -17,7 +17,7 @@ obj-$(CONFIG_AD5592R_BASE) += ad5592r-base.o
obj-$(CONFIG_AD5592R) += ad5592r.o
obj-$(CONFIG_AD5593R) += ad5593r.o
obj-$(CONFIG_AD5755) += ad5755.o
-obj-$(CONFIG_AD5755) += ad5758.o
+obj-$(CONFIG_AD5758) += ad5758.o
obj-$(CONFIG_AD5761) += ad5761.o
obj-$(CONFIG_AD5764) += ad5764.o
obj-$(CONFIG_AD5766) += ad5766.o
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: dac: build ad5758 driver when AD5758 is selected
2023-05-08 4:02 [PATCH] iio: dac: build ad5758 driver when AD5758 is selected Lukas Bulwahn
@ 2023-05-13 18:19 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2023-05-13 18:19 UTC (permalink / raw
To: Lukas Bulwahn
Cc: Lars-Peter Clausen, Michael Hennerich, Stefan Popa, linux-iio,
kernel-janitors, linux-kernel
On Mon, 8 May 2023 06:02:08 +0200
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Commit 28d1a7ac2a0d ("iio: dac: Add AD5758 support") adds the config AD5758
> and the corresponding driver ad5758.c. In the Makefile, the ad5758 driver
> is however included when AD5755 is selected, not when AD5758 is selected.
>
> Probably, this was simply a mistake that happened by copy-and-paste and
> forgetting to adjust the actual line. Surprisingly, no one has ever noticed
> that this driver is actually only included when AD5755 is selected and that
> the config AD5758 has actually no effect on the build.
>
> Fixes: 28d1a7ac2a0d ("iio: dac: Add AD5758 support")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
oops. That's been there a while so good spot!
Applied to the fixes-togreg branch of iio.git and marked for stable inclusion
Thanks,
Jonathan
> ---
> drivers/iio/dac/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile
> index 6c74fea21736..addd97a78838 100644
> --- a/drivers/iio/dac/Makefile
> +++ b/drivers/iio/dac/Makefile
> @@ -17,7 +17,7 @@ obj-$(CONFIG_AD5592R_BASE) += ad5592r-base.o
> obj-$(CONFIG_AD5592R) += ad5592r.o
> obj-$(CONFIG_AD5593R) += ad5593r.o
> obj-$(CONFIG_AD5755) += ad5755.o
> -obj-$(CONFIG_AD5755) += ad5758.o
> +obj-$(CONFIG_AD5758) += ad5758.o
> obj-$(CONFIG_AD5761) += ad5761.o
> obj-$(CONFIG_AD5764) += ad5764.o
> obj-$(CONFIG_AD5766) += ad5766.o
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-13 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-08 4:02 [PATCH] iio: dac: build ad5758 driver when AD5758 is selected Lukas Bulwahn
2023-05-13 18:19 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.