* [PATCH] tracing: Add missing spaces in trace_print_hex_seq()
@ 2023-04-26 3:22 Ken Lin
0 siblings, 0 replies; only message in thread
From: Ken Lin @ 2023-04-26 3:22 UTC (permalink / raw
To: rostedt, mhiramat; +Cc: linux-kernel, linux-trace-kernel, Ken Lin
If the buffer length is larger than 16 and concatenate is set to false,
there would be missing spaces every 16 bytes.
Example:
Before: c5 11 10 50 05 4d 31 40 00 40 00 40 00 4d 31 4000 40 00
After: c5 11 10 50 05 4d 31 40 00 40 00 40 00 4d 31 40 00 40 00
Signed-off-by: Ken Lin <lyenting@google.com>
---
kernel/trace/trace_output.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index bd475a00f96d..6e45cf18d816 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -221,8 +221,11 @@ trace_print_hex_seq(struct trace_seq *p, const unsigned char *buf, int buf_len,
const char *ret = trace_seq_buffer_ptr(p);
const char *fmt = concatenate ? "%*phN" : "%*ph";
- for (i = 0; i < buf_len; i += 16)
+ for (i = 0; i < buf_len; i += 16) {
+ if (!concatenate && i != 0)
+ trace_seq_putc(p, ' ');
trace_seq_printf(p, fmt, min(buf_len - i, 16), &buf[i]);
+ }
trace_seq_putc(p, 0);
return ret;
--
2.40.1.495.gc816e09b53d-goog
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-26 3:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-26 3:22 [PATCH] tracing: Add missing spaces in trace_print_hex_seq() Ken Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.