All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [djwong-xfs:xfile-page-caching 182/274] fs/xfs/xfs_buf.h:397 xfs_buftarg_bdev() warn: bitwise AND condition is false here
@ 2023-03-17  4:26 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-03-17  4:26 UTC (permalink / raw
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Darrick J. Wong" <darrick.wong@oracle.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfile-page-caching
head:   67bb67e9a9941400f950d75d77991bf99c54ed05
commit: df57501f309978750154508eaa05cbffd6521627 [182/274] xfs: support in-memory buffer cache targets
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: ia64-randconfig-m031-20230312 (https://download.01.org/0day-ci/archive/20230317/202303171245.T2favzbi-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202303171245.T2favzbi-lkp@intel.com/

New smatch warnings:
fs/xfs/xfs_buf.h:397 xfs_buftarg_bdev() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.h:421 xfs_buftarg_flush() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.h:405 xfs_getsize_buftarg() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.h:413 xfs_readonly_buftarg() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.h:413 xfs_readonly_buftarg() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.h:397 xfs_buftarg_bdev() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.h:421 xfs_buftarg_flush() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.h:397 xfs_buftarg_bdev() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.h:413 xfs_readonly_buftarg() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.h:434 xfs_buftarg_zeroout() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.c:1638 _xfs_buf_ioapply() warn: bitwise AND condition is false here
fs/xfs/xfs_buf.c:2012 xfs_free_buftarg() warn: bitwise AND condition is false here

Old smatch warnings:
fs/xfs/xfs_log.c:3615 xlog_verify_tail_lsn() warn: inconsistent indenting
fs/xfs/xfs_buf.c:745 xfs_buf_get_map() error: we previously assumed 'bp' could be null (see line 727)

vim +397 fs/xfs/xfs_buf.h

d808f617ad00a4 fs/xfs/linux-2.6/xfs_buf.h Dave Chinner    2010-02-02  393  
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  394  static inline struct block_device *
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  395  xfs_buftarg_bdev(struct xfs_buftarg *btp)
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  396  {
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06 @397  	if (btp->bt_flags & XFS_BUFTARG_XFILE)
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06  398  		return NULL;
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  399  	return btp->bt_bdev;
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  400  }
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  401  
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  402  static inline unsigned int
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  403  xfs_getsize_buftarg(struct xfs_buftarg *btp)
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  404  {
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06 @405  	if (btp->bt_flags & XFS_BUFTARG_XFILE)
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06  406  		return SECTOR_SIZE;
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  407  	return block_size(btp->bt_bdev);
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  408  }
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  409  
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  410  static inline bool
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  411  xfs_readonly_buftarg(struct xfs_buftarg *btp)
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  412  {
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06 @413  	if (btp->bt_flags & XFS_BUFTARG_XFILE)
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06  414  		return false;
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  415  	return bdev_read_only(btp->bt_bdev);
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  416  }
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  417  
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  418  static inline int
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  419  xfs_buftarg_flush(struct xfs_buftarg *btp)
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  420  {
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06 @421  	if (btp->bt_flags & XFS_BUFTARG_XFILE)
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06  422  		return 0;
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  423  	return blkdev_issue_flush(btp->bt_bdev);
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  424  }
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  425  
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  426  static inline int
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  427  xfs_buftarg_zeroout(
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  428  	struct xfs_buftarg	*btp,
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  429  	sector_t		sector,
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  430  	sector_t		nr_sects,
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  431  	gfp_t			gfp_mask,
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  432  	unsigned		flags)
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  433  {
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06 @434  	if (btp->bt_flags & XFS_BUFTARG_XFILE)
df57501f309978 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-06  435  		return -EOPNOTSUPP;
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  436  	return blkdev_issue_zeroout(btp->bt_bdev, sector, nr_sects, gfp_mask,
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  437  			flags);
65157700a64ac5 fs/xfs/xfs_buf.h           Darrick J. Wong 2023-03-10  438  }
ce8e922c0e79c8 fs/xfs/linux-2.6/xfs_buf.h Nathan Scott    2006-01-11  439  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-17  4:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-17  4:26 [djwong-xfs:xfile-page-caching 182/274] fs/xfs/xfs_buf.h:397 xfs_buftarg_bdev() warn: bitwise AND condition is false here kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.