All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [sashal-stable:pending-4.14 134/146] drivers/thermal/intel_powerclamp.c:782:38: error: implicit declaration of function 'topology_max_die_per_package'
@ 2023-03-08 16:44 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-03-08 16:44 UTC (permalink / raw
  To: Sasha Levin; +Cc: oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-4.14
head:   ec5cc00d36670922ecb7e0b14c1909e2b0d7b3b1
commit: bdfde1a14a124ee09558214f1b2b855072c749e4 [134/146] thermal: intel: powerclamp: Fix cur_state for multi package system
config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20230309/202303090020.45npFTob-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/commit/?id=bdfde1a14a124ee09558214f1b2b855072c749e4
        git remote add sashal-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
        git fetch --no-tags sashal-stable pending-4.14
        git checkout bdfde1a14a124ee09558214f1b2b855072c749e4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash LDFLAGS=-z max-page-size=0x200000  drivers/thermal/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303090020.45npFTob-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/thermal/intel_powerclamp.c:782:38: error: implicit declaration of function 'topology_max_die_per_package' [-Werror,-Wimplicit-function-declaration]
           if (topology_max_packages() == 1 && topology_max_die_per_package() == 1)
                                               ^
   1 error generated.


vim +/topology_max_die_per_package +782 drivers/thermal/intel_powerclamp.c

   749	
   750	static int __init powerclamp_init(void)
   751	{
   752		int retval;
   753		int bitmap_size;
   754	
   755		bitmap_size = BITS_TO_LONGS(num_possible_cpus()) * sizeof(long);
   756		cpu_clamping_mask = kzalloc(bitmap_size, GFP_KERNEL);
   757		if (!cpu_clamping_mask)
   758			return -ENOMEM;
   759	
   760		/* probe cpu features and ids here */
   761		retval = powerclamp_probe();
   762		if (retval)
   763			goto exit_free;
   764	
   765		/* set default limit, maybe adjusted during runtime based on feedback */
   766		window_size = 2;
   767		retval = cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN,
   768						   "thermal/intel_powerclamp:online",
   769						   powerclamp_cpu_online,
   770						   powerclamp_cpu_predown);
   771		if (retval < 0)
   772			goto exit_free;
   773	
   774		hp_state = retval;
   775	
   776		worker_data = alloc_percpu(struct powerclamp_worker_data);
   777		if (!worker_data) {
   778			retval = -ENOMEM;
   779			goto exit_unregister;
   780		}
   781	
 > 782		if (topology_max_packages() == 1 && topology_max_die_per_package() == 1)
   783			poll_pkg_cstate_enable = true;
   784	
   785		cooling_dev = thermal_cooling_device_register("intel_powerclamp", NULL,
   786							&powerclamp_cooling_ops);
   787		if (IS_ERR(cooling_dev)) {
   788			retval = -ENODEV;
   789			goto exit_free_thread;
   790		}
   791	
   792		if (!duration)
   793			duration = jiffies_to_msecs(DEFAULT_DURATION_JIFFIES);
   794	
   795		powerclamp_create_debug_files();
   796	
   797		return 0;
   798	
   799	exit_free_thread:
   800		free_percpu(worker_data);
   801	exit_unregister:
   802		cpuhp_remove_state_nocalls(hp_state);
   803	exit_free:
   804		kfree(cpu_clamping_mask);
   805		return retval;
   806	}
   807	module_init(powerclamp_init);
   808	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-08 16:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-08 16:44 [sashal-stable:pending-4.14 134/146] drivers/thermal/intel_powerclamp.c:782:38: error: implicit declaration of function 'topology_max_die_per_package' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.