* [PATCH v2 0/2] usb: USB hubs require host mode
@ 2023-01-25 18:40 Heinrich Schuchardt
2023-01-25 18:40 ` [PATCH v2 1/2] " Heinrich Schuchardt
2023-01-25 18:40 ` [PATCH v2 2/2] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB Heinrich Schuchardt
0 siblings, 2 replies; 7+ messages in thread
From: Heinrich Schuchardt @ 2023-01-25 18:40 UTC (permalink / raw
To: Marek Vasut
Cc: Patrick Delaunay, Patrice Chotard, u-boot, Heinrich Schuchardt
USB hub code and settings are only relevant in host mode not in
gadget mode.
v2:
don't compile usb_hub.o without host mode
let CONFIG_USB_HUB_DEBOUNCE_TIMEOUT depend on CONFIG_USB_HOST
Heinrich Schuchardt (2):
usb: USB hubs require host mode
usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB
common/Kconfig | 12 ------------
common/Makefile | 2 +-
drivers/usb/Kconfig | 11 +++++++++++
3 files changed, 12 insertions(+), 13 deletions(-)
--
2.38.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] usb: USB hubs require host mode
2023-01-25 18:40 [PATCH v2 0/2] usb: USB hubs require host mode Heinrich Schuchardt
@ 2023-01-25 18:40 ` Heinrich Schuchardt
2023-01-25 19:16 ` Marek Vasut
2023-01-25 18:40 ` [PATCH v2 2/2] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB Heinrich Schuchardt
1 sibling, 1 reply; 7+ messages in thread
From: Heinrich Schuchardt @ 2023-01-25 18:40 UTC (permalink / raw
To: Marek Vasut
Cc: Patrick Delaunay, Patrice Chotard, u-boot, Heinrich Schuchardt
USB hubs run in host mode not in gadget mode. Hence, compiling usb_hub.c
should not be selected by CONFIG_USB_GADGET.
Suggested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
v2:
new patch
---
common/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/Makefile b/common/Makefile
index 252e9656df..a50302d8b5 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -24,7 +24,7 @@ obj-$(CONFIG_CMD_MII) += miiphyutil.o
obj-$(CONFIG_PHYLIB) += miiphyutil.o
obj-$(CONFIG_USB_HOST) += usb.o usb_hub.o
-obj-$(CONFIG_USB_GADGET) += usb.o usb_hub.o
+obj-$(CONFIG_USB_GADGET) += usb.o
obj-$(CONFIG_USB_STORAGE) += usb_storage.o
obj-$(CONFIG_USB_ONBOARD_HUB) += usb_onboard_hub.o
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB
2023-01-25 18:40 [PATCH v2 0/2] usb: USB hubs require host mode Heinrich Schuchardt
2023-01-25 18:40 ` [PATCH v2 1/2] " Heinrich Schuchardt
@ 2023-01-25 18:40 ` Heinrich Schuchardt
2023-01-25 19:16 ` Marek Vasut
2023-02-23 10:10 ` Patrick DELAUNAY
1 sibling, 2 replies; 7+ messages in thread
From: Heinrich Schuchardt @ 2023-01-25 18:40 UTC (permalink / raw
To: Marek Vasut
Cc: Patrick Delaunay, Patrice Chotard, u-boot, Heinrich Schuchardt
This configuration setting is only relevant if the board supports USB.
It should not be in the main menu but in the USB menu.
The setting is only relevant in USB host mode.
Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
v2:
let CONFIG_USB_HUB_DEBOUNCE_TIMEOUT depend on CONFIG_USB_HOST
---
common/Kconfig | 12 ------------
drivers/usb/Kconfig | 11 +++++++++++
2 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/common/Kconfig b/common/Kconfig
index e3a5e1be1e..0afc01b759 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -1106,15 +1106,3 @@ config FDT_SIMPLEFB
config IO_TRACE
bool
-
-config USB_HUB_DEBOUNCE_TIMEOUT
- int "Timeout in milliseconds for USB HUB connection"
- depends on USB
- default 1000
- help
- Value in milliseconds of the USB connection timeout, the max delay to
- wait the hub port status to be connected steadily after being powered
- off and powered on in the usb hub driver.
- This define allows to increase the HUB_DEBOUNCE_TIMEOUT default
- value = 1s because some usb device needs around 1.5s to be initialized
- and a 2s value should solve detection issue on problematic USB keys.
diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index ebe6bf9498..94fb32d107 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -115,6 +115,17 @@ config USB_ONBOARD_HUB
power regulator. An example for such a hub is the Microchip
USB2514B.
+config USB_HUB_DEBOUNCE_TIMEOUT
+ int "Timeout in milliseconds for USB HUB connection"
+ default 1000
+ help
+ Value in milliseconds of the USB connection timeout, the max delay to
+ wait the hub port status to be connected steadily after being powered
+ off and powered on in the usb hub driver.
+ This define allows to increase the HUB_DEBOUNCE_TIMEOUT default
+ value = 1s because some usb device needs around 1.5s to be initialized
+ and a 2s value should solve detection issue on problematic USB keys.
+
if USB_KEYBOARD
config USB_KEYBOARD_FN_KEYS
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] usb: USB hubs require host mode
2023-01-25 18:40 ` [PATCH v2 1/2] " Heinrich Schuchardt
@ 2023-01-25 19:16 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2023-01-25 19:16 UTC (permalink / raw
To: Heinrich Schuchardt; +Cc: Patrick Delaunay, Patrice Chotard, u-boot
On 1/25/23 19:40, Heinrich Schuchardt wrote:
> USB hubs run in host mode not in gadget mode. Hence, compiling usb_hub.c
> should not be selected by CONFIG_USB_GADGET.
>
> Suggested-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Marek Vasut <marex@denx.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB
2023-01-25 18:40 ` [PATCH v2 2/2] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB Heinrich Schuchardt
@ 2023-01-25 19:16 ` Marek Vasut
2023-02-23 10:10 ` Patrick DELAUNAY
1 sibling, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2023-01-25 19:16 UTC (permalink / raw
To: Heinrich Schuchardt; +Cc: Patrick Delaunay, Patrice Chotard, u-boot
On 1/25/23 19:40, Heinrich Schuchardt wrote:
> This configuration setting is only relevant if the board supports USB.
> It should not be in the main menu but in the USB menu.
>
> The setting is only relevant in USB host mode.
>
> Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Marek Vasut <marex@denx.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB
2023-01-25 18:40 ` [PATCH v2 2/2] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB Heinrich Schuchardt
2023-01-25 19:16 ` Marek Vasut
@ 2023-02-23 10:10 ` Patrick DELAUNAY
2023-02-23 13:38 ` Marek Vasut
1 sibling, 1 reply; 7+ messages in thread
From: Patrick DELAUNAY @ 2023-02-23 10:10 UTC (permalink / raw
To: Heinrich Schuchardt, Marek Vasut; +Cc: Patrice Chotard, u-boot
Hi,
On 1/25/23 19:40, Heinrich Schuchardt wrote:
> This configuration setting is only relevant if the board supports USB.
> It should not be in the main menu but in the USB menu.
>
> The setting is only relevant in USB host mode.
>
> Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> v2:
> let CONFIG_USB_HUB_DEBOUNCE_TIMEOUT depend on CONFIG_USB_HOST
> ---
> common/Kconfig | 12 ------------
> drivers/usb/Kconfig | 11 +++++++++++
> 2 files changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index e3a5e1be1e..0afc01b759 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -1106,15 +1106,3 @@ config FDT_SIMPLEFB
>
> config IO_TRACE
> bool
> -
> -config USB_HUB_DEBOUNCE_TIMEOUT
> - int "Timeout in milliseconds for USB HUB connection"
> - depends on USB
> - default 1000
> - help
> - Value in milliseconds of the USB connection timeout, the max delay to
> - wait the hub port status to be connected steadily after being powered
> - off and powered on in the usb hub driver.
> - This define allows to increase the HUB_DEBOUNCE_TIMEOUT default
> - value = 1s because some usb device needs around 1.5s to be initialized
> - and a 2s value should solve detection issue on problematic USB keys.
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index ebe6bf9498..94fb32d107 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -115,6 +115,17 @@ config USB_ONBOARD_HUB
> power regulator. An example for such a hub is the Microchip
> USB2514B.
>
> +config USB_HUB_DEBOUNCE_TIMEOUT
> + int "Timeout in milliseconds for USB HUB connection"
> + default 1000
> + help
> + Value in milliseconds of the USB connection timeout, the max delay to
> + wait the hub port status to be connected steadily after being powered
> + off and powered on in the usb hub driver.
> + This define allows to increase the HUB_DEBOUNCE_TIMEOUT default
> + value = 1s because some usb device needs around 1.5s to be initialized
> + and a 2s value should solve detection issue on problematic USB keys.
> +
> if USB_KEYBOARD
>
> config USB_KEYBOARD_FN_KEYS
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB
2023-02-23 10:10 ` Patrick DELAUNAY
@ 2023-02-23 13:38 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2023-02-23 13:38 UTC (permalink / raw
To: Patrick DELAUNAY, Heinrich Schuchardt; +Cc: Patrice Chotard, u-boot
On 2/23/23 11:10, Patrick DELAUNAY wrote:
> Hi,
>
> On 1/25/23 19:40, Heinrich Schuchardt wrote:
>> This configuration setting is only relevant if the board supports USB.
>> It should not be in the main menu but in the USB menu.
>>
>> The setting is only relevant in USB host mode.
>>
>> Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT")
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> ---
>> v2:
>> let CONFIG_USB_HUB_DEBOUNCE_TIMEOUT depend on CONFIG_USB_HOST
>> ---
>> common/Kconfig | 12 ------------
>> drivers/usb/Kconfig | 11 +++++++++++
>> 2 files changed, 11 insertions(+), 12 deletions(-)
>>
>> diff --git a/common/Kconfig b/common/Kconfig
>> index e3a5e1be1e..0afc01b759 100644
>> --- a/common/Kconfig
>> +++ b/common/Kconfig
>> @@ -1106,15 +1106,3 @@ config FDT_SIMPLEFB
>> config IO_TRACE
>> bool
>> -
>> -config USB_HUB_DEBOUNCE_TIMEOUT
>> - int "Timeout in milliseconds for USB HUB connection"
>> - depends on USB
>> - default 1000
>> - help
>> - Value in milliseconds of the USB connection timeout, the max
>> delay to
>> - wait the hub port status to be connected steadily after being
>> powered
>> - off and powered on in the usb hub driver.
>> - This define allows to increase the HUB_DEBOUNCE_TIMEOUT default
>> - value = 1s because some usb device needs around 1.5s to be
>> initialized
>> - and a 2s value should solve detection issue on problematic USB
>> keys.
>> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
>> index ebe6bf9498..94fb32d107 100644
>> --- a/drivers/usb/Kconfig
>> +++ b/drivers/usb/Kconfig
>> @@ -115,6 +115,17 @@ config USB_ONBOARD_HUB
>> power regulator. An example for such a hub is the Microchip
>> USB2514B.
>> +config USB_HUB_DEBOUNCE_TIMEOUT
>> + int "Timeout in milliseconds for USB HUB connection"
>> + default 1000
>> + help
>> + Value in milliseconds of the USB connection timeout, the max
>> delay to
>> + wait the hub port status to be connected steadily after being
>> powered
>> + off and powered on in the usb hub driver.
>> + This define allows to increase the HUB_DEBOUNCE_TIMEOUT default
>> + value = 1s because some usb device needs around 1.5s to be
>> initialized
>> + and a 2s value should solve detection issue on problematic USB
>> keys.
>> +
>> if USB_KEYBOARD
>> config USB_KEYBOARD_FN_KEYS
>
>
>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Applied both to usb/master, thanks for the reminder, sorry for the delay.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-02-23 13:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-25 18:40 [PATCH v2 0/2] usb: USB hubs require host mode Heinrich Schuchardt
2023-01-25 18:40 ` [PATCH v2 1/2] " Heinrich Schuchardt
2023-01-25 19:16 ` Marek Vasut
2023-01-25 18:40 ` [PATCH v2 2/2] usb: move CONFIG_USB_HUB_DEBOUNCE_TIMEOUT to USB Heinrich Schuchardt
2023-01-25 19:16 ` Marek Vasut
2023-02-23 10:10 ` Patrick DELAUNAY
2023-02-23 13:38 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.