* [PATCH] soc: imx: imx8mp-blk-ctrl: Do not set power domain name
@ 2022-12-17 23:36 Marek Vasut
2023-01-17 21:45 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2022-12-17 23:36 UTC (permalink / raw
To: linux-arm-kernel
Cc: Marek Vasut, Adam Ford, Benjamin Gaignard, Fabio Estevam,
Lucas Stach, Marco Felsch, NXP Linux Team, Paul Elder, Peng Fan,
Pengutronix Kernel Team, Sascha Hauer, Shawn Guo
Similar to commit b64b46fbaa1da626324f304bcb5fe0662f28b6ce
Domain name set confuses the sysfs cleanup path since the rename
is done after the device registration.
Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl")
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Adam Ford <aford173@gmail.com>
Cc: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Marco Felsch <m.felsch@pengutronix.de>
Cc: Marek Vasut <marex@denx.de>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Paul Elder <paul.elder@ideasonboard.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
To: linux-arm-kernel@lists.infradead.org
---
drivers/soc/imx/imx8mp-blk-ctrl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c
index b7d4161fcda9c..99fdb35d2b474 100644
--- a/drivers/soc/imx/imx8mp-blk-ctrl.c
+++ b/drivers/soc/imx/imx8mp-blk-ctrl.c
@@ -560,7 +560,6 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev)
ret = PTR_ERR(domain->power_dev);
goto cleanup_pds;
}
- dev_set_name(domain->power_dev, "%s", data->name);
domain->genpd.name = data->name;
domain->genpd.power_on = imx8mp_blk_ctrl_power_on;
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: imx: imx8mp-blk-ctrl: Do not set power domain name
2022-12-17 23:36 [PATCH] soc: imx: imx8mp-blk-ctrl: Do not set power domain name Marek Vasut
@ 2023-01-17 21:45 ` Marek Vasut
2023-01-18 9:24 ` Lucas Stach
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2023-01-17 21:45 UTC (permalink / raw
To: linux-arm-kernel, Shawn Guo
Cc: Adam Ford, Benjamin Gaignard, Fabio Estevam, Lucas Stach,
Marco Felsch, NXP Linux Team, Paul Elder, Peng Fan,
Pengutronix Kernel Team, Sascha Hauer
On 12/18/22 00:36, Marek Vasut wrote:
> Similar to commit b64b46fbaa1da626324f304bcb5fe0662f28b6ce
>
> Domain name set confuses the sysfs cleanup path since the rename
> is done after the device registration.
>
> Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl")
> Signed-off-by: Marek Vasut <marex@denx.de>
I'm afraid that without this patch, linux 6.1 does not even boot on
i.MX8M Plus . It would be good to apply it.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: imx: imx8mp-blk-ctrl: Do not set power domain name
2023-01-17 21:45 ` Marek Vasut
@ 2023-01-18 9:24 ` Lucas Stach
0 siblings, 0 replies; 3+ messages in thread
From: Lucas Stach @ 2023-01-18 9:24 UTC (permalink / raw
To: Marek Vasut, linux-arm-kernel, Shawn Guo
Cc: Adam Ford, Benjamin Gaignard, Fabio Estevam, Marco Felsch,
NXP Linux Team, Paul Elder, Peng Fan, Pengutronix Kernel Team,
Sascha Hauer
Hi Marek,
Am Dienstag, dem 17.01.2023 um 22:45 +0100 schrieb Marek Vasut:
> On 12/18/22 00:36, Marek Vasut wrote:
> > Similar to commit b64b46fbaa1da626324f304bcb5fe0662f28b6ce
> >
> > Domain name set confuses the sysfs cleanup path since the rename
> > is done after the device registration.
> >
> > Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl")
> > Signed-off-by: Marek Vasut <marex@denx.de>
>
> I'm afraid that without this patch, linux 6.1 does not even boot on
> i.MX8M Plus . It would be good to apply it.
The equivalent patch 21b84ebeee79 ("soc: imx: imx8mp-blk-ctrl: don't
set power device name") is already in Shawns fixes branch.
Regards,
Lucas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-18 9:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-17 23:36 [PATCH] soc: imx: imx8mp-blk-ctrl: Do not set power domain name Marek Vasut
2023-01-17 21:45 ` Marek Vasut
2023-01-18 9:24 ` Lucas Stach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.