All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] package/opensc: propagate dependencies from pcsc-lite
@ 2022-12-11 14:59 Yann E. MORIN
  2022-12-21 14:23 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Yann E. MORIN @ 2022-12-11 14:59 UTC (permalink / raw
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=071fdbf963228590b453e5111eadc8a74b579aa2
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Commit d590003e31dd (package/pcsc-lite: needs gcc >= 4.9) propagated
that new dependency to a bunch of packages that select pcsc-lite.

Then commit 8aaa7ecbce1d (package/opensc: new package) introduced
opensc, which selects pcsc-lite. However, the package was submitted
before the dependency to gcc 4.8+ was added to pcsc-lite, and that was
missed during the review.

Add it now.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
 package/opensc/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/opensc/Config.in b/package/opensc/Config.in
index 2cec096ac2..8c6a95a41d 100644
--- a/package/opensc/Config.in
+++ b/package/opensc/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_OPENSC
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pcsc-lite
 	select BR2_PACKAGE_PCSC_LITE
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_LIBOPENSSL
@@ -13,6 +14,7 @@ config BR2_PACKAGE_OPENSC
 
 	  https://github.com/OpenSC/OpenSC/wiki
 
-comment "opensc needs a toolchain with dynamic library, threads"
+comment "opensc needs a toolchain with dynamic library, threads, gcc >= 4.9"
 	depends on BR2_USE_MMU
-	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [git commit] package/opensc: propagate dependencies from pcsc-lite
  2022-12-11 14:59 [Buildroot] [git commit] package/opensc: propagate dependencies from pcsc-lite Yann E. MORIN
@ 2022-12-21 14:23 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2022-12-21 14:23 UTC (permalink / raw
  To: Yann E. MORIN; +Cc: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=071fdbf963228590b453e5111eadc8a74b579aa2
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > Commit d590003e31dd (package/pcsc-lite: needs gcc >= 4.9) propagated
 > that new dependency to a bunch of packages that select pcsc-lite.

 > Then commit 8aaa7ecbce1d (package/opensc: new package) introduced
 > opensc, which selects pcsc-lite. However, the package was submitted
 > before the dependency to gcc 4.8+ was added to pcsc-lite, and that was
 > missed during the review.

 > Add it now.

 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

Committed to 2022.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-21 14:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-11 14:59 [Buildroot] [git commit] package/opensc: propagate dependencies from pcsc-lite Yann E. MORIN
2022-12-21 14:23 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.