All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: fu740: Fix missing clk_disable_unprepare() in fu740_pcie_host_init()
@ 2022-12-05  8:40 Shang XiaoJing
  0 siblings, 0 replies; only message in thread
From: Shang XiaoJing @ 2022-12-05  8:40 UTC (permalink / raw
  To: paul.walmsley, greentime.hu, lpieralisi, robh, kw, bhelgaas,
	erik.danie, hes, linux-pci
  Cc: shangxiaojing

The clk_disable_unprepare() should be called in the error handling of
fu740_pcie_host_init().

Fixes: e7e21b3a339b ("PCI: fu740: Add SiFive FU740 PCIe host controller driver")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
 drivers/pci/controller/dwc/pcie-fu740.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
index 0c90583c078b..6d5b7fdc0048 100644
--- a/drivers/pci/controller/dwc/pcie-fu740.c
+++ b/drivers/pci/controller/dwc/pcie-fu740.c
@@ -261,6 +261,7 @@ static int fu740_pcie_host_init(struct dw_pcie_rp *pp)
 	ret = reset_control_deassert(afp->rst);
 	if (ret) {
 		dev_err(dev, "unable to deassert pcie_power_up_rst_n\n");
+		clk_disable_unprepare(afp->pcie_aux);
 		return ret;
 	}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-12-05  8:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-05  8:40 [PATCH] PCI: fu740: Fix missing clk_disable_unprepare() in fu740_pcie_host_init() Shang XiaoJing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.