* [PATCH] drivers: base: Print error code on synthetic uevent failure
@ 2022-08-24 23:52 Brian Norris
2022-09-09 14:00 ` [tip: sched/psi] " tip-bot2 for Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2022-08-24 23:52 UTC (permalink / raw
To: Greg Kroah-Hartman, Rafael J. Wysocki; +Cc: linux-kernel, Brian Norris
If we're going to log the failure, we might as well log the return code
too.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
drivers/base/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 753e7cca0f40..fd0410329046 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2509,7 +2509,7 @@ static ssize_t uevent_store(struct device *dev, struct device_attribute *attr,
rc = kobject_synth_uevent(&dev->kobj, buf, count);
if (rc) {
- dev_err(dev, "uevent: failed to send synthetic uevent\n");
+ dev_err(dev, "uevent: failed to send synthetic uevent: %d\n", rc);
return rc;
}
--
2.37.2.672.g94769d06f0-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: sched/psi] drivers: base: Print error code on synthetic uevent failure
2022-08-24 23:52 [PATCH] drivers: base: Print error code on synthetic uevent failure Brian Norris
@ 2022-09-09 14:00 ` tip-bot2 for Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Brian Norris @ 2022-09-09 14:00 UTC (permalink / raw
To: linux-tip-commits; +Cc: Brian Norris, Greg Kroah-Hartman, x86, linux-kernel
The following commit has been merged into the sched/psi branch of tip:
Commit-ID: 6bb7ea3afd3eaae95eda6ef5589c3087f2cd70d8
Gitweb: https://git.kernel.org/tip/6bb7ea3afd3eaae95eda6ef5589c3087f2cd70d8
Author: Brian Norris <briannorris@chromium.org>
AuthorDate: Wed, 24 Aug 2022 16:52:16 -07:00
Committer: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CommitterDate: Thu, 01 Sep 2022 18:15:50 +02:00
drivers: base: Print error code on synthetic uevent failure
If we're going to log the failure, we might as well log the return code
too.
Signed-off-by: Brian Norris <briannorris@chromium.org>
Link: https://lore.kernel.org/r/20220824165213.1.Ifdb98af3d0c23708a11d8d5ae5697bdb7e96a3cc@changeid
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/base/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 753e7cc..fd04103 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2509,7 +2509,7 @@ static ssize_t uevent_store(struct device *dev, struct device_attribute *attr,
rc = kobject_synth_uevent(&dev->kobj, buf, count);
if (rc) {
- dev_err(dev, "uevent: failed to send synthetic uevent\n");
+ dev_err(dev, "uevent: failed to send synthetic uevent: %d\n", rc);
return rc;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-09 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-24 23:52 [PATCH] drivers: base: Print error code on synthetic uevent failure Brian Norris
2022-09-09 14:00 ` [tip: sched/psi] " tip-bot2 for Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.