* [PATCH] configure: Drop obsolete check for the alloc_size attribute
@ 2021-07-14 7:28 Thomas Huth
2021-07-14 8:32 ` Daniel P. Berrangé
2021-07-14 14:56 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2021-07-14 7:28 UTC (permalink / raw
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial, Daniel P. Berrangé
We recently bumped our requirement for Clang to at least version 6.0.
And according to:
https://releases.llvm.org/6.0.0/tools/clang/docs/AttributeReference.html
Clang v6.0 supports the alloc_size attribute. Thus we can drop this
check in the configure script now.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
configure | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/configure b/configure
index a0a32c427c..eee1356814 100755
--- a/configure
+++ b/configure
@@ -3184,18 +3184,6 @@ if ! compile_prog "$glib_cflags" "$glib_libs" ; then
"build target"
fi
-# Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage
-cat > $TMPC << EOF
-#include <glib.h>
-int main(void) { return 0; }
-EOF
-if ! compile_prog "$glib_cflags -Werror" "$glib_libs" ; then
- if cc_has_warning_flag "-Wno-unknown-attributes"; then
- glib_cflags="-Wno-unknown-attributes $glib_cflags"
- CONFIGURE_CFLAGS="-Wno-unknown-attributes $CONFIGURE_CFLAGS"
- fi
-fi
-
# Silence clang warnings triggered by glib < 2.57.2
cat > $TMPC << EOF
#include <glib.h>
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] configure: Drop obsolete check for the alloc_size attribute
2021-07-14 7:28 [PATCH] configure: Drop obsolete check for the alloc_size attribute Thomas Huth
@ 2021-07-14 8:32 ` Daniel P. Berrangé
2021-07-14 14:56 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2021-07-14 8:32 UTC (permalink / raw
To: Thomas Huth; +Cc: qemu-trivial, Paolo Bonzini, qemu-devel
On Wed, Jul 14, 2021 at 09:28:55AM +0200, Thomas Huth wrote:
> We recently bumped our requirement for Clang to at least version 6.0.
> And according to:
>
> https://releases.llvm.org/6.0.0/tools/clang/docs/AttributeReference.html
>
> Clang v6.0 supports the alloc_size attribute. Thus we can drop this
> check in the configure script now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 12 ------------
> 1 file changed, 12 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] configure: Drop obsolete check for the alloc_size attribute
2021-07-14 7:28 [PATCH] configure: Drop obsolete check for the alloc_size attribute Thomas Huth
2021-07-14 8:32 ` Daniel P. Berrangé
@ 2021-07-14 14:56 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-07-14 14:56 UTC (permalink / raw
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial, Daniel P. Berrangé
On 14/07/21 09:28, Thomas Huth wrote:
> We recently bumped our requirement for Clang to at least version 6.0.
> And according to:
>
> https://releases.llvm.org/6.0.0/tools/clang/docs/AttributeReference.html
>
> Clang v6.0 supports the alloc_size attribute. Thus we can drop this
> check in the configure script now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/configure b/configure
> index a0a32c427c..eee1356814 100755
> --- a/configure
> +++ b/configure
> @@ -3184,18 +3184,6 @@ if ! compile_prog "$glib_cflags" "$glib_libs" ; then
> "build target"
> fi
>
> -# Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage
> -cat > $TMPC << EOF
> -#include <glib.h>
> -int main(void) { return 0; }
> -EOF
> -if ! compile_prog "$glib_cflags -Werror" "$glib_libs" ; then
> - if cc_has_warning_flag "-Wno-unknown-attributes"; then
> - glib_cflags="-Wno-unknown-attributes $glib_cflags"
> - CONFIGURE_CFLAGS="-Wno-unknown-attributes $CONFIGURE_CFLAGS"
> - fi
> -fi
> -
> # Silence clang warnings triggered by glib < 2.57.2
> cat > $TMPC << EOF
> #include <glib.h>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-14 14:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-14 7:28 [PATCH] configure: Drop obsolete check for the alloc_size attribute Thomas Huth
2021-07-14 8:32 ` Daniel P. Berrangé
2021-07-14 14:56 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.