From: "Nishanth Menon" <nm@ti.com>
To: Denys Dmytriyenko <denis@denix.org>
Cc: Tom Rini <tom.rini@gmail.com>, <meta-ti@lists.yoctoproject.org>
Subject: Re: [meta-ti] [PATCHv2] conf: am335x-evm: Add extlinux.conf support
Date: Mon, 14 Jun 2021 09:43:53 -0500 [thread overview]
Message-ID: <20210614144353.oajmyqlnv4sjhyzf@reputably> (raw)
In-Reply-To: <20210613193641.GB1528@denix.org>
On 15:36-20210613, Denys Dmytriyenko wrote:
> On Sat, Jun 12, 2021 at 09:13:31AM -0400, Tom Rini wrote:
> > To make use of the "generic distro boot" support in U-Boot, an
> > extlinux.conf file needs to be generated and reside in the extlinux
> > directory. The extlinux.conf file will be parsed by U-Boot and the
> > "append" line will be evaluated and expanded and used entirely as the
> > bootargs passed to the kernel. Our generated extlinux.conf states
> > that the kernel image and device trees live one level up (so the root
> > directory) from it, so populate that location with our kernel and device
> > trees.
> >
> > Signed-off-by: Tom Rini <trini@konsulko.com>
>
> Reviewed-by: Denys Dmytriyenko <denys@konsulko.com>
>
>
> > ---
> > Changes in v2:
> > - Elaborate on how this feature works in the commit message.
> > ---
> > conf/machine/include/ti33x.inc | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
> > index 6dfda754e9dd..35e057d57497 100644
> > --- a/conf/machine/include/ti33x.inc
> > +++ b/conf/machine/include/ti33x.inc
> > @@ -43,6 +43,15 @@ UBOOT_MACHINE = "am335x_evm_config"
> > UBOOT_ENTRYPOINT = "0x80008000"
> > UBOOT_LOADADDRESS = "0x80008000"
> >
> > +# Generate an extlinux.conf file
> > +UBOOT_EXTLINUX = "1"
> > +UBOOT_EXTLINUX_ROOT = "root=PARTUUID=${uuid}"
> > +UBOOT_EXTLINUX_BOOT_FILES = " \
> > + extlinux.conf;extlinux/extlinux.conf \
> > + ${KERNEL_IMAGETYPE} \
> > + ${KERNEL_DEVICETREE} \
> > +"
> > +
Does it make better if we do this in ti-soc.inc ?
> > SPL_BINARY = "MLO"
> > UBOOT_SUFFIX = "img"
> >
> > @@ -61,5 +70,5 @@ TI_PDK_LIMIT_BOARDS = "evmAM335x icev2AM335x iceAMIC110 bbbAM335x skAM335x"
> >
> > IMAGE_FSTYPES += "tar.xz wic.xz"
> > WKS_FILE ?= "sdimage-2part.wks"
> > -IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX}"
> > +IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX} ${UBOOT_EXTLINUX_BOOT_FILES}"
> > do_image_wic[depends] += "virtual/bootloader:do_deploy"
> > --
> > 2.17.1
> >
>
>
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2021-06-14 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <16875AD11A54340A.8333@lists.yoctoproject.org>
2021-06-12 13:13 ` [PATCHv2] conf: am335x-evm: Add extlinux.conf support Tom Rini
2021-06-13 19:36 ` [meta-ti] " Denys Dmytriyenko
2021-06-14 14:43 ` Nishanth Menon [this message]
2021-06-14 16:02 ` Tom Rini
2021-06-14 16:27 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614144353.oajmyqlnv4sjhyzf@reputably \
--to=nm@ti.com \
--cc=denis@denix.org \
--cc=meta-ti@lists.yoctoproject.org \
--cc=tom.rini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.