* [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics
@ 2021-06-12 20:54 Caleb Connolly
2021-06-13 4:21 ` Bjorn Andersson
2021-06-13 4:22 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Caleb Connolly @ 2021-06-12 20:54 UTC (permalink / raw)
To: caleb, Andy Gross, Bjorn Andersson, Rob Herring
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel
Add bindings for Qualcomm QPNP haptics, setting default values used on
most devices.
Signed-off-by: Caleb Connolly <caleb@connolly.tech>
---
arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
index d230c510d4b7..ccf64c1898d4 100644
--- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
@@ -1,4 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
+#include <dt-bindings/input/qcom,qpnp-haptics.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/spmi/spmi.h>
@@ -41,5 +42,20 @@ lab: lab {
interrupt-names = "sc-err", "ocp";
};
};
+
+ qpnp_haptics: qcom,haptics@c000 {
+ compatible = "qcom,qpnp-haptics";
+ reg = <0xc000 0x100>;
+
+ interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>,
+ <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>;
+ interrupt-names = "short", "play";
+
+ qcom,wave-shape = <HAP_WAVE_SINE>;
+ qcom,play-mode = <HAP_PLAY_BUFFER>;
+ qcom,brake-pattern = <0x3 0x3 0x2 0x1>;
+
+ status = "disabled";
+ };
};
};
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics
2021-06-12 20:54 [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics Caleb Connolly
@ 2021-06-13 4:21 ` Bjorn Andersson
2021-06-13 4:22 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-06-13 4:21 UTC (permalink / raw)
To: Caleb Connolly
Cc: Andy Gross, Rob Herring, ~postmarketos/upstreaming, phone-devel,
linux-arm-msm, devicetree, linux-kernel
On Sat 12 Jun 15:54 CDT 2021, Caleb Connolly wrote:
> Add bindings for Qualcomm QPNP haptics, setting default values used on
> most devices.
>
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> ---
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index d230c510d4b7..ccf64c1898d4 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -1,4 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0
> +#include <dt-bindings/input/qcom,qpnp-haptics.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
>
> @@ -41,5 +42,20 @@ lab: lab {
> interrupt-names = "sc-err", "ocp";
> };
> };
> +
> + qpnp_haptics: qcom,haptics@c000 {
No qcom, in node name, please.
> + compatible = "qcom,qpnp-haptics";
> + reg = <0xc000 0x100>;
#size-cells is <0>, so this means 2 addresses. Please drop the "length".
Regards,
Bjorn
> +
> + interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>;
> + interrupt-names = "short", "play";
> +
> + qcom,wave-shape = <HAP_WAVE_SINE>;
> + qcom,play-mode = <HAP_PLAY_BUFFER>;
> + qcom,brake-pattern = <0x3 0x3 0x2 0x1>;
> +
> + status = "disabled";
> + };
> };
> };
> --
> 2.31.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics
2021-06-12 20:54 [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics Caleb Connolly
2021-06-13 4:21 ` Bjorn Andersson
@ 2021-06-13 4:22 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-06-13 4:22 UTC (permalink / raw)
To: Caleb Connolly
Cc: Andy Gross, Rob Herring, ~postmarketos/upstreaming, phone-devel,
linux-arm-msm, devicetree, linux-kernel
On Sat 12 Jun 15:54 CDT 2021, Caleb Connolly wrote:
> Add bindings for Qualcomm QPNP haptics, setting default values used on
> most devices.
>
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> ---
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index d230c510d4b7..ccf64c1898d4 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -1,4 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0
> +#include <dt-bindings/input/qcom,qpnp-haptics.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
>
> @@ -41,5 +42,20 @@ lab: lab {
> interrupt-names = "sc-err", "ocp";
> };
> };
> +
> + qpnp_haptics: qcom,haptics@c000 {
Also, please label this pmi8998_haptics, to make it easier to find where
it's defined when looking at the .dts.
Thanks,
Bjorn
> + compatible = "qcom,qpnp-haptics";
> + reg = <0xc000 0x100>;
> +
> + interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>;
> + interrupt-names = "short", "play";
> +
> + qcom,wave-shape = <HAP_WAVE_SINE>;
> + qcom,play-mode = <HAP_PLAY_BUFFER>;
> + qcom,brake-pattern = <0x3 0x3 0x2 0x1>;
> +
> + status = "disabled";
> + };
> };
> };
> --
> 2.31.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-13 4:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 20:54 [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics Caleb Connolly
2021-06-13 4:21 ` Bjorn Andersson
2021-06-13 4:22 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.