From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D867C49360 for ; Sat, 12 Jun 2021 12:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76CE2610C9 for ; Sat, 12 Jun 2021 12:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231419AbhFLNBZ (ORCPT ); Sat, 12 Jun 2021 09:01:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbhFLNBY (ORCPT ); Sat, 12 Jun 2021 09:01:24 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF98CC061574; Sat, 12 Jun 2021 05:59:17 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id w23-20020a9d5a970000b02903d0ef989477so6005578oth.9; Sat, 12 Jun 2021 05:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZIFz0BtmkjFj3bkkH8PuE91K4c5YccOjYJdoSb+1UZw=; b=TEkxtKoVCT/P8tBtKk8O15WKo/797BscQjnlCuX2IA3xQf0iYThWesfGQMY1CnoUin gustkgdgRrzJcapw+1Vmpgsu2e2lsPAPTtb4Ayq5J5VMnAKePlryv1NZlR+GYHi49G5r ARs7mIJq2GVop/5aA2I5ZQCTOFdK8XVzd1WlftzkrCO9oQWILxqpVs5maQnI4jcoJfxt 0zHK5WuAguUvGwNZEO6N+vz7i5m+6wfdx7EA7/v2WScZMjdZ9+TRo9j3t/T6C+wOtVUE ffqsOUtTIpX6kyKl1R6v4uVHw4m6W8nVRWjJiVTdF2DfxgvQGNWkXgQpT1lrocFhqrPk 2C7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=ZIFz0BtmkjFj3bkkH8PuE91K4c5YccOjYJdoSb+1UZw=; b=msj3994rfrMVVLbKapq3wAXYvngZjUIsMaSeltNPrL8Gr//xIdCmGA1NUgsGAAThKZ f1DyB7QdwoBONj8I//y+4V7xZgbMg8gCH4h+V8PnZaNiGwb8zOD89J6NX7Wl25v6+zEq cwFproSSiylSBE4nG8QTx+y8dnrmQa+xwYosJtYA6taR/TsB7mvUERL1zXVRvxBh8/28 IJknZXerKpRUTpHgrF+KhoWb8qrw+3UZQVPyVTvzr3qGZEuaHhXdiX/5vW7RbnzOO9ta pOPaU1WFHeveGhOUEJF/uUQf1Ga7yV+JaFm7ZvlmxCLISk9M08QhdiPt/SUWSm0l3Zpd Z/rA== X-Gm-Message-State: AOAM530PIs2lppxOj7QCbmErYMkg/P+f75PcrxFgiztjXYHmny94OW1t 137zwbAoPDaRaCCBfo38aTo= X-Google-Smtp-Source: ABdhPJwiJaZfxu8otOuUwqtwrbMTXy7n3lY+zzFDQduJ2Gxx49M4jTtI7sp1U2Tl2OwQvLS+N1bH9w== X-Received: by 2002:a9d:77c8:: with SMTP id w8mr6632293otl.137.1623502757252; Sat, 12 Jun 2021 05:59:17 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id s15sm1792922oih.15.2021.06.12.05.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Jun 2021 05:59:16 -0700 (PDT) Sender: Guenter Roeck Date: Sat, 12 Jun 2021 05:59:15 -0700 From: Guenter Roeck To: Romain Perier Cc: Wim Van Sebroeck , Rob Herring , Daniel Palmer , Mohammed Billoo , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] Add watchdog for Mstar SoCs Message-ID: <20210612125915.GA320112@roeck-us.net> References: <20210611200801.52139-1-romain.perier@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210611200801.52139-1-romain.perier@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 11, 2021 at 10:07:58PM +0200, Romain Perier wrote: > This patches series adds a new driver for the watchdog found in the Mstar > MSC313e SoCs and newer. It adds a basic watchdog driver, the > corresponding devicetree bindings and its documentation. > > This work has been co-developed with Daniel Palmer. > > Changes since v3: > - Rebased onto v5.13-rc5 > - Added Reviewed-by tags This works better. I applied patches 1 & 2 to my watchdog-next branch for hand-off to Wim. Note that the arm dts patch needs to be pushed through the arm tree. Thanks, Guenter > > Changes since v2: > - Renamed the dt-bindings documentation to mstar,msc313e-wdt.yaml > - Fixed the subject of the first commit > - Dropped unused dt labels > > Changes since v1: > - Dropped "depends OF" from Kconfig (not required) > - Dropped unneeded include files > - Re-ordered include files > - Compute timeout_max dynamically from the probe function to avoid > an overflow in _start(). > > Daniel Palmer (1): > watchdog: Add Mstar MSC313e WDT driver > > Romain Perier (2): > dt-bindings: watchdog: Add Mstar MSC313e WDT devicetree bindings > documentation > ARM: dts: mstar: Add watchdog device_node definition > > .../bindings/watchdog/mstar,msc313e-wdt.yaml | 40 +++++ > MAINTAINERS | 1 + > arch/arm/boot/dts/mstar-v7.dtsi | 14 ++ > drivers/watchdog/Kconfig | 12 ++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/msc313e_wdt.c | 166 ++++++++++++++++++ > 6 files changed, 234 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/mstar,msc313e-wdt.yaml > create mode 100644 drivers/watchdog/msc313e_wdt.c > > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C946CC48BCF for ; Sat, 12 Jun 2021 13:02:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D6C961019 for ; Sat, 12 Jun 2021 13:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D6C961019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BK0Ky0I+ZmgxmGw74pXNnd+7WO1ldGMmOMTMU/z+Dpk=; b=zM3h4QKL1QBHI0 +IHE4LXWbxdUGwbHjabVzMIqjQjhPSHkbuxvxBHRyKOJ8SjVlPQUkAhVEE+MKR3NNMVmXUGBgUrPU nOS4evzym5zXjnugKbVNEOU7l0i5S96851hho5/Uty3+k8ytFoJbbiHYzOVWAS8xtaQ9KLSXmVIcp ST6H59v2+N+mv+FMmrENOKCyp6UDDVOySo4NwRSl2x0oVctNYXkIlWklZAVszsyzJ6BfyE6O3WfZw 0MxqEKG/0M3bo2ywEmeDRt9jSurb0qZU6aBP5U6LbAjYwtr7M810DMIje3C0LHRsW8d13m/lxuynw n7ckmZbRNG9O0vCa3OZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ls3Fa-008WuS-9o; Sat, 12 Jun 2021 13:00:35 +0000 Received: from mail-ot1-f46.google.com ([209.85.210.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ls3FQ-008WqC-PP for linux-arm-kernel@lists.infradead.org; Sat, 12 Jun 2021 13:00:26 +0000 Received: by mail-ot1-f46.google.com with SMTP id i12-20020a05683033ecb02903346fa0f74dso6005382otu.10 for ; Sat, 12 Jun 2021 06:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZIFz0BtmkjFj3bkkH8PuE91K4c5YccOjYJdoSb+1UZw=; b=TEkxtKoVCT/P8tBtKk8O15WKo/797BscQjnlCuX2IA3xQf0iYThWesfGQMY1CnoUin gustkgdgRrzJcapw+1Vmpgsu2e2lsPAPTtb4Ayq5J5VMnAKePlryv1NZlR+GYHi49G5r ARs7mIJq2GVop/5aA2I5ZQCTOFdK8XVzd1WlftzkrCO9oQWILxqpVs5maQnI4jcoJfxt 0zHK5WuAguUvGwNZEO6N+vz7i5m+6wfdx7EA7/v2WScZMjdZ9+TRo9j3t/T6C+wOtVUE ffqsOUtTIpX6kyKl1R6v4uVHw4m6W8nVRWjJiVTdF2DfxgvQGNWkXgQpT1lrocFhqrPk 2C7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=ZIFz0BtmkjFj3bkkH8PuE91K4c5YccOjYJdoSb+1UZw=; b=kP8rfqN1Q3O10wfjDdazJkHPPPqlWJdpkYiHioBTIlvsy/MNrdMT5imKSCrplmu+Bo PrsYcc0b1c+TPgwDGWjzB3hd6C5apdtZE/uXraJ7tpsE/6MNPp6T/AS3s85rEH2IkOcJ V9mxmCF1bVm0KTsZGpoWCUZBUVMrnAzGEFpahLjqAJ6PupT3A8cYZVoBozp/97b3a5uZ RMxgIeSxvr4Pjw/Vdi3tW/80B965GMijZ3bu1VQAHn0KsrA7Zm6c2XgYG6SSzojMTmtF EKQWMqqS+sr5+Vf9wDKWk8pRldDZbjRk0JuEQE0aOGBR6CpWxIQh0NYmjgBnOl+7KRlr umcw== X-Gm-Message-State: AOAM5337tWCkd++Pjo7C0ljmuMIgWYONU19J13QJo6IGxc2j6t1Wzs/I TmcAYK+fJTtjzMibpQBwKRI= X-Google-Smtp-Source: ABdhPJwiJaZfxu8otOuUwqtwrbMTXy7n3lY+zzFDQduJ2Gxx49M4jTtI7sp1U2Tl2OwQvLS+N1bH9w== X-Received: by 2002:a9d:77c8:: with SMTP id w8mr6632293otl.137.1623502757252; Sat, 12 Jun 2021 05:59:17 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id s15sm1792922oih.15.2021.06.12.05.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Jun 2021 05:59:16 -0700 (PDT) Date: Sat, 12 Jun 2021 05:59:15 -0700 From: Guenter Roeck To: Romain Perier Cc: Wim Van Sebroeck , Rob Herring , Daniel Palmer , Mohammed Billoo , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] Add watchdog for Mstar SoCs Message-ID: <20210612125915.GA320112@roeck-us.net> References: <20210611200801.52139-1-romain.perier@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210611200801.52139-1-romain.perier@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210612_060024_881318_4523401A X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 11, 2021 at 10:07:58PM +0200, Romain Perier wrote: > This patches series adds a new driver for the watchdog found in the Mstar > MSC313e SoCs and newer. It adds a basic watchdog driver, the > corresponding devicetree bindings and its documentation. > > This work has been co-developed with Daniel Palmer. > > Changes since v3: > - Rebased onto v5.13-rc5 > - Added Reviewed-by tags This works better. I applied patches 1 & 2 to my watchdog-next branch for hand-off to Wim. Note that the arm dts patch needs to be pushed through the arm tree. Thanks, Guenter > > Changes since v2: > - Renamed the dt-bindings documentation to mstar,msc313e-wdt.yaml > - Fixed the subject of the first commit > - Dropped unused dt labels > > Changes since v1: > - Dropped "depends OF" from Kconfig (not required) > - Dropped unneeded include files > - Re-ordered include files > - Compute timeout_max dynamically from the probe function to avoid > an overflow in _start(). > > Daniel Palmer (1): > watchdog: Add Mstar MSC313e WDT driver > > Romain Perier (2): > dt-bindings: watchdog: Add Mstar MSC313e WDT devicetree bindings > documentation > ARM: dts: mstar: Add watchdog device_node definition > > .../bindings/watchdog/mstar,msc313e-wdt.yaml | 40 +++++ > MAINTAINERS | 1 + > arch/arm/boot/dts/mstar-v7.dtsi | 14 ++ > drivers/watchdog/Kconfig | 12 ++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/msc313e_wdt.c | 166 ++++++++++++++++++ > 6 files changed, 234 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/mstar,msc313e-wdt.yaml > create mode 100644 drivers/watchdog/msc313e_wdt.c > > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel