From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5120FC48BD1 for ; Fri, 11 Jun 2021 15:36:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30E41613CD for ; Fri, 11 Jun 2021 15:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbhFKPih (ORCPT ); Fri, 11 Jun 2021 11:38:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231726AbhFKPif (ORCPT ); Fri, 11 Jun 2021 11:38:35 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5376CC061574 for ; Fri, 11 Jun 2021 08:36:37 -0700 (PDT) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1lrjCI-0004Tj-9y; Fri, 11 Jun 2021 17:35:50 +0200 Date: Fri, 11 Jun 2021 17:35:50 +0200 From: Martin Kaiser To: Dan Carpenter Cc: Phillip Potter , gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, straube.linux@gmail.com, kaixuxia@tencent.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, liushixin2@huawei.com, unixbhaskar@gmail.com, gustavoars@kernel.org, bkkarthik@pesu.pes.edu Subject: Re: [PATCH 0/6] staging: rtl8188eu: remove hal/odm_debug.h Message-ID: <20210611153550.7p2deovau37rlpju@viti.kaiser.cx> References: <20210611002504.166405-1-phil@philpotter.co.uk> <20210611091010.GE10983@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210611091010.GE10983@kadam> User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thus wrote Dan Carpenter (dan.carpenter@oracle.com): > On Fri, Jun 11, 2021 at 01:24:58AM +0100, Phillip Potter wrote: > > This series removes hal/odm_debug.h, which contains various preprocessor > > definitions, as well as an unwieldy ODM_RT_TRACE macro which is not best > > practice. It also removes all uses of this macro, and the associated > > fields in struct odm_dm_struct which are only used by this macro. > > This makes the code cleaner, thus moving it closer to getting out of > > staging. > Looks good. > Reviewed-by: Dan Carpenter same here: looks ok and doesn't break anything Reviewed-by: Martin Kaiser Tested-by: Martin Kaiser Best regards, Martin