From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0B9C47094 for ; Thu, 10 Jun 2021 13:12:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71D2A613DE for ; Thu, 10 Jun 2021 13:12:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71D2A613DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrKTe-0001lj-MK for qemu-devel@archiver.kernel.org; Thu, 10 Jun 2021 09:12:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrKSY-0000lo-NU for qemu-devel@nongnu.org; Thu, 10 Jun 2021 09:10:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrKSW-00064l-QU for qemu-devel@nongnu.org; Thu, 10 Jun 2021 09:10:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623330656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3m4bOvYnmUCVtlNeznHWszna0xnox4X3aw4WbVLR5g=; b=GsU0wKIRwzocRscrGyL2DX3VUXUzt9Dh30hL8PWuntefsbi/KiDpJoz2HI7DNCmHtRFYkT W6oPlev9wvZrKjuf0qEAOg7pETIVlKl/9fyYhTpLpH9sRWqXds36/nsY2rBT8XolQPt099 kohlQRpoleeLrJPYMKiXGWed+VHOUR4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-EOA_tOoYMPOi05tbectEJg-1; Thu, 10 Jun 2021 09:10:55 -0400 X-MC-Unique: EOA_tOoYMPOi05tbectEJg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5D6580364C; Thu, 10 Jun 2021 13:10:52 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-69.ams2.redhat.com [10.36.113.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 85D05690EF; Thu, 10 Jun 2021 13:10:47 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A808018000B2; Thu, 10 Jun 2021 15:10:44 +0200 (CEST) Date: Thu, 10 Jun 2021 15:10:44 +0200 From: Gerd Hoffmann To: Claudio Fontana Subject: Re: [PATCH 0/4] modules: add support for target-specific modules. Message-ID: <20210610131044.32iioustv7vev4p5@sirius.home.kraxel.org> References: <20210610101553.943689-1-kraxel@redhat.com> <4a1a23af-461f-92c4-d9f0-1f8133d611db@suse.de> <20210610122305.zxdaqsft5evcrli6@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: <20210610122305.zxdaqsft5evcrli6@sirius.home.kraxel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Christian Schoenebeck , Greg Kurz , qemu-devel@nongnu.org, jose.ziviani@suse.com, pbonzini@redhat.com, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > Build qtest modular on top of that was easy, patch below. > > I'm not convinced though that the approach will work for other > accelerators too given that they have dependencies to directories > outside accel/ ... Oh, it depends on how high you hang the tcg modularization bar. Building only the tcg accel ops as module is easy too, but that of course leaves a large chunk of tcg linked into qemu itself. take care, Gerd >From 8062aabd26f12bd8199b43c631a3aba8f195183e Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Thu, 10 Jun 2021 14:48:20 +0200 Subject: [PATCH] modules: build tcg accel modular MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's not all of tcg, only the accel ops, but its a start 😊 Signed-off-by: Gerd Hoffmann --- accel/accel-softmmu.c | 2 +- accel/tcg/tcg-accel-ops.c | 2 ++ accel/tcg/meson.build | 6 ++++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/accel/accel-softmmu.c b/accel/accel-softmmu.c index 50fa5acaa401..67276e4f5222 100644 --- a/accel/accel-softmmu.c +++ b/accel/accel-softmmu.c @@ -72,7 +72,7 @@ void accel_init_ops_interfaces(AccelClass *ac) g_assert(ac_name != NULL); ops_name = g_strdup_printf("%s" ACCEL_OPS_SUFFIX, ac_name); - ops = ACCEL_OPS_CLASS(object_class_by_name(ops_name)); + ops = ACCEL_OPS_CLASS(module_object_class_by_name(ops_name)); g_free(ops_name); /* diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 7191315aeed4..432a76d2ea29 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -124,9 +124,11 @@ static const TypeInfo tcg_accel_ops_type = { .class_init = tcg_accel_ops_class_init, .abstract = true, }; +module_obj("tcg-accel-ops"); // FIXME: use ACCEL_OPS_NAME static void tcg_accel_ops_register_types(void) { type_register_static(&tcg_accel_ops_type); } type_init(tcg_accel_ops_register_types); +module_arch(TARGET_NAME); diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build index 1236ac7b910b..0362b1bd5918 100644 --- a/accel/tcg/meson.build +++ b/accel/tcg/meson.build @@ -15,8 +15,14 @@ specific_ss.add_all(when: 'CONFIG_TCG', if_true: tcg_ss) specific_ss.add(when: ['CONFIG_SOFTMMU', 'CONFIG_TCG'], if_true: files( 'cputlb.c', +)) + +tcg_module_ss = ss.source_set() +tcg_module_ss.add(when: ['CONFIG_SOFTMMU', 'CONFIG_TCG'], if_true: files( 'tcg-accel-ops.c', 'tcg-accel-ops-mttcg.c', 'tcg-accel-ops-icount.c', 'tcg-accel-ops-rr.c' )) + +accel_modules += {'tcg': tcg_module_ss } -- 2.31.1