From: Daniel Wagner <dwagner@suse.de>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] Revert "nvme: verify MNAN value if ANA is enabled"
Date: Thu, 10 Jun 2021 13:51:26 +0200 [thread overview]
Message-ID: <20210610115126.r3fxxtgnuyq447su@beryllium.lan> (raw)
In-Reply-To: <20210610074546.jyqjalpldii6reg6@beryllium.lan>
On Thu, Jun 10, 2021 at 09:45:46AM +0200, Daniel Wagner wrote:
> > id->nn = cpu_to_le32(ctrl->subsys->max_nsid);
> > - id->mnan = cpu_to_le32(NVMET_MAX_NAMESPACES);
> > + id->mnan = cpu_to_le32(ctrl->subsys->max_nsid);
> > id->oncs = cpu_to_le16(NVME_CTRL_ONCS_DSM |
> > NVME_CTRL_ONCS_WRITE_ZEROES);
>
I am a bit confused how the target code indexes the namespaces. In 6.1
Namespaces the valid range for NSID is defined from 0 to namespace
-1. In 6.1.2 it says 'Any NSID is valid, except if that NSID is 0h or
greater than the Number of Namespaces'. And the figure 348 shows clearly
NSID 0 is not valid.
Looking through the code I think the nsid range used starts at 0 and not
at 1. Which would explain why the above change is not enough. The valid
range for max_nsid should start at 1 and not 0.
Thoughts?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-06-10 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 2:45 [PATCH] Revert "nvme: verify MNAN value if ANA is enabled" Chaitanya Kulkarni
2021-06-10 2:55 ` Chaitanya Kulkarni
2021-06-10 7:45 ` Daniel Wagner
2021-06-10 11:51 ` Daniel Wagner [this message]
2021-06-10 20:32 ` Chaitanya Kulkarni
2021-06-11 9:08 ` Daniel Wagner
2021-06-10 21:01 ` Chaitanya Kulkarni
2021-06-11 9:17 ` Daniel Wagner
2021-06-12 19:18 ` Chaitanya Kulkarni
2021-06-13 20:06 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610115126.r3fxxtgnuyq447su@beryllium.lan \
--to=dwagner@suse.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.