From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
kernel@pengutronix.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Michael Grzeschik <m.grzeschik@pengutronix.de>
Subject: Re: [PATCH net-next v3 3/9] net: phy: micrel: use consistent indention after define
Date: Thu, 10 Jun 2021 12:30:03 +0200 [thread overview]
Message-ID: <20210610103003.n5jgeppvf4aod5hw@pengutronix.de> (raw)
In-Reply-To: <20210526222448.zjpw3olck75332px@skbuf>
On Thu, May 27, 2021 at 01:24:48AM +0300, Vladimir Oltean wrote:
> On Wed, May 26, 2021 at 06:30:31AM +0200, Oleksij Rempel wrote:
> > This patch changes the indention to one space between "#define" and the
>
> indention
> /ɪnˈdɛnʃ(ə)n/
> noun
> noun: indention; plural noun: indentions
>
> archaic term for indentation.
>
> Interesting, I learned something new.
>
> Also, technically it's alignment not indentation.
ok, changed :)
> > macro.
> >
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > drivers/net/phy/micrel.c | 24 ++++++++++++------------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> > index a14a00328fa3..227d88db7d27 100644
> > --- a/drivers/net/phy/micrel.c
> > +++ b/drivers/net/phy/micrel.c
> > @@ -38,15 +38,15 @@
> >
> > /* general Interrupt control/status reg in vendor specific block. */
> > #define MII_KSZPHY_INTCS 0x1B
> > -#define KSZPHY_INTCS_JABBER BIT(15)
> > -#define KSZPHY_INTCS_RECEIVE_ERR BIT(14)
> > -#define KSZPHY_INTCS_PAGE_RECEIVE BIT(13)
> > -#define KSZPHY_INTCS_PARELLEL BIT(12)
> > -#define KSZPHY_INTCS_LINK_PARTNER_ACK BIT(11)
> > -#define KSZPHY_INTCS_LINK_DOWN BIT(10)
> > -#define KSZPHY_INTCS_REMOTE_FAULT BIT(9)
> > -#define KSZPHY_INTCS_LINK_UP BIT(8)
> > -#define KSZPHY_INTCS_ALL (KSZPHY_INTCS_LINK_UP |\
> > +#define KSZPHY_INTCS_JABBER BIT(15)
> > +#define KSZPHY_INTCS_RECEIVE_ERR BIT(14)
> > +#define KSZPHY_INTCS_PAGE_RECEIVE BIT(13)
> > +#define KSZPHY_INTCS_PARELLEL BIT(12)
> > +#define KSZPHY_INTCS_LINK_PARTNER_ACK BIT(11)
> > +#define KSZPHY_INTCS_LINK_DOWN BIT(10)
> > +#define KSZPHY_INTCS_REMOTE_FAULT BIT(9)
> > +#define KSZPHY_INTCS_LINK_UP BIT(8)
> > +#define KSZPHY_INTCS_ALL (KSZPHY_INTCS_LINK_UP |\
> > KSZPHY_INTCS_LINK_DOWN)
> > #define KSZPHY_INTCS_LINK_DOWN_STATUS BIT(2)
> > #define KSZPHY_INTCS_LINK_UP_STATUS BIT(0)
>
> You left these aligned using tabs.
done.
> > @@ -54,11 +54,11 @@
> > KSZPHY_INTCS_LINK_UP_STATUS)
> >
> > /* PHY Control 1 */
> > -#define MII_KSZPHY_CTRL_1 0x1e
> > +#define MII_KSZPHY_CTRL_1 0x1e
> >
> > /* PHY Control 2 / PHY Control (if no PHY Control 1) */
> > -#define MII_KSZPHY_CTRL_2 0x1f
> > -#define MII_KSZPHY_CTRL MII_KSZPHY_CTRL_2
> > +#define MII_KSZPHY_CTRL_2 0x1f
> > +#define MII_KSZPHY_CTRL MII_KSZPHY_CTRL_2
> > /* bitmap of PHY register to set interrupt mode */
> > #define KSZPHY_CTRL_INT_ACTIVE_HIGH BIT(9)
> > #define KSZPHY_RMII_REF_CLK_SEL BIT(7)
> > --
> > 2.29.2
> >
>
> And the last column of these macros at the end is aligned with spaces
> unlike everything else:
>
> /* Write/read to/from extended registers */
> #define MII_KSZPHY_EXTREG 0x0b
> #define KSZPHY_EXTREG_WRITE 0x8000
>
> #define MII_KSZPHY_EXTREG_WRITE 0x0c
> #define MII_KSZPHY_EXTREG_READ 0x0d
>
> /* Extended registers */
> #define MII_KSZPHY_CLK_CONTROL_PAD_SKEW 0x104
> #define MII_KSZPHY_RX_DATA_PAD_SKEW 0x105
> #define MII_KSZPHY_TX_DATA_PAD_SKEW 0x106
>
> I guess if you're going to send this patch you might as well refactor it all.
Ok, done.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-06-10 10:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 4:30 [PATCH net-next v3 0/9] provide cable test support for the ksz886x switch Oleksij Rempel
2021-05-26 4:30 ` [PATCH net-next v3 1/9] net: phy: micrel: move phy reg offsets to common header Oleksij Rempel
2021-05-26 22:01 ` Vladimir Oltean
2021-05-27 15:16 ` Andrew Lunn
2021-05-26 4:30 ` [PATCH net-next v3 2/9] net: dsa: microchip: ksz8795: add phylink support Oleksij Rempel
2021-05-26 22:13 ` Vladimir Oltean
2021-06-10 10:20 ` Oleksij Rempel
2021-05-26 4:30 ` [PATCH net-next v3 3/9] net: phy: micrel: use consistent indention after define Oleksij Rempel
2021-05-26 22:24 ` Vladimir Oltean
2021-06-10 10:30 ` Oleksij Rempel [this message]
2021-05-26 4:30 ` [PATCH net-next v3 4/9] net: phy: micrel: apply resume errata workaround for ksz8873 and ksz8863 Oleksij Rempel
2021-05-26 22:43 ` Vladimir Oltean
2021-06-10 11:49 ` Oleksij Rempel
2021-06-10 13:04 ` Vladimir Oltean
2021-06-10 13:25 ` Oleksij Rempel
2021-06-10 18:18 ` Vladimir Oltean
2021-05-26 4:30 ` [PATCH net-next v3 5/9] net: phy/dsa micrel/ksz886x add MDI-X support Oleksij Rempel
2021-05-26 4:30 ` [PATCH net-next v3 6/9] net: phy: micrel: ksz8081 " Oleksij Rempel
2021-05-26 4:30 ` [PATCH net-next v3 7/9] net: dsa: microchip: ksz8795: add LINK_MD register support Oleksij Rempel
2021-05-26 4:30 ` [PATCH net-next v3 8/9] net: dsa: dsa_slave_phy_connect(): extend phy's flags with port specific phy flags Oleksij Rempel
2021-05-26 15:08 ` Russell King (Oracle)
2021-06-10 10:04 ` Oleksij Rempel
2021-05-26 4:30 ` [PATCH net-next v3 9/9] net: phy: micrel: ksz886x/ksz8081: add cabletest support Oleksij Rempel
2021-05-26 19:32 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610103003.n5jgeppvf4aod5hw@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.