From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH v2] bfd/elf32-or1k: fix building with gcc version < 5
Date: Wed, 9 Jun 2021 23:52:33 +0200 [thread overview]
Message-ID: <20210609215233.1611478-1-giulio.benetti@benettiengineering.com> (raw)
In-Reply-To: <YME2SzQdpj/AVz/2@antec>
Gcc version >= 5 has standard C mode not set to -std=gnu11, so if we use
an old compiler(i.e. gcc 4.9) build fails on:
```
elf32-or1k.c:2251:3: error: 'for' loop initial declarations are only allowed in
C99 or C11 mode
for (size_t i = 0; i < insn_count; i++)
^
```
So let's declare `size_t i` at the top of the function instead of inside
for loop.
bfd/ChangeLog:
* elf32-or1k.c (or1k_write_plt_entry): Move i declaration to top
of function.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
bfd/elf32-or1k.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/bfd/elf32-or1k.c b/bfd/elf32-or1k.c
index 4ae7f324d33..32063ab0289 100644
--- a/bfd/elf32-or1k.c
+++ b/bfd/elf32-or1k.c
@@ -2244,9 +2244,10 @@ or1k_write_plt_entry (bfd *output_bfd, bfd_byte *contents, unsigned insnj,
{
unsigned nodelay = elf_elfheader (output_bfd)->e_flags & EF_OR1K_NODELAY;
unsigned output_insns[PLT_MAX_INSN_COUNT];
+ size_t i;
/* Copy instructions into the output buffer. */
- for (size_t i = 0; i < insn_count; i++)
+ for (i = 0; i < insn_count; i++)
output_insns[i] = insns[i];
/* Honor the no-delay-slot setting. */
@@ -2277,7 +2278,7 @@ or1k_write_plt_entry (bfd *output_bfd, bfd_byte *contents, unsigned insnj,
}
/* Write out the output buffer. */
- for (size_t i = 0; i < (insn_count+1); i++)
+ for (i = 0; i < (insn_count+1); i++)
bfd_put_32 (output_bfd, output_insns[i], contents + (i*4));
}
--
2.25.1
next prev parent reply other threads:[~2021-06-09 21:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 15:30 [OpenRISC] [PATCH] bfd/elf32-or1k: fix building with gcc version < 5 Giulio Benetti
2021-06-09 21:44 ` Stafford Horne
2021-06-09 21:52 ` Giulio Benetti [this message]
2021-06-10 1:19 ` [OpenRISC] [PATCH v2] " Alan Modra
2021-06-10 9:07 ` Giulio Benetti
2021-06-10 13:06 ` Alan Modra
2021-06-10 14:48 ` Giulio Benetti
2021-06-10 19:23 ` Stafford Horne
2021-06-10 21:37 ` Giulio Benetti
2021-06-09 21:53 ` [OpenRISC] [PATCH] " Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609215233.1611478-1-giulio.benetti@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.