* [LTP] [PATCH] fix pan/ltp-pan return values
2021-06-08 8:44 [LTP] [PATCH] fix pan/ltp-pan return values dongshijiang
@ 2021-06-08 8:24 ` Cyril Hrubis
0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2021-06-08 8:24 UTC (permalink / raw
To: ltp
Hi!
Can we please stop adding band aids over the broken-by-design runltp
script and ltp-pan?
We are going to finally push runltp-ng into LTP git during this
development cycle and finally deprecate ltp-pan, feel free to try it
yourself:
https://github.com/metan-ucw/runltp-ng
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 2+ messages in thread
* [LTP] [PATCH] fix pan/ltp-pan return values
@ 2021-06-08 8:44 dongshijiang
2021-06-08 8:24 ` Cyril Hrubis
0 siblings, 1 reply; 2+ messages in thread
From: dongshijiang @ 2021-06-08 8:44 UTC (permalink / raw
To: ltp
When performing an LTP test, if there are only "PASS" and "TCONF" in the test results, but "runltp" displays "INFO: ltp-pan reported all tests PASS", I think it should give something like "INFO: ltp-pan reported some "tests FAIL or TCONF" prompt.
Signed-off-by: dongshijiang <dongshijiang@inspur.com>
---
pan/ltp-pan.c | 2 +-
runltp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/pan/ltp-pan.c b/pan/ltp-pan.c
index 298072fe0..05690f7c9 100644
--- a/pan/ltp-pan.c
+++ b/pan/ltp-pan.c
@@ -770,7 +770,7 @@ check_pids(struct tag_pgrp *running, int *num_active, int keep_active,
"child %d exited with status %d\n",
cpid, w);
--*num_active;
- if (w != 0 && w != TCONF)
+ if (w != 0)
ret++;
} else if (WIFSTOPPED(stat_loc)) { /* should never happen */
w = WSTOPSIG(stat_loc);
diff --git a/runltp b/runltp
index 4447da156..539e7800d 100755
--- a/runltp
+++ b/runltp
@@ -811,7 +811,7 @@ EOF
VALUE=0
export LTP_EXIT_VALUE=0;
else
- echo "INFO: ltp-pan reported some tests FAIL"
+ echo "INFO: ltp-pan reported some tests FAIL or TCONF"
VALUE=1
export LTP_EXIT_VALUE=1;
fi
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-08 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-08 8:44 [LTP] [PATCH] fix pan/ltp-pan return values dongshijiang
2021-06-08 8:24 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.