From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62058C47083 for ; Fri, 4 Jun 2021 11:05:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 489656141C for ; Fri, 4 Jun 2021 11:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230055AbhFDLHW (ORCPT ); Fri, 4 Jun 2021 07:07:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:50522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbhFDLHU (ORCPT ); Fri, 4 Jun 2021 07:07:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 23FD861159; Fri, 4 Jun 2021 11:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622804734; bh=F6qdZyzEiXprcFunaXrWBdEWvmBNTkX5sFnDNIAVD0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xo760dFfoA6jHGH4cw6Kt7dVLtRAxU+GtKkqVqk+C0OnZu3tXlLwUkixPeVaZyi4A K4zM2+iCl8dDTdB+ZDY8PGDD7yE491gP1glhtCdmKtimxTQqWIOoO+E1eUjcy4/PmR QTh8+IufqjF8El+xZJqXV88SkNMLzNeUlJWqWed2Ojj7gYHRx++R3mM5a4LAFdAjuB H7u9QLxkesGz+WGybxUwbQG2v7uGUiP6zVtM2YsnM6j5Py9BboKXP229KNN8fgVeCG FRmZFipqlKpPHutqnc+Wzx9jUDXkb8LK5rPQVggALSfSyoFoBd7mfTvB8fFj0fPxYp 97TqtUP4rzn/g== Date: Fri, 4 Jun 2021 12:05:27 +0100 From: Will Deacon To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , Dietmar Eggemann , Daniel Bristot de Oliveira , Valentin Schneider , kernel-team@android.com Subject: Re: [PATCH v8 02/19] arm64: Allow mismatched 32-bit EL0 support Message-ID: <20210604110526.GF2318@willie-the-truck> References: <20210602164719.31777-1-will@kernel.org> <20210602164719.31777-3-will@kernel.org> <20210603123715.GA48596@C02TD0UTHF1T.local> <20210603174413.GC1170@willie-the-truck> <20210604093808.GA64162@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604093808.GA64162@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 04, 2021 at 10:38:08AM +0100, Mark Rutland wrote: > On Thu, Jun 03, 2021 at 06:44:14PM +0100, Will Deacon wrote: > > On Thu, Jun 03, 2021 at 01:37:15PM +0100, Mark Rutland wrote: > > > On Wed, Jun 02, 2021 at 05:47:02PM +0100, Will Deacon wrote: > > > > diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h > > > > index 338840c00e8e..603bf4160cd6 100644 > > > > --- a/arch/arm64/include/asm/cpufeature.h > > > > +++ b/arch/arm64/include/asm/cpufeature.h > > > > @@ -630,9 +630,15 @@ static inline bool cpu_supports_mixed_endian_el0(void) > > > > return id_aa64mmfr0_mixed_endian_el0(read_cpuid(ID_AA64MMFR0_EL1)); > > > > } > > > > > > > > +const struct cpumask *system_32bit_el0_cpumask(void); > > > > +DECLARE_STATIC_KEY_FALSE(arm64_mismatched_32bit_el0); > > > > + > > > > static inline bool system_supports_32bit_el0(void) > > > > { > > > > - return cpus_have_const_cap(ARM64_HAS_32BIT_EL0); > > > > + u64 pfr0 = read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1); > > > > + > > > > + return static_branch_unlikely(&arm64_mismatched_32bit_el0) || > > > > + id_aa64pfr0_32bit_el0(pfr0); > > > > } > > > > > > Note that read_sanitised_ftr_reg() has to do a bsearch() to find the > > > arm64_ftr_reg, so this will make system_32bit_el0_cpumask() a fair > > > amount more expensive than it needs to be. > > > > I seriously doubt that it matters, but it did come up before and I proposed > > a potential solution if it's actually a concern: > > > > https://lore.kernel.org/r/20201202172727.GC29813@willie-the-truck > > > > so if you can show that it's a problem, we can resurrect something like > > that. > > I'm happy to leave that for future. I raised this because elsewhere this > is an issue when we need to avoid instrumentation; if that's not a > concern here on any path then I am not aware of a functional issue. I can't think of a reason why instrumentation would be an issue for any of the current callers, but that's a good point to bear in mind. > > > That said. I reckon this could be much cleaner if we maintained separate > > > caps: > > > > > > ARM64_ALL_CPUS_HAVE_32BIT_EL0 > > > ARM64_SOME_CPUS_HAVE_32BIT_EL0 > > > > > > ... and allow arm64_mismatched_32bit_el0 to be set dependent on > > > ARM64_SOME_CPUS_HAVE_32BIT_EL0. With that, this can be simplified to: > > > > > > static inline bool system_supports_32bit_el0(void) > > > { > > > return (cpus_have_const_cap(ARM64_ALL_CPUS_HAVE_32BIT_EL0)) || > > > static_branch_unlikely(&arm64_mismatched_32bit_el0)) > > > > Something similar was discussed in November last year but this falls > > apart with late onlining because its not generally possible to tell whether > > you've seen all the CPUs or not. > > Ah; is that for when your boot CPU set is all AArch32-capable, but a > late-onlined CPU is not? > > I assume that we require at least one of the set of boot CPUs to be > AArch32 cpable, and don't settle the compat hwcaps after userspace has > started. Heh, you assume wrong :) When we allow the mismatch, then we do actually defer initialisation of the compat hwcaps until we see a 32-bit CPU. That's fine, as they won't be visible to userspace until then anyway (PER_LINUX32 is unavailable). Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 425C6C07E94 for ; Fri, 4 Jun 2021 11:20:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 150946136E for ; Fri, 4 Jun 2021 11:20:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 150946136E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pLXhfawHmdr8dOkalBQTQ2uu/J/s/e6tGgawoyGqaUk=; b=tSO6FgNCQXPTmu huPAIRHSMfq9JxYdqm2UT6HzD5rEwfboujmCt/N6+VMkFL31H/0Iqbw0ItsY07UlZeutTH7fZLq4S YHBYsQ+lQ4k/r6RntAsRkRGELqFJomkJgXvAVKz84BFFKT3EeJU89Qlt7P0ouzwcldRp48bBpXRG3 pAoqArR82GbxFkZJTNIwQv8n5pBoACKaCAe3kk0SEE3dP5A7Kyl+/IAxYLi+7R/NV0/Iyr4GqU9VK BZkD6Jtc2dOw+SLLNSNycE795hbKVP89QZL4dqCAvc73Uw/yl4ucOz+PyAmEHnhoy8YCkP0wKwOPR rbM7UQDwFuyOiYqMEP0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp7oT-00DDsi-T0; Fri, 04 Jun 2021 11:16:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp7du-00D913-W4 for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 11:05:39 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 23FD861159; Fri, 4 Jun 2021 11:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622804734; bh=F6qdZyzEiXprcFunaXrWBdEWvmBNTkX5sFnDNIAVD0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xo760dFfoA6jHGH4cw6Kt7dVLtRAxU+GtKkqVqk+C0OnZu3tXlLwUkixPeVaZyi4A K4zM2+iCl8dDTdB+ZDY8PGDD7yE491gP1glhtCdmKtimxTQqWIOoO+E1eUjcy4/PmR QTh8+IufqjF8El+xZJqXV88SkNMLzNeUlJWqWed2Ojj7gYHRx++R3mM5a4LAFdAjuB H7u9QLxkesGz+WGybxUwbQG2v7uGUiP6zVtM2YsnM6j5Py9BboKXP229KNN8fgVeCG FRmZFipqlKpPHutqnc+Wzx9jUDXkb8LK5rPQVggALSfSyoFoBd7mfTvB8fFj0fPxYp 97TqtUP4rzn/g== Date: Fri, 4 Jun 2021 12:05:27 +0100 From: Will Deacon To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , Dietmar Eggemann , Daniel Bristot de Oliveira , Valentin Schneider , kernel-team@android.com Subject: Re: [PATCH v8 02/19] arm64: Allow mismatched 32-bit EL0 support Message-ID: <20210604110526.GF2318@willie-the-truck> References: <20210602164719.31777-1-will@kernel.org> <20210602164719.31777-3-will@kernel.org> <20210603123715.GA48596@C02TD0UTHF1T.local> <20210603174413.GC1170@willie-the-truck> <20210604093808.GA64162@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210604093808.GA64162@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210604_040535_101752_9F63C3EF X-CRM114-Status: GOOD ( 32.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 04, 2021 at 10:38:08AM +0100, Mark Rutland wrote: > On Thu, Jun 03, 2021 at 06:44:14PM +0100, Will Deacon wrote: > > On Thu, Jun 03, 2021 at 01:37:15PM +0100, Mark Rutland wrote: > > > On Wed, Jun 02, 2021 at 05:47:02PM +0100, Will Deacon wrote: > > > > diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h > > > > index 338840c00e8e..603bf4160cd6 100644 > > > > --- a/arch/arm64/include/asm/cpufeature.h > > > > +++ b/arch/arm64/include/asm/cpufeature.h > > > > @@ -630,9 +630,15 @@ static inline bool cpu_supports_mixed_endian_el0(void) > > > > return id_aa64mmfr0_mixed_endian_el0(read_cpuid(ID_AA64MMFR0_EL1)); > > > > } > > > > > > > > +const struct cpumask *system_32bit_el0_cpumask(void); > > > > +DECLARE_STATIC_KEY_FALSE(arm64_mismatched_32bit_el0); > > > > + > > > > static inline bool system_supports_32bit_el0(void) > > > > { > > > > - return cpus_have_const_cap(ARM64_HAS_32BIT_EL0); > > > > + u64 pfr0 = read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1); > > > > + > > > > + return static_branch_unlikely(&arm64_mismatched_32bit_el0) || > > > > + id_aa64pfr0_32bit_el0(pfr0); > > > > } > > > > > > Note that read_sanitised_ftr_reg() has to do a bsearch() to find the > > > arm64_ftr_reg, so this will make system_32bit_el0_cpumask() a fair > > > amount more expensive than it needs to be. > > > > I seriously doubt that it matters, but it did come up before and I proposed > > a potential solution if it's actually a concern: > > > > https://lore.kernel.org/r/20201202172727.GC29813@willie-the-truck > > > > so if you can show that it's a problem, we can resurrect something like > > that. > > I'm happy to leave that for future. I raised this because elsewhere this > is an issue when we need to avoid instrumentation; if that's not a > concern here on any path then I am not aware of a functional issue. I can't think of a reason why instrumentation would be an issue for any of the current callers, but that's a good point to bear in mind. > > > That said. I reckon this could be much cleaner if we maintained separate > > > caps: > > > > > > ARM64_ALL_CPUS_HAVE_32BIT_EL0 > > > ARM64_SOME_CPUS_HAVE_32BIT_EL0 > > > > > > ... and allow arm64_mismatched_32bit_el0 to be set dependent on > > > ARM64_SOME_CPUS_HAVE_32BIT_EL0. With that, this can be simplified to: > > > > > > static inline bool system_supports_32bit_el0(void) > > > { > > > return (cpus_have_const_cap(ARM64_ALL_CPUS_HAVE_32BIT_EL0)) || > > > static_branch_unlikely(&arm64_mismatched_32bit_el0)) > > > > Something similar was discussed in November last year but this falls > > apart with late onlining because its not generally possible to tell whether > > you've seen all the CPUs or not. > > Ah; is that for when your boot CPU set is all AArch32-capable, but a > late-onlined CPU is not? > > I assume that we require at least one of the set of boot CPUs to be > AArch32 cpable, and don't settle the compat hwcaps after userspace has > started. Heh, you assume wrong :) When we allow the mismatch, then we do actually defer initialisation of the compat hwcaps until we see a 32-bit CPU. That's fine, as they won't be visible to userspace until then anyway (PER_LINUX32 is unavailable). Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel