From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C696AC47097 for ; Thu, 3 Jun 2021 21:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A14196120F for ; Thu, 3 Jun 2021 21:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbhFCVav (ORCPT ); Thu, 3 Jun 2021 17:30:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:50886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbhFCVau (ORCPT ); Thu, 3 Jun 2021 17:30:50 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33EFB613F9; Thu, 3 Jun 2021 21:29:04 +0000 (UTC) Date: Thu, 3 Jun 2021 17:29:02 -0400 From: Steven Rostedt To: Daniel Bristot de Oliveira Cc: linux-kernel@vger.kernel.org, Phil Auld , Sebastian Andrzej Siewior , Kate Carcia , Jonathan Corbet , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Alexandre Chartre , Clark Willaims , John Kacur , Juri Lelli , linux-doc@vger.kernel.org Subject: Re: [PATCH V3 7/9] tracing: Add __print_ns_to_secs() and __print_ns_without_secs() helpers Message-ID: <20210603172902.41648183@gandalf.local.home> In-Reply-To: <2c59beee3b36b15592bfbb9f26dee7f8b55fd814.1621024265.git.bristot@redhat.com> References: <2c59beee3b36b15592bfbb9f26dee7f8b55fd814.1621024265.git.bristot@redhat.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 May 2021 22:51:16 +0200 Daniel Bristot de Oliveira wrote: > +++ b/include/trace/trace_events.h > @@ -358,6 +358,21 @@ TRACE_MAKE_SYSTEM_STR(); > trace_print_hex_dump_seq(p, prefix_str, prefix_type, \ > rowsize, groupsize, buf, len, ascii) > > +#undef __print_ns_to_secs > +#define __print_ns_to_secs(value) \ > + ({ \ > + u64 ____val = (u64)value; \ > + do_div(____val, NSEC_PER_SEC); \ > + ____val; \ > + }) I know my name is on this, but we need parenthesis around "value". > + > +#undef __print_ns_without_secs > +#define __print_ns_without_secs(value) \ > + ({ \ > + u64 ____val = (u64)value; \ Here too. > + (u32) do_div(____val, NSEC_PER_SEC); \ > + }) > + > #undef DECLARE_EVENT_CLASS > #define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print) \ > static notrace enum print_line_t \ > @@ -736,6 +751,16 @@ static inline void ftrace_test_probe_##call(void) \ > #undef __print_array > #undef __print_hex_dump > > +/* > + * The below is not executed in the kernel. It is only what is > + * displayed in the print format for userspace to parse. > + */ > +#undef __print_ns_to_secs > +#define __print_ns_to_secs(val) val / 1000000000UL > + > +#undef __print_ns_without_secs > +#define __print_ns_without_secs(val) val % 1000000000UL And around "val" in the above two macros. -- Steve > + > #undef TP_printk > #define TP_printk(fmt, args...) "\"" fmt "\", " __stringify(args) >