From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4109C47083 for ; Wed, 2 Jun 2021 06:26:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90A5961242 for ; Wed, 2 Jun 2021 06:26:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90A5961242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5177082EBA; Wed, 2 Jun 2021 08:26:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="BRsZUKI5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D956F82EBA; Wed, 2 Jun 2021 08:26:36 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on061f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::61f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6D74082EBA for ; Wed, 2 Jun 2021 08:26:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=zhiqiang.hou@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VV6lvUxs5uDdPkmD5PeLkrNy7YcMB1M+hPvKp2LltCgdOrlDT4y0er94Uca4bWMCcN+4f2/j4DsYwo5LyeRetQqYrtF7HQSlx6EgqllAQ4V+Q03XAcHHf0h0DWP2/tBRcOSuQKj0fXoPFDAsNC4c3ntnrzL4zXWztsaR+9iMVoIyAqffmhEzxAtT2pTO6/5ax9VF8J4MXLm3JvD5365fXRvMbBoemz7Xii2lbuQh0LR1wr/ndgsoPOZ3GU6rY0aurVtTbcyi31JAdE9OiHA6r4kx1hqL1EnDajROGdD2i9SgwSeKH9ZBpaPY6dd7ak6NyXsJbRVFdf+q4cF4DxkGjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s9GlhX8Xg0X/QakZkBoPrAFgLAr4DYOVx7aYufioMqU=; b=kJzXLhbh5BS/mCpYKp3ez5xRToU2aMfahOgp3BKd3FSmHnNXP2qycTPoRAbAiTMIED1kDNai8fdXLl+oXLAZbKkRVqY8zmvHGaWQtXw9g9CnkaO0sL1YkB4m2B5WrLkVAbnl295vT0hRYn3mh7kRodQgG+XZ77+4FJ0lAg3KP6QO6FdFFl76yXVhQCP61yT50XdfvTDo64Jk2LJxjmr3doWzGCmvaDTazRR/p966w2wpfrhkdzV9Jt+tuIDaTDkkHXyNIPaoXbfKCWVqPFl9KF/T10OAYdOSSe+LIvc3G69WHs5j7D+fmebqOSG/kaIRw7aqDmb8Li1Dok4PEjRdSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s9GlhX8Xg0X/QakZkBoPrAFgLAr4DYOVx7aYufioMqU=; b=BRsZUKI5sg0qgH8TnoJ/MHzfsxUn2BlktErPe65b4zHwVJWeSb2dcNcGuTSUFZCg4UM0eP8Jwlvg7LCVDlV/EaDQN/U0JrbYeKBB1mSrcRp91fiD5mzQNX5HkTrmrlghwOxQChC9T43SXjHfPhYEG//tDokRtQPMHwMYvWnDZ0g= Authentication-Results: ni.com; dkim=none (message not signed) header.d=none;ni.com; dmarc=none action=none header.from=nxp.com; Received: from HE1PR0402MB3371.eurprd04.prod.outlook.com (2603:10a6:7:85::27) by HE1PR0401MB2380.eurprd04.prod.outlook.com (2603:10a6:3:25::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.22; Wed, 2 Jun 2021 06:26:32 +0000 Received: from HE1PR0402MB3371.eurprd04.prod.outlook.com ([fe80::3c4c:2dd2:3b01:34b0]) by HE1PR0402MB3371.eurprd04.prod.outlook.com ([fe80::3c4c:2dd2:3b01:34b0%7]) with mapi id 15.20.4173.030; Wed, 2 Jun 2021 06:26:32 +0000 From: Zhiqiang Hou To: joe.hershberger@ni.com, rfried.dev@gmail.com, priyanka.jain@nxp.com, u-boot@lists.denx.de Cc: Hou Zhiqiang Subject: [PATCH] net: fm: Fix a memory leak issue Date: Wed, 2 Jun 2021 14:35:54 +0800 Message-Id: <20210602063554.25281-1-Zhiqiang.Hou@nxp.com> X-Mailer: git-send-email 2.17.1 Content-Type: text/plain X-Originating-IP: [119.31.174.73] X-ClientProxiedBy: SG2P153CA0005.APCP153.PROD.OUTLOOK.COM (2603:1096::15) To HE1PR0402MB3371.eurprd04.prod.outlook.com (2603:10a6:7:85::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (119.31.174.73) by SG2P153CA0005.APCP153.PROD.OUTLOOK.COM (2603:1096::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.3 via Frontend Transport; Wed, 2 Jun 2021 06:26:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc442840-dc3b-4e9e-cc14-08d9258f5c7a X-MS-TrafficTypeDiagnostic: HE1PR0401MB2380: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aAokNiPR/pS0fWQ11RtlX9WS3dMjUN9g6EHMaCwVsHSjKUwQTSPVDayvvSBWqvYUCpVLmACSY8GTISJiW1VGzCmLlnDPZoMsm4bhCFdMAIiF0m0riq7tzGkv/XI1PpfwDPklYozsSeENx/Gvc7XnGgIo0SZcrqQouWymbz8s6LomZbwTmCHoabh7vT4Megs81hm1kG/YbWGOA7uvlqqgehWjYrWecdNspGBNUrgwVPqUy5jJIiREOmm1f5tX4sXvx4tMsSOCM1Wf+xniKA3kvXhGYrspH6BTOdcSoNHvL6BFuDA48v1fHVIsYVKdSAx+CYfgNErljc8dPvwM7lEbhSgojYkOWSNMqnCZGi832RUKn470t5jrt4Cm07bV/AmXQ4xL5WyHKsFEK6owORQZM5vXAI+zIEqpLS1We7HFR6twcaUSOoqh3VzjXjoU/pNDlwKSTfSsm1E1HDq8oc8ufITc2p57GxK4BuW4QHI+7ELHOS5zqy9ynTbS16Ue2EzohYTw68kpncRQZwzP6z6UwvCwSQ9iRVzaeUsCnGsAdCVuRXj/jdHygxjSEhTmO7rzlc4MrPBxM2NxpzVEIw7PytCtrOhFQ9wdfSp1IBUAzVkYOJLhqYx+IOJAFNKk4QDSqSKnvualX9jNg7/6VA5cZKwIBRKEhOVbIkI4zIr82hvUGeju5z48j9nF8Z8OvvuC X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR0402MB3371.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(366004)(396003)(136003)(346002)(6486002)(6666004)(5660300002)(8676002)(2616005)(956004)(4326008)(4744005)(8936002)(38100700002)(1076003)(38350700002)(66946007)(66476007)(86362001)(66556008)(478600001)(316002)(83380400001)(26005)(2906002)(6506007)(52116002)(6512007)(186003)(16526019)(36756003)(69590400013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?7l3jZCqJwAaq9txEGRIeTKQBwLjLsKXF8RtA0f/ey6WwzsgbX+FfRKowg5a9?= =?us-ascii?Q?KlMTArJdJiv7n2gJ+CSIv4mxOgJh9SojOD5MHjRABZY3/T7F7B201PtsuIRz?= =?us-ascii?Q?E8JjspRfT3Wmbs6pYAJKfq/RcIiCY8Iyb4lcJ9e0f+FJlnkOl8WCWTrDSJ+c?= =?us-ascii?Q?XhGq1FUodBbH3lHbDE8Xze+weQJ8leIOzPGAUx8Kzbd7SQLETALsUw73HXNA?= =?us-ascii?Q?sljUETJveZ+64M3NADnBRiz9tBOPbssad1J3FXLaAaOLa61xQUCDfJKyLMtj?= =?us-ascii?Q?dCPlB3i+TsCkoKEvNLWprXMi0DYuhA957cXFzYE+2ttFPD5jkOr/50CWB5kR?= =?us-ascii?Q?vZLmztV2CTrCwao/ZWPWkv7QOJPBV0EvimIwEB7PwAq7EVsfOIUBFQ8aqUie?= =?us-ascii?Q?neKbakmWj8BBHCFlXpu2MCa9Jyc/oqSV2/AdCiVzgvUdisTY5sxkJ56yfBaf?= =?us-ascii?Q?URnMtPq7GaF7sRYU/rlFnKFXsdhVolDNkIy8GGLoiXZsjFVunH5Qx8FfHIZX?= =?us-ascii?Q?eZBp5NFFA7qrXC8PukQ6nRyzdmHFdK01r/Fb4FUuVL1plDWaaVSpQTPtv2qA?= =?us-ascii?Q?URYwQN3jYRXqM/ppUoYB126sBK4GBpuTCCd54gUXmqzHFTdfuS6IH5JlqAlK?= =?us-ascii?Q?KffVmt0g/xa9aOsnV3C6EqwKVKK57rF1RN1ljFgvFd4s8bdjvNwYyId/pwk0?= =?us-ascii?Q?7cJ23i2da3Jqomd6DWESQnFTTV4zjVUJUQzNF7iAGbopXnl3e6H3h95LJg0V?= =?us-ascii?Q?Mgo+YhAqxmIPDdLLnWIoUUpCVQlOIhmWOVncXH8bFA9WBsxRvO6RiAIOkmHF?= =?us-ascii?Q?2XMEJ9sduELKfuBWcZ9p+zjP91tjwxr87ULc26nI9Vkh7TkVisVn7vHVDPJa?= =?us-ascii?Q?Xaz5/sNgW7e2pvdLNq1POvyymBr008X4E16xMY9VDOY+ab/L7T5BzK8oZ0BF?= =?us-ascii?Q?STx6WsRqNU+dfVt7pHWvXAM3m/khAK2VDosQCzQRHZ3mNZCwQtfN4G74XFhB?= =?us-ascii?Q?iC7t6FMTPezGkswtTDoyy83onNWJpXEnPnZiHPC1FfSO580CGCbNIiLv6Ldw?= =?us-ascii?Q?6HPjBilEgle5O/kUxU+o9DP1YyHOWZX4FZlonHs1WoYwaCVt9nU90oambOyO?= =?us-ascii?Q?n+LPHZE1DmvqsJ16+xerovvE9+Cjr9JWn1ocqPhsyFaPlnr6cE3C2RS+mBtD?= =?us-ascii?Q?Deko08uPkE8w+g0SxzJtYPV15Wo9nYmUk/9RsO+JVFa4+tcn0By/FCj6pbTz?= =?us-ascii?Q?RGX7DG6+aNk0f5wnoKIuD1TZNi0feFuZzPVyiymBb1E28s+daKWVljK7UEUt?= =?us-ascii?Q?YtsEZfe9Nd6eQf+hhJzDnELe?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc442840-dc3b-4e9e-cc14-08d9258f5c7a X-MS-Exchange-CrossTenant-AuthSource: HE1PR0402MB3371.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2021 06:26:32.0631 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RK6rxpDK1DU6UvE7gY3BaOdE7X1Fl09Z+Ko2r3fLhltZ1uWqd2sWF0/RAAcSaNgqtVIfGSCAkNRfB6ZG2OIr0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2380 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean From: Hou Zhiqiang Fix a memory leak issue in the RX port initialization. Signed-off-by: Hou Zhiqiang --- drivers/net/fm/eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/fm/eth.c b/drivers/net/fm/eth.c index 0e89e663f7..7c23ccc1f0 100644 --- a/drivers/net/fm/eth.c +++ b/drivers/net/fm/eth.c @@ -288,8 +288,10 @@ static int fm_eth_rx_port_parameter_init(struct fm_eth *fm_eth) /* alloc Rx buffer from main memory */ rx_buf_pool = malloc(MAX_RXBUF_LEN * RX_BD_RING_SIZE); - if (!rx_buf_pool) + if (!rx_buf_pool) { + free(rx_bd_ring_base); return -ENOMEM; + } memset(rx_buf_pool, 0, MAX_RXBUF_LEN * RX_BD_RING_SIZE); debug("%s: rx_buf_pool = %p\n", __func__, rx_buf_pool); -- 2.17.1