* [PATCH] test: Remove duplicate macro
@ 2021-05-23 17:00 Sean Anderson
2021-05-23 20:57 ` Heinrich Schuchardt
2021-05-27 11:42 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Sean Anderson @ 2021-05-23 17:00 UTC (permalink / raw
To: u-boot, Tom Rini; +Cc: Simon Glass, Heinrich Schuchardt, Sean Anderson
ut_asserteq_strn is defined twice. Remove one definition.
Fixes: 33d7edfd5f ("test: Add a way to check part of a console line or skip it")
Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
include/test/ut.h | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/include/test/ut.h b/include/test/ut.h
index fbbba286ee..656e25fe57 100644
--- a/include/test/ut.h
+++ b/include/test/ut.h
@@ -177,23 +177,6 @@ int ut_check_console_dump(struct unit_test_state *uts, int total_bytes);
} \
}
-/*
- * Assert that two string expressions are equal, up to length of the
- * first
- */
-#define ut_asserteq_strn(expr1, expr2) { \
- const char *_val1 = (expr1), *_val2 = (expr2); \
- int _len = strlen(_val1); \
- \
- if (memcmp(_val1, _val2, _len)) { \
- ut_failf(uts, __FILE__, __LINE__, __func__, \
- #expr1 " = " #expr2, \
- "Expected \"%.*s\", got \"%.*s\"", \
- _len, _val1, _len, _val2); \
- return CMD_RET_FAILURE; \
- } \
-}
-
/* Assert that two memory areas are equal */
#define ut_asserteq_mem(expr1, expr2, len) { \
const u8 *_val1 = (u8 *)(expr1), *_val2 = (u8 *)(expr2); \
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] test: Remove duplicate macro
2021-05-23 17:00 [PATCH] test: Remove duplicate macro Sean Anderson
@ 2021-05-23 20:57 ` Heinrich Schuchardt
2021-05-27 11:42 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-05-23 20:57 UTC (permalink / raw
To: Sean Anderson, u-boot, Tom Rini; +Cc: Simon Glass
On 5/23/21 7:00 PM, Sean Anderson wrote:
> ut_asserteq_strn is defined twice. Remove one definition.
>
> Fixes: 33d7edfd5f ("test: Add a way to check part of a console line or skip it")
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test: Remove duplicate macro
2021-05-23 17:00 [PATCH] test: Remove duplicate macro Sean Anderson
2021-05-23 20:57 ` Heinrich Schuchardt
@ 2021-05-27 11:42 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-05-27 11:42 UTC (permalink / raw
To: Sean Anderson; +Cc: u-boot, Simon Glass, Heinrich Schuchardt
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
On Sun, May 23, 2021 at 01:00:56PM -0400, Sean Anderson wrote:
> ut_asserteq_strn is defined twice. Remove one definition.
>
> Fixes: 33d7edfd5f ("test: Add a way to check part of a console line or skip it")
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-27 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-23 17:00 [PATCH] test: Remove duplicate macro Sean Anderson
2021-05-23 20:57 ` Heinrich Schuchardt
2021-05-27 11:42 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.