All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] io_uring_enter(2): clarify OP_READ and OP_WRITE
@ 2021-05-23 16:44 Drew DeVault
  2021-05-27 19:05 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Drew DeVault @ 2021-05-23 16:44 UTC (permalink / raw
  To: io-uring; +Cc: Drew DeVault, Jens Axboe, Pavel Begunkov

These do not advance the internal file offset unless the offset is set
to -1, making them behave more like pread/pwrite than read/write.
---
 man/io_uring_enter.2 | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/man/io_uring_enter.2 b/man/io_uring_enter.2
index f898ffd..5b498e5 100644
--- a/man/io_uring_enter.2
+++ b/man/io_uring_enter.2
@@ -576,16 +576,24 @@ for the general description of the related system call. Available since 5.6.
 .TP
 .B IORING_OP_WRITE
 Issue the equivalent of a
-.BR read(2)
+.BR pread(2)
 or
-.BR write(2)
+.BR pwrite(2)
 system call.
 .I fd
 is the file descriptor to be operated on,
 .I addr
-contains the buffer in question, and
+contains the buffer in question,
 .I len
-contains the length of the IO operation. These are non-vectored versions of the
+contains the length of the IO operation, and
+.I offs
+contains the read or write offset. If
+.I offs
+is set to -1, the offset will use (and advance) the file position, like the
+.BR read(2)
+and
+.BR write(2)
+system calls. These are non-vectored versions of the
 .B IORING_OP_READV
 and
 .B IORING_OP_WRITEV
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] io_uring_enter(2): clarify OP_READ and OP_WRITE
  2021-05-23 16:44 [PATCH v2] io_uring_enter(2): clarify OP_READ and OP_WRITE Drew DeVault
@ 2021-05-27 19:05 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-05-27 19:05 UTC (permalink / raw
  To: Drew DeVault, io-uring; +Cc: Pavel Begunkov

On 5/23/21 10:44 AM, Drew DeVault wrote:
> These do not advance the internal file offset unless the offset is set
> to -1, making them behave more like pread/pwrite than read/write.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-27 19:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-23 16:44 [PATCH v2] io_uring_enter(2): clarify OP_READ and OP_WRITE Drew DeVault
2021-05-27 19:05 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.