From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B7FC433E2 for ; Fri, 26 Mar 2021 09:59:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E20F5601FB for ; Fri, 26 Mar 2021 09:59:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbhCZJ6y (ORCPT ); Fri, 26 Mar 2021 05:58:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229868AbhCZJ6q (ORCPT ); Fri, 26 Mar 2021 05:58:46 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C578C0613B1 for ; Fri, 26 Mar 2021 02:58:45 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id k10so7562368ejg.0 for ; Fri, 26 Mar 2021 02:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tjQTtHVhiMLOKDkirjBwOrBbAr7RuF9oo6N4dkwJrD4=; b=DoTEkH3mGM3eg1OgpTZxL88d2VqbLDGm35xDcOrUh9iR/7hIdtgDEJu3oCMOOQIAMr xgDaplhpXpI1b7w7XjdFqomJddjMLyAUHY2LhFtUqZ7di3KhCcMOdcCEH3s9UnYNSLa7 Tb+S3h/QScQBpxpWuV8D2KSJQzv290mHAeKgk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tjQTtHVhiMLOKDkirjBwOrBbAr7RuF9oo6N4dkwJrD4=; b=dWqfUzCVT1A5fjYi6JFJ9vMJqRATSMo8PDgsP8vuCLXy109xf3DN0fnE8//8c4frHA cpFROUSxHWOOYi6let8uiilt/J9c/CyIPftRVpW1L2/ZPoItmp3PVhY088py11SYorRF 3UH0in14pn5FaGy3r+2WJGy+nItopW6hyXNrG3GbxLrOYtAIRjy0JX8Wm7qVMFFV1Nch 7PB5QWqctn9bhAUukOUW4HLOXY+2i9OL6ghr1zLU0y4T6wZuc4kdYLtTjvLDshiRxo3D Oom8M9T10yAQ4WJQw8cN+8ZQeAEGJFSobPK2BdhpWcGTD+SWAVwszKb0tmKIcVzlCsfC gz8Q== X-Gm-Message-State: AOAM533eOAqS1nDA8ff+sbfuP6mlR7XoEO+dHeKc8g0kuoNHDdvc1aDX 9Qb0ZUailk9Ux7lLgKdiRWmm7g== X-Google-Smtp-Source: ABdhPJyaW92TsvrmmUc4oFjWTuBqvsVQF5Y8E0bUgtqrY0WSWE0Z0kRtEsgvufFFzHKb7wi0MmluFA== X-Received: by 2002:a17:906:2404:: with SMTP id z4mr14016161eja.14.1616752723903; Fri, 26 Mar 2021 02:58:43 -0700 (PDT) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id h13sm4036658edz.71.2021.03.26.02.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 02:58:43 -0700 (PDT) From: Ricardo Ribalda To: Laurent Pinchart , Mauro Carvalho Chehab , Hans Verkuil , Sergey Senozhatsky , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, tfiga@chromium.org Cc: Ricardo Ribalda Subject: [PATCH v9 00/22] uvcvideo: Fix v4l2-compliance errors Date: Fri, 26 Mar 2021 10:58:18 +0100 Message-Id: <20210326095840.364424-1-ribalda@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org *v4l2-compliance -m /dev/media0 -a -f Total for uvcvideo device /dev/media0: 8, Succeeded: 6, Failed: 2, Warnings: 0 Total for uvcvideo device /dev/video0: 54, Succeeded: 50, Failed: 4, Warnings: 2 Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0 Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 102, Failed: 6, Warnings: 2 After fixing all of them we go down to: Total for uvcvideo device /dev/media0: 8, Succeeded: 8, Failed: 0, Warnings: 0 Total for uvcvideo device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0 Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0 Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 108, Failed: 0, Warnings: 0 YES, NO MORE WARNINGS :) Note that we depend on: https://patchwork.linuxtv.org/project/linux-media/patch/20210317143453.483470-1-ribalda@chromium.org/ With Hans patch we can also pass v4l2-compliance -s. Changelog from v8 (Thanks to Hans) - 3 patches from Hans - Add Reviewed-by Hans Verkuil (4): uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE uvcvideo: improve error handling in uvc_query_ctrl() uvcvideo: don't spam the log in uvc_ctrl_restore_values() uvc: use vb2 ioctl and fop helpers Ricardo Ribalda (18): media: v4l2-ioctl: Fix check_ext_ctrls media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL media: v4l2-ioctl: S_CTRL output the right value media: uvcvideo: Remove s_ctrl and g_ctrl media: uvcvideo: Set capability in s_param media: uvcvideo: Return -EIO for control errors media: uvcvideo: refactor __uvc_ctrl_add_mapping media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS media: uvcvideo: Use dev->name for querycap() media: uvcvideo: Set unique vdev name based in type media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE media: uvcvideo: Use control names from framework media: uvcvideo: Check controls flags before accessing them media: uvcvideo: Set error_idx during ctrl_commit errors media: uvcvideo: Return -EACCES to inactive controls media: docs: Document the behaviour of uvcdriver media: uvcvideo: Downgrade control error messages .../userspace-api/media/v4l/vidioc-g-ctrl.rst | 5 + .../media/v4l/vidioc-g-ext-ctrls.rst | 5 + drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 - drivers/media/usb/uvc/uvc_ctrl.c | 343 +++++++++++---- drivers/media/usb/uvc/uvc_driver.c | 22 +- drivers/media/usb/uvc/uvc_metadata.c | 10 +- drivers/media/usb/uvc/uvc_queue.c | 143 ------- drivers/media/usb/uvc/uvc_v4l2.c | 389 +++--------------- drivers/media/usb/uvc/uvc_video.c | 51 ++- drivers/media/usb/uvc/uvcvideo.h | 54 +-- drivers/media/v4l2-core/v4l2-ioctl.c | 67 +-- 11 files changed, 444 insertions(+), 649 deletions(-) -- 2.31.0.291.g576ba9dcdaf-goog