* [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses
@ 2021-01-28 12:33 Baruch Siach
2021-01-28 13:25 ` Matthew Weber
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Baruch Siach @ 2021-01-28 12:33 UTC (permalink / raw
To: buildroot
Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script
error") introduced closing parentheses that is not matched and not
needed.
Fixes:
http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/
Cc: Matt Weber <matthew.weber@rockwellcollins.com>
Cc: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/uboot-tools/uboot-tools.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
index f2bd627e927e..a0cdcafd4e7e 100644
--- a/package/uboot-tools/uboot-tools.mk
+++ b/package/uboot-tools/uboot-tools.mk
@@ -160,7 +160,7 @@ endif #BR_BUILDING
define HOST_UBOOT_TOOLS_GENERATE_BOOT_SCRIPT
$(@D)/tools/mkimage -C none -A $(MKIMAGE_ARCH) -T script \
-d $(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE)) \
- $(@D)/tools/boot.scr)
+ $(@D)/tools/boot.scr
endef
define HOST_UBOOT_TOOLS_INSTALL_BOOT_SCRIPT
$(INSTALL) -m 0755 -D $(@D)/tools/boot.scr $(BINARIES_DIR)/boot.scr
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses
2021-01-28 12:33 [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses Baruch Siach
@ 2021-01-28 13:25 ` Matthew Weber
2021-01-28 13:55 ` Thomas Petazzoni
2021-01-28 14:02 ` Bin Meng
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Matthew Weber @ 2021-01-28 13:25 UTC (permalink / raw
To: buildroot
Baruch,
On Thu, Jan 28, 2021 at 6:34 AM Baruch Siach <baruch@tkos.co.il> wrote:
>
> Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script
> error") introduced closing parentheses that is not matched and not
> needed.
>
> Fixes:
> http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
> http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/
>
Opps, I'll have to check with Kalpesh as we must have only tested the
env binary portion for v2 of the previous series. Thx for sending the
patch.
Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses
2021-01-28 13:25 ` Matthew Weber
@ 2021-01-28 13:55 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2021-01-28 13:55 UTC (permalink / raw
To: buildroot
On Thu, 28 Jan 2021 07:25:25 -0600
Matthew Weber via buildroot <buildroot@busybox.net> wrote:
> Opps, I'll have to check with Kalpesh as we must have only tested the
> env binary portion for v2 of the previous series. Thx for sending the
> patch.
>
> Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>
We need unit tests for this stuff! :-)
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses
2021-01-28 12:33 [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses Baruch Siach
2021-01-28 13:25 ` Matthew Weber
@ 2021-01-28 14:02 ` Bin Meng
2021-01-28 16:34 ` Yann E. MORIN
2021-01-28 20:18 ` Peter Korsgaard
3 siblings, 0 replies; 6+ messages in thread
From: Bin Meng @ 2021-01-28 14:02 UTC (permalink / raw
To: buildroot
On Thu, Jan 28, 2021 at 8:33 PM Baruch Siach <baruch@tkos.co.il> wrote:
>
> Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script
> error") introduced closing parentheses that is not matched and not
> needed.
>
> Fixes:
> http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
> http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/
>
> Cc: Matt Weber <matthew.weber@rockwellcollins.com>
> Cc: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/uboot-tools/uboot-tools.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
I was about to send exactly the same patch :)
Reviewed-by: Bin Meng <bin.meng@windriver.com>
Tested-by: Bin Meng <bin.meng@windriver.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses
2021-01-28 12:33 [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses Baruch Siach
2021-01-28 13:25 ` Matthew Weber
2021-01-28 14:02 ` Bin Meng
@ 2021-01-28 16:34 ` Yann E. MORIN
2021-01-28 20:18 ` Peter Korsgaard
3 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2021-01-28 16:34 UTC (permalink / raw
To: buildroot
Baruch, All,
On 2021-01-28 14:33 +0200, Baruch Siach spake thusly:
> Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script
> error") introduced closing parentheses that is not matched and not
> needed.
>
> Fixes:
> http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
> http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/
>
> Cc: Matt Weber <matthew.weber@rockwellcollins.com>
> Cc: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/uboot-tools/uboot-tools.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
> index f2bd627e927e..a0cdcafd4e7e 100644
> --- a/package/uboot-tools/uboot-tools.mk
> +++ b/package/uboot-tools/uboot-tools.mk
> @@ -160,7 +160,7 @@ endif #BR_BUILDING
> define HOST_UBOOT_TOOLS_GENERATE_BOOT_SCRIPT
> $(@D)/tools/mkimage -C none -A $(MKIMAGE_ARCH) -T script \
> -d $(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE)) \
> - $(@D)/tools/boot.scr)
> + $(@D)/tools/boot.scr
> endef
> define HOST_UBOOT_TOOLS_INSTALL_BOOT_SCRIPT
> $(INSTALL) -m 0755 -D $(@D)/tools/boot.scr $(BINARIES_DIR)/boot.scr
> --
> 2.29.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses
2021-01-28 12:33 [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses Baruch Siach
` (2 preceding siblings ...)
2021-01-28 16:34 ` Yann E. MORIN
@ 2021-01-28 20:18 ` Peter Korsgaard
3 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2021-01-28 20:18 UTC (permalink / raw
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Commit d8db91fc6fa ("package/uboot-tools: resolve host uboot env/script
> error") introduced closing parentheses that is not matched and not
> needed.
> Fixes:
> http://autobuild.buildroot.net/results/a65/a65fcc581f56ef70154f83e80f12d64f2e0f856a/
> http://autobuild.buildroot.net/results/39a/39aabb9d8afcdead1d620e081d2cd43ee2d61fbc/
> Cc: Matt Weber <matthew.weber@rockwellcollins.com>
> Cc: Kalpesh Panchal <kalpesh.panchal@rockwellcollins.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed to 2020.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-28 20:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-28 12:33 [Buildroot] [PATCH] package/uboot-tools: drop redundant parentheses Baruch Siach
2021-01-28 13:25 ` Matthew Weber
2021-01-28 13:55 ` Thomas Petazzoni
2021-01-28 14:02 ` Bin Meng
2021-01-28 16:34 ` Yann E. MORIN
2021-01-28 20:18 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.