From: Martin KaFai Lau <kafai@fb.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<davem@davemloft.net>, <ast@kernel.org>, <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next] selftests/bpf: initialize duration in xdp_noinline.c
Date: Thu, 1 Oct 2020 16:22:36 -0700 [thread overview]
Message-ID: <20201001232236.5plmque7q23uv3as@kafai-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201001225440.1373233-1-sdf@google.com>
On Thu, Oct 01, 2020 at 03:54:40PM -0700, Stanislav Fomichev wrote:
> Fixes clang error:
> tools/testing/selftests/bpf/prog_tests/xdp_noinline.c:35:6: error: variable 'duration' is uninitialized when used here [-Werror,-Wuninitialized]
> if (CHECK(!skel, "skel_open_and_load", "failed\n"))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
> ---
> tools/testing/selftests/bpf/prog_tests/xdp_noinline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c b/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c
> index a1f06424cf83..0281095de266 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c
> @@ -25,7 +25,7 @@ void test_xdp_noinline(void)
> __u8 flags;
> } real_def = {.dst = MAGIC_VAL};
> __u32 ch_key = 11, real_num = 3;
> - __u32 duration, retval, size;
> + __u32 duration = 0, retval, size;
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2020-10-01 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 22:54 [PATCH bpf-next] selftests/bpf: initialize duration in xdp_noinline.c Stanislav Fomichev
2020-10-01 23:22 ` Martin KaFai Lau [this message]
2020-10-02 14:50 ` patchwork-bot+bpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001232236.5plmque7q23uv3as@kafai-mbp.dhcp.thefacebook.com \
--to=kafai@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.