* [Buildroot] [PATCH 1/1] package/apcupsd: always depend on threads
@ 2020-04-22 6:49 James Hilliard
2020-04-23 20:55 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: James Hilliard @ 2020-04-22 6:49 UTC (permalink / raw
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/aa2ad7bdb37da611a4ec863ed2e986f34ea5228b/build-end.log
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/apcupsd/Config.in | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/package/apcupsd/Config.in b/package/apcupsd/Config.in
index 2849736a1a..e3fcc1e014 100644
--- a/package/apcupsd/Config.in
+++ b/package/apcupsd/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_APCUPSD
bool "apcupsd"
depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU # fork()
help
A daemon for controlling APC UPSes.
@@ -26,16 +27,12 @@ config BR2_PACKAGE_APCUPSD_MODBUS
config BR2_PACKAGE_APCUPSD_MODBUS_USB
bool "modbus usb"
- depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
select BR2_PACKAGE_LIBUSB
select BR2_PACKAGE_LIBUSB_COMPAT
select BR2_PACKAGE_APCUPSD_MODBUS
help
Compile MODBUS/USB driver code
-comment "modbus usb support needs a toolchain w/ threads"
- depends on !BR2_TOOLCHAIN_HAS_THREADS
-
config BR2_PACKAGE_APCUPSD_NET
bool "net"
help
@@ -53,17 +50,13 @@ config BR2_PACKAGE_APCUPSD_SNMP
config BR2_PACKAGE_APCUPSD_USB
bool "usb"
- depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
select BR2_PACKAGE_LIBUSB
select BR2_PACKAGE_LIBUSB_COMPAT
help
Compile USB UPS code
-comment "usb support needs a toolchain w/ threads"
- depends on !BR2_TOOLCHAIN_HAS_THREADS
-
endif
-comment "apcupsd needs a toolchain w/ C++"
+comment "apcupsd needs a toolchain w/ C++, threads"
depends on BR2_USE_MMU
- depends on !BR2_INSTALL_LIBSTDCPP
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/apcupsd: always depend on threads
2020-04-22 6:49 [Buildroot] [PATCH 1/1] package/apcupsd: always depend on threads James Hilliard
@ 2020-04-23 20:55 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2020-04-23 20:55 UTC (permalink / raw
To: buildroot
On Wed, 22 Apr 2020 00:49:42 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Fixes:
> http://autobuild.buildroot.net/results/aa2ad7bdb37da611a4ec863ed2e986f34ea5228b/build-end.log
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
I've applied, but I've kept the thread dependencies on the USB related
options. Even though, they are redundant, we like to keep them to be
fully consistent in how we propagate "depends on".
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-23 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-22 6:49 [Buildroot] [PATCH 1/1] package/apcupsd: always depend on threads James Hilliard
2020-04-23 20:55 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.