* [PATCH] staging: exfat: fixed coding style warning
@ 2020-03-12 22:01 Miguel Faggioni
2020-03-12 22:11 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Faggioni @ 2020-03-12 22:01 UTC (permalink / raw
To: devel
Inverted comparison order on r8192U_wx.c:752 to place constant on the
right side.
Signed-off-by: Miguel Faggioni <velocir@ptor.com.br>
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
index 0118edb0b..40fb4165b 100644
--- a/drivers/staging/rtl8192u/r8192U_wx.c
+++ b/drivers/staging/rtl8192u/r8192U_wx.c
@@ -749,7 +749,7 @@ static int r8192_wx_set_enc_ext(struct net_device *dev,
idx--;
group = ext->ext_flags & IW_ENCODE_EXT_GROUP_KEY;
- if ((!group) || (IW_MODE_ADHOC == ieee->iw_mode) || (alg == KEY_TYPE_WEP40)) {
+ if ((!group) || (ieee->iw_mode == IW_MODE_ADHOC) || (alg == KEY_TYPE_WEP40)) {
if ((ext->key_len == 13) && (alg == KEY_TYPE_WEP40))
alg = KEY_TYPE_WEP104;
ieee->pairwise_key_type = alg;
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: exfat: fixed coding style warning
2020-03-12 22:01 [PATCH] staging: exfat: fixed coding style warning Miguel Faggioni
@ 2020-03-12 22:11 ` Greg KH
[not found] ` <89f540b1-5ca5-4e53-b48a-e03117a06507@www.fastmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-03-12 22:11 UTC (permalink / raw
To: Miguel Faggioni; +Cc: devel
On Thu, Mar 12, 2020 at 10:01:27PM +0000, Miguel Faggioni wrote:
> Inverted comparison order on r8192U_wx.c:752 to place constant on the
> right side.
>
> Signed-off-by: Miguel Faggioni <velocir@ptor.com.br>
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The subject does not match the file being modified :(
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: exfat: fixed coding style warning
[not found] ` <89f540b1-5ca5-4e53-b48a-e03117a06507@www.fastmail.com>
@ 2020-03-12 23:02 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-03-12 23:02 UTC (permalink / raw
To: Miguel; +Cc: devel
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Mar 12, 2020 at 07:50:08PM -0300, Miguel wrote:
> oh, sorry
>
> I had the file being modified on the second line in the commit.
THe subject is still wrong :(
> Should I amend the commit message and send another email? or amend the commit message and send it on this same email thread?
I can't take this patch as is, so you will have to do something in order
to have it in acceptable shape.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-12 23:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-12 22:01 [PATCH] staging: exfat: fixed coding style warning Miguel Faggioni
2020-03-12 22:11 ` Greg KH
[not found] ` <89f540b1-5ca5-4e53-b48a-e03117a06507@www.fastmail.com>
2020-03-12 23:02 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.