* [PATCH net] net: dsa: mv88e6xxx: Fix masking of egress port
@ 2020-02-27 20:20 Andrew Lunn
2020-02-27 20:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2020-02-27 20:20 UTC (permalink / raw
To: David Miller
Cc: netdev, Vivien Didelot, Chris Healy, Andrew Lunn, Kevin Benson
Add missing ~ to the usage of the mask.
Reported-by: Kevin Benson <Kevin.Benson@zii.aero>
Reported-by: Chris Healy <Chris.Healy@zii.aero>
Fixes: 5c74c54ce6ff ("net: dsa: mv88e6xxx: Split monitor port configuration")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/global1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/global1.c b/drivers/net/dsa/mv88e6xxx/global1.c
index b016cc205f81..ca3a7a7a73c3 100644
--- a/drivers/net/dsa/mv88e6xxx/global1.c
+++ b/drivers/net/dsa/mv88e6xxx/global1.c
@@ -278,13 +278,13 @@ int mv88e6095_g1_set_egress_port(struct mv88e6xxx_chip *chip,
switch (direction) {
case MV88E6XXX_EGRESS_DIR_INGRESS:
dest_port_chip = &chip->ingress_dest_port;
- reg &= MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK;
+ reg &= ~MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK;
reg |= port <<
__bf_shf(MV88E6185_G1_MONITOR_CTL_INGRESS_DEST_MASK);
break;
case MV88E6XXX_EGRESS_DIR_EGRESS:
dest_port_chip = &chip->egress_dest_port;
- reg &= MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK;
+ reg &= ~MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK;
reg |= port <<
__bf_shf(MV88E6185_G1_MONITOR_CTL_EGRESS_DEST_MASK);
break;
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: dsa: mv88e6xxx: Fix masking of egress port
2020-02-27 20:20 [PATCH net] net: dsa: mv88e6xxx: Fix masking of egress port Andrew Lunn
@ 2020-02-27 20:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-02-27 20:30 UTC (permalink / raw
To: andrew; +Cc: netdev, vivien.didelot, Chris.Healy, Kevin.Benson
From: Andrew Lunn <andrew@lunn.ch>
Date: Thu, 27 Feb 2020 21:20:49 +0100
> Add missing ~ to the usage of the mask.
>
> Reported-by: Kevin Benson <Kevin.Benson@zii.aero>
> Reported-by: Chris Healy <Chris.Healy@zii.aero>
> Fixes: 5c74c54ce6ff ("net: dsa: mv88e6xxx: Split monitor port configuration")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks Andrew.
Please put the Fixes: tag first in the list of tags in the future.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-27 20:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-27 20:20 [PATCH net] net: dsa: mv88e6xxx: Fix masking of egress port Andrew Lunn
2020-02-27 20:30 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.