* [Intel-wired-lan] [PATCH v2] igc: Fix the typo in comment
@ 2020-01-20 6:17 Sasha Neftin
2020-01-21 22:26 ` Vinicius Costa Gomes
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Neftin @ 2020-01-20 6:17 UTC (permalink / raw
To: intel-wired-lan
Fix the typo and comment to correspond to the i225 device
v1->v2:
Address community comment
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
drivers/net/ethernet/intel/igc/igc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
index 5d38d0faeced..cb1362188c2a 100644
--- a/drivers/net/ethernet/intel/igc/igc.h
+++ b/drivers/net/ethernet/intel/igc/igc.h
@@ -112,7 +112,7 @@ extern char igc_driver_version[];
#define IGC_RX_HDR_LEN IGC_RXBUFFER_256
/* Transmit and receive latency (for PTP timestamps) */
-/* FIXME: These values were estimated using the ones that i210 has as
+/* FIXME: These values were estimated using the ones that i225 has as
* basis, they seem to provide good numbers with ptp4l/phc2sys, but we
* need to confirm them.
*/
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [PATCH v2] igc: Fix the typo in comment
2020-01-20 6:17 [Intel-wired-lan] [PATCH v2] igc: Fix the typo in comment Sasha Neftin
@ 2020-01-21 22:26 ` Vinicius Costa Gomes
0 siblings, 0 replies; 2+ messages in thread
From: Vinicius Costa Gomes @ 2020-01-21 22:26 UTC (permalink / raw
To: intel-wired-lan
Hi Sasha,
Sasha Neftin <sasha.neftin@intel.com> writes:
> Fix the typo and comment to correspond to the i225 device
> v1->v2:
> Address community comment
>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
> index 5d38d0faeced..cb1362188c2a 100644
> --- a/drivers/net/ethernet/intel/igc/igc.h
> +++ b/drivers/net/ethernet/intel/igc/igc.h
> @@ -112,7 +112,7 @@ extern char igc_driver_version[];
> #define IGC_RX_HDR_LEN IGC_RXBUFFER_256
>
> /* Transmit and receive latency (for PTP timestamps) */
> -/* FIXME: These values were estimated using the ones that i210 has as
> +/* FIXME: These values were estimated using the ones that i225 has as
> * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
> * need to confirm them.
> */
If you are sending this patch, it means that I couldn't explain myself
well enough. The idea of that comment was to point out that the
documentation doesn't provide an estimate of those values, so I used the
ones from the i210 datasheet.
Cheers,
--
Vinicius
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-21 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-20 6:17 [Intel-wired-lan] [PATCH v2] igc: Fix the typo in comment Sasha Neftin
2020-01-21 22:26 ` Vinicius Costa Gomes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.