From: "Paul E. McKenney" <paulmck@kernel.org>
To: Amol Grover <frextrite@gmail.com>
Cc: Phong Tran <tranmanphong@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
rcu@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] Documentation: RCU: rcubarrier: Convert to reST
Date: Thu, 7 Nov 2019 01:55:54 -0800 [thread overview]
Message-ID: <20191107095553.GM20975@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20191107063949.GA2310@workstation-kernel-dev>
On Thu, Nov 07, 2019 at 12:09:49PM +0530, Amol Grover wrote:
> On Thu, Nov 07, 2019 at 07:19:27AM +0700, Phong Tran wrote:
> > On 11/6/19 11:56 PM, Amol Grover wrote:
[ . . . ]
> > > We instead need the rcu_barrier() primitive. Rather than waiting for
> > > a grace period to elapse, rcu_barrier() waits for all outstanding RCU
> > > -callbacks to complete. Please note that rcu_barrier() does -not- imply
> > > +callbacks to complete. Please note that rcu_barrier() does **not** imply
> > > synchronize_rcu(), in particular, if there are no RCU callbacks queued
> > > anywhere, rcu_barrier() is within its rights to return immediately,
> > > without waiting for a grace period to elapse.
> > > @@ -89,78 +94,78 @@ module uses multiple flavors of call_rcu(), then it must also use multiple
> > > flavors of rcu_barrier() when unloading that module. For example, if
> > > it uses call_rcu(), call_srcu() on srcu_struct_1, and call_srcu() on
> > > srcu_struct_2(), then the following three lines of code will be required
> >
> > Hello Amol,
> >
> > srcu_struct_2() should be srcu_struct_2
>
> Hey Phong,
> Thanks for the review! Fixed and sent the new patch
> https://lore.kernel.org/lkml/20191107063241.GA2234@workstation-kernel-dev/
Phong, please let us know whether Amol's new version looks good to you.
If it does, preferably with your Reviewed-by and/or Tested by. ;-)
Thanx, Paul
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Amol Grover <frextrite@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Lai Jiangshan <jiangshanlai@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] Documentation: RCU: rcubarrier: Convert to reST
Date: Thu, 7 Nov 2019 01:55:54 -0800 [thread overview]
Message-ID: <20191107095553.GM20975@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20191107063949.GA2310@workstation-kernel-dev>
On Thu, Nov 07, 2019 at 12:09:49PM +0530, Amol Grover wrote:
> On Thu, Nov 07, 2019 at 07:19:27AM +0700, Phong Tran wrote:
> > On 11/6/19 11:56 PM, Amol Grover wrote:
[ . . . ]
> > > We instead need the rcu_barrier() primitive. Rather than waiting for
> > > a grace period to elapse, rcu_barrier() waits for all outstanding RCU
> > > -callbacks to complete. Please note that rcu_barrier() does -not- imply
> > > +callbacks to complete. Please note that rcu_barrier() does **not** imply
> > > synchronize_rcu(), in particular, if there are no RCU callbacks queued
> > > anywhere, rcu_barrier() is within its rights to return immediately,
> > > without waiting for a grace period to elapse.
> > > @@ -89,78 +94,78 @@ module uses multiple flavors of call_rcu(), then it must also use multiple
> > > flavors of rcu_barrier() when unloading that module. For example, if
> > > it uses call_rcu(), call_srcu() on srcu_struct_1, and call_srcu() on
> > > srcu_struct_2(), then the following three lines of code will be required
> >
> > Hello Amol,
> >
> > srcu_struct_2() should be srcu_struct_2
>
> Hey Phong,
> Thanks for the review! Fixed and sent the new patch
> https://lore.kernel.org/lkml/20191107063241.GA2234@workstation-kernel-dev/
Phong, please let us know whether Amol's new version looks good to you.
If it does, preferably with your Reviewed-by and/or Tested by. ;-)
Thanx, Paul
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2019-11-07 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 16:56 [PATCH] Documentation: RCU: rcubarrier: Convert to reST Amol Grover
2019-11-06 16:56 ` [Linux-kernel-mentees] " Amol Grover
2019-11-06 17:13 ` Paul E. McKenney
2019-11-06 17:13 ` [Linux-kernel-mentees] " Paul E. McKenney
2019-11-07 0:19 ` Phong Tran
2019-11-07 0:19 ` Phong Tran
2019-11-07 6:39 ` Amol Grover
2019-11-07 6:39 ` Amol Grover
2019-11-07 9:55 ` Paul E. McKenney [this message]
2019-11-07 9:55 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107095553.GM20975@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=corbet@lwn.net \
--cc=frextrite@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.