From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD77C43331 for ; Thu, 7 Nov 2019 23:55:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 420CA20674 for ; Thu, 7 Nov 2019 23:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726281AbfKGXzj (ORCPT ); Thu, 7 Nov 2019 18:55:39 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:50246 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfKGXzj (ORCPT ); Thu, 7 Nov 2019 18:55:39 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 408741537E8F6; Thu, 7 Nov 2019 15:55:38 -0800 (PST) Date: Thu, 07 Nov 2019 15:55:37 -0800 (PST) Message-Id: <20191107.155537.1932749594952088637.davem@davemloft.net> To: madalin.bucur@nxp.com Cc: netdev@vger.kernel.org, hkallweit1@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com Subject: Re: [PATCH net-next] net: phy: at803x: add missing dependency on CONFIG_REGULATOR From: David Miller In-Reply-To: <1573131824-21664-1-git-send-email-madalin.bucur@nxp.com> References: <1573131824-21664-1-git-send-email-madalin.bucur@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Nov 2019 15:55:38 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Madalin Bucur Date: Thu, 7 Nov 2019 15:03:44 +0200 > Compilation fails on PPC targets as CONFIG_REGULATOR is not set and > drivers/regulator/devres.c is not compiled in while functions exported > there are used by drivers/net/phy/at803x.c. Here's the error log: > > LD .tmp_vmlinux1 > drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_set_voltage_sel': > drivers/net/phy/at803x.c:294: undefined reference to `.rdev_get_drvdata' > drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_get_voltage_sel': > drivers/net/phy/at803x.c:306: undefined reference to `.rdev_get_drvdata' > drivers/net/phy/at803x.o: In function `at8031_register_regulators': > drivers/net/phy/at803x.c:359: undefined reference to `.devm_regulator_register' > drivers/net/phy/at803x.c:365: undefined reference to `.devm_regulator_register' > drivers/net/phy/at803x.o:(.data.rel+0x0): undefined reference to `regulator_list_voltage_table' > linux/Makefile:1074: recipe for target 'vmlinux' failed > make[1]: *** [vmlinux] Error 1 > > Fixes: 2f664823a470 ("net: phy: at803x: add device tree binding") > Signed-off-by: Madalin Bucur Applied, thanks.