From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BFD0CA9EAE for ; Wed, 30 Oct 2019 00:41:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18B6D20866 for ; Wed, 30 Oct 2019 00:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbfJ3AlM (ORCPT ); Tue, 29 Oct 2019 20:41:12 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33650 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbfJ3AlL (ORCPT ); Tue, 29 Oct 2019 20:41:11 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 78BC413EF0D09; Tue, 29 Oct 2019 17:41:11 -0700 (PDT) Date: Tue, 29 Oct 2019 17:41:11 -0700 (PDT) Message-Id: <20191029.174111.1326267225443351642.davem@davemloft.net> To: yangchun@google.com Cc: netdev@vger.kernel.org, csully@google.com Subject: Re: [PATCH net] gve: Fixes DMA synchronization. From: David Miller In-Reply-To: <20191028182309.73313-1-yangchun@google.com> References: <20191028182309.73313-1-yangchun@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Oct 2019 17:41:11 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yangchun Fu Date: Mon, 28 Oct 2019 11:23:09 -0700 > diff --git a/drivers/net/ethernet/google/gve/gve_tx.c b/drivers/net/ethernet/google/gve/gve_tx.c > index 778b87b5a06c..d8342b7b9764 100644 > --- a/drivers/net/ethernet/google/gve/gve_tx.c > +++ b/drivers/net/ethernet/google/gve/gve_tx.c > @@ -390,7 +390,23 @@ static void gve_tx_fill_seg_desc(union gve_tx_desc *seg_desc, > seg_desc->seg.seg_addr = cpu_to_be64(addr); > } > > -static int gve_tx_add_skb(struct gve_tx_ring *tx, struct sk_buff *skb) > +static inline void gve_dma_sync_for_device(struct gve_priv *priv, > + dma_addr_t *page_buses, > + u64 iov_offset, u64 iov_len) Never use the inline keyword in foo.c files, let the compiler device.