From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168A3C47E49 for ; Tue, 22 Oct 2019 18:35:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E33B721872 for ; Tue, 22 Oct 2019 18:35:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="ZY+eGwNS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387421AbfJVSfg (ORCPT ); Tue, 22 Oct 2019 14:35:36 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:33463 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731007AbfJVSfg (ORCPT ); Tue, 22 Oct 2019 14:35:36 -0400 Received: by mail-lf1-f65.google.com with SMTP id y127so13949514lfc.0 for ; Tue, 22 Oct 2019 11:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=dPjuP+VmWSvLVAg6NKGM3Tn3kuQc1C/B6A+vpJASWdY=; b=ZY+eGwNS1QBTYwz/CjaNPAO/9O6VCd5l8HjrB1XlkYYK1I9HAT/tr9qxWAVDZnIMy3 COZ1QAjvsk8hTeflE3BH/PlnIhFWEn/Rm6UySdg7QOhbGZcI6UtNAlydLnRE3SYphZ3V e7xZE7D9WZgmpmyfNmfVyDDcGPQIgkJNcrz4W5d2Kx4N4p2uO/u+QZoOjCPM2KDwx/cH YsaH3ADlMAlnRjTgo/J11f8iei1l162PDU+pCBuUNceTD6X+xwUs0ggc/pNjRES05xYX GVeOFockjWvAoMSD6NiUKuqkK0JhQCf7YwXZK1sjvGhmiUnrHtx0Ts064NF8RtXeXOGH 2nHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=dPjuP+VmWSvLVAg6NKGM3Tn3kuQc1C/B6A+vpJASWdY=; b=Vis4a1Y2N2a+jzuBNHWU0XtMNwYsNMNhq0vCQ7twRcj89n05ZR5jQoI9uUEMiqPrWu 0KBkXIUs1LtFSxWyzX2BUCz/Wn+Y5qiKx24tGgNl8shgeUVKLZtccPQqmhhYcOeanpBD Apk+oVp0RfrOCM0YWfmYlQWSzo2IXlwJCi7PtlmO4yJEELCANyb2bCoJngnm0rN1+o9q Bd3YGv39N2O+eZYQx0aXuOH471y4LyYL0g76swIxfXKnKt0VMe8y2//j3/eNN+ELzS9A bGeqm8zfv1fxp1Am6v48fAIPunnUMaBucaEertIVfjSQSQA27wVfr07ufMQMA+n/2CmC 53bA== X-Gm-Message-State: APjAAAVYMJI25+/Yhga9M0Gw90r/TcSG80r5XfVaKBoPtOYKR2LTnbT1 qsPbZr6AyS4oaWBSTv7YO5QFtw== X-Google-Smtp-Source: APXvYqzhCd56Nx8O4+lldDDoiyHjvdnSJlA1XNHIMqwmMg9D7RLGjAvgsrRnfY16rQphZvyzjEjxXw== X-Received: by 2002:a19:7516:: with SMTP id y22mr19388885lfe.57.1571769333823; Tue, 22 Oct 2019 11:35:33 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id t8sm15056191ljd.18.2019.10.22.11.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 11:35:33 -0700 (PDT) Date: Tue, 22 Oct 2019 11:35:27 -0700 From: Jakub Kicinski To: Juergen Gross Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Liu , Paul Durrant , "David S. Miller" Subject: Re: [PATCH] xen/netback: cleanup init and deinit code Message-ID: <20191022113527.6b6bf615@cakuba.netronome.com> In-Reply-To: <20191021053052.31690-1-jgross@suse.com> References: <20191021053052.31690-1-jgross@suse.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019 07:30:52 +0200, Juergen Gross wrote: > Do some cleanup of the netback init and deinit code: > > - add an omnipotent queue deinit function usable from > xenvif_disconnect_data() and the error path of xenvif_connect_data() > - only install the irq handlers after initializing all relevant items > (especially the kthreads related to the queue) > - there is no need to use get_task_struct() after creating a kthread > and using put_task_struct() again after having stopped it. > - use kthread_run() instead of kthread_create() to spare the call of > wake_up_process(). > > Signed-off-by: Juergen Gross > Reviewed-by: Paul Durrant Applied to net-next, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E75CA9EA0 for ; Tue, 22 Oct 2019 18:35:52 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B28021872 for ; Tue, 22 Oct 2019 18:35:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="ZY+eGwNS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B28021872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iMz0L-0007Ib-5p; Tue, 22 Oct 2019 18:35:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iMz0J-0007IU-My for xen-devel@lists.xenproject.org; Tue, 22 Oct 2019 18:35:35 +0000 X-Inumbo-ID: bbee0d0e-f4fa-11e9-8aca-bc764e2007e4 Received: from mail-lf1-x141.google.com (unknown [2a00:1450:4864:20::141]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bbee0d0e-f4fa-11e9-8aca-bc764e2007e4; Tue, 22 Oct 2019 18:35:35 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id f5so6198711lfp.1 for ; Tue, 22 Oct 2019 11:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=dPjuP+VmWSvLVAg6NKGM3Tn3kuQc1C/B6A+vpJASWdY=; b=ZY+eGwNS1QBTYwz/CjaNPAO/9O6VCd5l8HjrB1XlkYYK1I9HAT/tr9qxWAVDZnIMy3 COZ1QAjvsk8hTeflE3BH/PlnIhFWEn/Rm6UySdg7QOhbGZcI6UtNAlydLnRE3SYphZ3V e7xZE7D9WZgmpmyfNmfVyDDcGPQIgkJNcrz4W5d2Kx4N4p2uO/u+QZoOjCPM2KDwx/cH YsaH3ADlMAlnRjTgo/J11f8iei1l162PDU+pCBuUNceTD6X+xwUs0ggc/pNjRES05xYX GVeOFockjWvAoMSD6NiUKuqkK0JhQCf7YwXZK1sjvGhmiUnrHtx0Ts064NF8RtXeXOGH 2nHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=dPjuP+VmWSvLVAg6NKGM3Tn3kuQc1C/B6A+vpJASWdY=; b=cYE6HShyLSRQIxAXc6y7jG2sDO2RBDsW7FtgUcIDUioCHRCWqW5B9aJhwlTUC+sP/h jTTIRl6MOFA0eqSgLudaWHLqDzaTySZ5vb80KPHk3TsPPC++9gC/gZ/w/g4lKcdkJLQ4 4g53Gpw5QZj7Asp7Sd/XqMHn7jeL3PZvcr8QhHuQzLnXxagW3JQrwvi5/U0VueU4eALI RfPA3zHLco9XzJarj433ODbdeIpQfXFKrr0j+ZZBH0el/eRmqoOFqARbmkA5///gzpz6 FA0LOMM4wAU8H6/hRT1kevV+o23hPyg6avtvH39wQCddexPB9lbxzj1CWOeM4Lt6Ui7U 0FHQ== X-Gm-Message-State: APjAAAWf/iwtObZgA3Cr5d0eTu1Xf9K+bS695yXt0KUjem1+SveGoaLl Czg7hltBx60ZjdqMllElbUJAWQ== X-Google-Smtp-Source: APXvYqzhCd56Nx8O4+lldDDoiyHjvdnSJlA1XNHIMqwmMg9D7RLGjAvgsrRnfY16rQphZvyzjEjxXw== X-Received: by 2002:a19:7516:: with SMTP id y22mr19388885lfe.57.1571769333823; Tue, 22 Oct 2019 11:35:33 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id t8sm15056191ljd.18.2019.10.22.11.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 11:35:33 -0700 (PDT) Date: Tue, 22 Oct 2019 11:35:27 -0700 From: Jakub Kicinski To: Juergen Gross Message-ID: <20191022113527.6b6bf615@cakuba.netronome.com> In-Reply-To: <20191021053052.31690-1-jgross@suse.com> References: <20191021053052.31690-1-jgross@suse.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH] xen/netback: cleanup init and deinit code X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Paul Durrant , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gTW9uLCAyMSBPY3QgMjAxOSAwNzozMDo1MiArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToK PiBEbyBzb21lIGNsZWFudXAgb2YgdGhlIG5ldGJhY2sgaW5pdCBhbmQgZGVpbml0IGNvZGU6Cj4g Cj4gLSBhZGQgYW4gb21uaXBvdGVudCBxdWV1ZSBkZWluaXQgZnVuY3Rpb24gdXNhYmxlIGZyb20K PiAgIHhlbnZpZl9kaXNjb25uZWN0X2RhdGEoKSBhbmQgdGhlIGVycm9yIHBhdGggb2YgeGVudmlm X2Nvbm5lY3RfZGF0YSgpCj4gLSBvbmx5IGluc3RhbGwgdGhlIGlycSBoYW5kbGVycyBhZnRlciBp bml0aWFsaXppbmcgYWxsIHJlbGV2YW50IGl0ZW1zCj4gICAoZXNwZWNpYWxseSB0aGUga3RocmVh ZHMgcmVsYXRlZCB0byB0aGUgcXVldWUpCj4gLSB0aGVyZSBpcyBubyBuZWVkIHRvIHVzZSBnZXRf dGFza19zdHJ1Y3QoKSBhZnRlciBjcmVhdGluZyBhIGt0aHJlYWQKPiAgIGFuZCB1c2luZyBwdXRf dGFza19zdHJ1Y3QoKSBhZ2FpbiBhZnRlciBoYXZpbmcgc3RvcHBlZCBpdC4KPiAtIHVzZSBrdGhy ZWFkX3J1bigpIGluc3RlYWQgb2Yga3RocmVhZF9jcmVhdGUoKSB0byBzcGFyZSB0aGUgY2FsbCBv Zgo+ICAgd2FrZV91cF9wcm9jZXNzKCkuCj4gCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9z cyA8amdyb3NzQHN1c2UuY29tPgo+IFJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBkdXJyYW50 QGdtYWlsLmNvbT4KCkFwcGxpZWQgdG8gbmV0LW5leHQsIHRoYW5rcyEKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QK WGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5v cmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=