From: Jamal Shareef <jamal.k.shareef@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com,
teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH] staging: sm750fb: Edit CamelCase in ddk750_power.h
Date: Sun, 20 Oct 2019 15:11:19 -0700 [thread overview]
Message-ID: <20191020221119.GA22202@jamal-XPS-13-9343> (raw)
In-Reply-To: <alpine.DEB.2.21.1910180828500.2666@hadrien>
On Fri, Oct 18, 2019 at 08:30:01AM +0200, Julia Lawall wrote:
> You don't need to put the name of the file in the subject line. One can
> see that easily from the diffstat information.
>
> On Thu, 17 Oct 2019, Jamal Shareef wrote:
>
> > Removes instances of CamelCase. Issue found by checkpatch.
> >
> > Signed-off-by: Jamal Shareef <jamal.k.shareef@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_power.h | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
> > index 7002567a47d2..cd892f2b717f 100644
> > --- a/drivers/staging/sm750fb/ddk750_power.h
> > +++ b/drivers/staging/sm750fb/ddk750_power.h
> > @@ -3,10 +3,10 @@
> > #define DDK750_POWER_H__
> >
> > enum dpms {
> > - crtDPMS_ON = 0x0,
> > - crtDPMS_STANDBY = 0x1,
> > - crtDPMS_SUSPEND = 0x2,
> > - crtDPMS_OFF = 0x3,
> > + crt_DPMS_ON = 0x0,
> > + crt_DPMS_STANDBY = 0x1,
> > + crt_DPMS_SUSPEND = 0x2,
> > + crt_DPMS_OFF = 0x3,
> > };
> >
> > #define set_DAC(off) { \
> > @@ -15,7 +15,7 @@ enum dpms {
> > }
> >
> > void ddk750_set_dpms(enum dpms state);
> > -void sm750_set_power_mode(unsigned int powerMode);
> > +void sm750_set_power_mode(unsigned int power_mode);
>
> This looks suspicious. You shouldn't be updating only the prototype
> without updating the definition as well.
>
> julia
>
A grep for these function names doesn't return any other hits. It does
look suspicious however. This enum is used by other function but not by
use of the enum labels themselves initially.
Jamal
> > void sm750_set_current_gate(unsigned int gate);
> >
> > /*
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191018020112.22226-1-jamal.k.shareef%40gmail.com.
> >
prev parent reply other threads:[~2019-10-20 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 2:01 [PATCH] staging: sm750fb: Edit CamelCase in ddk750_power.h Jamal Shareef
2019-10-18 6:30 ` [Outreachy kernel] " Julia Lawall
2019-10-20 22:11 ` Jamal Shareef [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191020221119.GA22202@jamal-XPS-13-9343 \
--to=jamal.k.shareef@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.