From: Christoph Hellwig <hch@infradead.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, mhocko@kernel.org,
peterz@infradead.org, robin.murphy@arm.com, geert@linux-m68k.org,
gregkh@linuxfoundation.org, paul.burton@mips.com
Subject: Re: [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE
Date: Sat, 19 Oct 2019 01:34:31 -0700 [thread overview]
Message-ID: <20191019083431.GA26340@infradead.org> (raw)
In-Reply-To: <1571467543-26125-1-git-send-email-linyunsheng@huawei.com>
On Sat, Oct 19, 2019 at 02:45:43PM +0800, Yunsheng Lin wrote:
> + if (nr_node_ids > 1 && dev_to_node(bus->bridge) == NUMA_NO_NODE)
> + dev_err(bus->bridge, FW_BUG "No node assigned on NUMA capable HW by BIOS. Please contact your vendor for updates.\n");
> +
The whole idea of mentioning a BIOS in architeture indepent code doesn't
make sense at all.
next prev parent reply other threads:[~2019-10-19 8:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 6:45 [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE Yunsheng Lin
2019-10-19 8:34 ` Christoph Hellwig [this message]
2019-10-21 4:05 ` Yunsheng Lin
2019-10-22 13:55 ` Robin Murphy
2019-10-23 8:24 ` Yunsheng Lin
2019-10-22 21:04 ` Bjorn Helgaas
2019-10-23 8:22 ` Yunsheng Lin
2019-10-23 17:10 ` Bjorn Helgaas
2019-10-24 9:20 ` Michal Hocko
2019-10-24 17:40 ` Bjorn Helgaas
2019-10-25 8:16 ` Michal Hocko
2019-10-25 8:51 ` Yunsheng Lin
2019-10-24 9:39 ` Yunsheng Lin
2019-10-24 10:16 ` Robin Murphy
2019-10-25 12:51 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191019083431.GA26340@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=mhocko@kernel.org \
--cc=paul.burton@mips.com \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.