From: Sam Ravnborg <sam@ravnborg.org>
To: Adam Ford <aford173@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
adam.ford@logicpd.com, Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: Add Logic PD Type 28 display panel
Date: Sat, 21 Sep 2019 21:07:08 +0200 [thread overview]
Message-ID: <20190921190708.GB32133@ravnborg.org> (raw)
In-Reply-To: <20190917161214.2913-2-aford173@gmail.com>
Hi Adam.
Good with even more panels.
But for new bindings please use meta-schema (.yaml) format.
This is what we use for new bindings as it allows better
validation.
Sam
On Tue, Sep 17, 2019 at 11:12:12AM -0500, Adam Ford wrote:
> This patch adds documentation of device tree bindings for the WVGA panel
> Logic PD Type 28 display.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt
> new file mode 100644
> index 000000000000..829fc5210e06
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt
> @@ -0,0 +1,26 @@
> +Logic PD Type 28 4.3" WQVGA TFT LCD panel
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> +
> +Required properties:
> +- compatible: should be "logicpd,type28"
> +
> +Optional properties:
> +- power-supply: regulator to provide the supply voltage
> +- enable-gpios: GPIO pin to enable or disable the panel
> +- backlight: phandle of the backlight device attached to the panel
Is it correct that these are optional for the descrivbed panel?
> +
> +Optional nodes:
> +- Video port for RGB input.
> +
> +Example:
> + lcd0: display {
> + compatible = "logicpd,type28";
> + enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;
> + port {
> + lcd_in: endpoint {
> + remote-endpoint = <&dpi_out>;
> + };
> + };
> + };
> --
> 2.17.1
next prev parent reply other threads:[~2019-09-21 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 16:12 [PATCH 1/3] drm/panel: simple: Add Logic PD Type 28 display support Adam Ford
2019-09-17 16:12 ` [PATCH 2/3] dt-bindings: Add Logic PD Type 28 display panel Adam Ford
2019-09-21 19:07 ` Sam Ravnborg [this message]
2019-09-23 13:31 ` Adam Ford
2019-09-17 16:12 ` [PATCH 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel Adam Ford
2019-09-21 19:09 ` Sam Ravnborg
2019-09-23 13:32 ` Adam Ford
2019-09-23 13:32 ` Adam Ford
2019-09-21 19:07 ` [PATCH 1/3] drm/panel: simple: Add Logic PD Type 28 display support Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190921190708.GB32133@ravnborg.org \
--to=sam@ravnborg.org \
--cc=adam.ford@logicpd.com \
--cc=aford173@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.