* [PATCH iproute2] link_xfrm: don't forcce to set phydev
@ 2019-09-16 15:36 Nicolas Dichtel
2019-09-16 17:29 ` Matt Ellison
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Dichtel @ 2019-09-16 15:36 UTC (permalink / raw
To: stephen; +Cc: netdev, dsahern, julien.floret, Nicolas Dichtel, Matt Ellison
Since linux commit 22d6552f827e ("xfrm interface: fix management of
phydev"), phydev is not mandatory anymore.
Note that it also could be useful before the above commit to not force the
user to put a phydev (the kernel was checking it anyway).
For example, it was useful to not set it in case of x-netns, because the
phydev is not available in the current netns:
Before the patch:
$ ip netns add foo
$ ip link add xfrm1 type xfrm dev eth1 if_id 1
$ ip link set xfrm1 netns foo
$ ip -n foo link set xfrm1 type xfrm dev eth1 if_id 2
Cannot find device "eth1"
$ ip -n foo link set xfrm1 type xfrm if_id 2
must specify physical device
CC: Matt Ellison <matt@arroyo.io>
Fixes: 286446c1e8c7 ("ip: support for xfrm interfaces")
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=22d6552f827e
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
ip/link_xfrm.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/ip/link_xfrm.c b/ip/link_xfrm.c
index 7a3285b42045..a28f308d5610 100644
--- a/ip/link_xfrm.c
+++ b/ip/link_xfrm.c
@@ -17,7 +17,7 @@ static void xfrm_print_help(struct link_util *lu, int argc, char **argv,
FILE *f)
{
fprintf(f,
- "Usage: ... %-4s dev PHYS_DEV [ if_id IF-ID ]\n"
+ "Usage: ... %-4s dev [ PHYS_DEV ] [ if_id IF-ID ]\n"
"\n"
"Where: IF-ID := { 0x0..0xffffffff }\n",
lu->id);
@@ -46,12 +46,8 @@ static int xfrm_parse_opt(struct link_util *lu, int argc, char **argv,
argc--; argv++;
}
- if (link) {
+ if (link)
addattr32(n, 1024, IFLA_XFRM_LINK, link);
- } else {
- fprintf(stderr, "must specify physical device\n");
- return -1;
- }
return 0;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2] link_xfrm: don't forcce to set phydev
2019-09-16 15:36 [PATCH iproute2] link_xfrm: don't forcce to set phydev Nicolas Dichtel
@ 2019-09-16 17:29 ` Matt Ellison
0 siblings, 0 replies; 2+ messages in thread
From: Matt Ellison @ 2019-09-16 17:29 UTC (permalink / raw
To: Nicolas Dichtel; +Cc: stephen, netdev, dsahern, julien.floret
Acked-by: Matt Ellison <matt@arroyo.io>
--
Please be advised that this email may contain confidential information.
If you are not the intended recipient, please notify us by email by
replying to the sender and delete this message. The sender disclaims that
the content of this email constitutes an offer to enter into, or the
acceptance of, any agreement; provided that the foregoing does not
invalidate the binding effect of any digital or other electronic
reproduction of a manual signature that is included in any attachment.
<https://twitter.com/arroyo_networks>
<https://www.linkedin.com/company/arroyo-networks>
<https://www.github.com/ArroyoNetworks>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-16 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-16 15:36 [PATCH iproute2] link_xfrm: don't forcce to set phydev Nicolas Dichtel
2019-09-16 17:29 ` Matt Ellison
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.