* [PATCH] staging: greybus: loopback_test: remove multiple blank lines
@ 2019-09-04 21:05 ` Pedro Chinen
0 siblings, 0 replies; 4+ messages in thread
From: Pedro Chinen @ 2019-09-04 21:05 UTC (permalink / raw
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev, devel,
linux-kernel, lkcamp
Fix following checkpath warnings in multiple lines:
CHECK: Please don't use multiple blank lines
Signed-off-by: Pedro Chinen <ph.u.chinen@gmail.com>
---
drivers/staging/greybus/tools/loopback_test.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
index ba6f905f26fa..1e78c148d7cb 100644
--- a/drivers/staging/greybus/tools/loopback_test.c
+++ b/drivers/staging/greybus/tools/loopback_test.c
@@ -779,7 +779,6 @@ static void prepare_devices(struct loopback_test *t)
if (t->stop_all || device_enabled(t, i))
write_sysfs_val(t->devices[i].sysfs_entry, "type", 0);
-
for (i = 0; i < t->device_count; i++) {
if (!device_enabled(t, i))
continue;
@@ -850,7 +849,6 @@ void loopback_run(struct loopback_test *t)
if (ret)
goto err;
-
get_results(t);
log_results(t);
@@ -882,7 +880,6 @@ static int sanity_check(struct loopback_test *t)
}
-
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging: greybus: loopback_test: remove multiple blank lines
@ 2019-09-04 21:05 ` Pedro Chinen
0 siblings, 0 replies; 4+ messages in thread
From: Pedro Chinen @ 2019-09-04 21:05 UTC (permalink / raw
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev, devel,
linux-kernel, lkcamp
Fix following checkpath warnings in multiple lines:
CHECK: Please don't use multiple blank lines
Signed-off-by: Pedro Chinen <ph.u.chinen@gmail.com>
---
drivers/staging/greybus/tools/loopback_test.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
index ba6f905f26fa..1e78c148d7cb 100644
--- a/drivers/staging/greybus/tools/loopback_test.c
+++ b/drivers/staging/greybus/tools/loopback_test.c
@@ -779,7 +779,6 @@ static void prepare_devices(struct loopback_test *t)
if (t->stop_all || device_enabled(t, i))
write_sysfs_val(t->devices[i].sysfs_entry, "type", 0);
-
for (i = 0; i < t->device_count; i++) {
if (!device_enabled(t, i))
continue;
@@ -850,7 +849,6 @@ void loopback_run(struct loopback_test *t)
if (ret)
goto err;
-
get_results(t);
log_results(t);
@@ -882,7 +880,6 @@ static int sanity_check(struct loopback_test *t)
}
-
return 0;
}
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: greybus: loopback_test: remove multiple blank lines
2019-09-04 21:05 ` Pedro Chinen
@ 2019-09-05 7:25 ` Johan Hovold
-1 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2019-09-05 7:25 UTC (permalink / raw
To: Pedro Chinen
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev, devel,
linux-kernel, lkcamp
On Wed, Sep 04, 2019 at 09:05:47PM +0000, Pedro Chinen wrote:
> Fix following checkpath warnings in multiple lines:
> CHECK: Please don't use multiple blank lines
Checkpatch reports five instances of this CHECK, please fix them all in
one go.
> Signed-off-by: Pedro Chinen <ph.u.chinen@gmail.com>
> ---
> drivers/staging/greybus/tools/loopback_test.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
> index ba6f905f26fa..1e78c148d7cb 100644
> --- a/drivers/staging/greybus/tools/loopback_test.c
> +++ b/drivers/staging/greybus/tools/loopback_test.c
> @@ -779,7 +779,6 @@ static void prepare_devices(struct loopback_test *t)
> if (t->stop_all || device_enabled(t, i))
> write_sysfs_val(t->devices[i].sysfs_entry, "type", 0);
>
> -
> for (i = 0; i < t->device_count; i++) {
> if (!device_enabled(t, i))
> continue;
> @@ -850,7 +849,6 @@ void loopback_run(struct loopback_test *t)
> if (ret)
> goto err;
>
> -
> get_results(t);
>
> log_results(t);
> @@ -882,7 +880,6 @@ static int sanity_check(struct loopback_test *t)
>
> }
>
> -
> return 0;
> }
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: greybus: loopback_test: remove multiple blank lines
@ 2019-09-05 7:25 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2019-09-05 7:25 UTC (permalink / raw
To: Pedro Chinen
Cc: devel, Alex Elder, Greg Kroah-Hartman, Johan Hovold, linux-kernel,
greybus-dev, lkcamp
On Wed, Sep 04, 2019 at 09:05:47PM +0000, Pedro Chinen wrote:
> Fix following checkpath warnings in multiple lines:
> CHECK: Please don't use multiple blank lines
Checkpatch reports five instances of this CHECK, please fix them all in
one go.
> Signed-off-by: Pedro Chinen <ph.u.chinen@gmail.com>
> ---
> drivers/staging/greybus/tools/loopback_test.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
> index ba6f905f26fa..1e78c148d7cb 100644
> --- a/drivers/staging/greybus/tools/loopback_test.c
> +++ b/drivers/staging/greybus/tools/loopback_test.c
> @@ -779,7 +779,6 @@ static void prepare_devices(struct loopback_test *t)
> if (t->stop_all || device_enabled(t, i))
> write_sysfs_val(t->devices[i].sysfs_entry, "type", 0);
>
> -
> for (i = 0; i < t->device_count; i++) {
> if (!device_enabled(t, i))
> continue;
> @@ -850,7 +849,6 @@ void loopback_run(struct loopback_test *t)
> if (ret)
> goto err;
>
> -
> get_results(t);
>
> log_results(t);
> @@ -882,7 +880,6 @@ static int sanity_check(struct loopback_test *t)
>
> }
>
> -
> return 0;
> }
Johan
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-05 7:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-04 21:05 [PATCH] staging: greybus: loopback_test: remove multiple blank lines Pedro Chinen
2019-09-04 21:05 ` Pedro Chinen
2019-09-05 7:25 ` Johan Hovold
2019-09-05 7:25 ` Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.