* [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16
@ 2019-08-31 13:04 Bernd Kuhls
2019-08-31 13:04 ` [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl Bernd Kuhls
2019-12-16 21:14 ` [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Thomas Petazzoni
0 siblings, 2 replies; 7+ messages in thread
From: Bernd Kuhls @ 2019-08-31 13:04 UTC (permalink / raw
To: buildroot
Release notes:
https://lists.freedesktop.org/archives/nice/2018-December/001443.html
https://lists.freedesktop.org/archives/nice/2019-May/001444.html
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/libnice/libnice.hash | 2 +-
package/libnice/libnice.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/libnice/libnice.hash b/package/libnice/libnice.hash
index 3c1f0d845a..61be9517e3 100644
--- a/package/libnice/libnice.hash
+++ b/package/libnice/libnice.hash
@@ -1,5 +1,5 @@
# Locally computed after checking pgp signature
-sha256 be120ba95d4490436f0da077ffa8f767bf727b82decf2bf499e39becc027809c libnice-0.1.14.tar.gz
+sha256 06b678066f94dde595a4291588ed27acd085ee73775b8c4e8399e28c01eeefdf libnice-0.1.16.tar.gz
# Hash for license files:
sha256 9246b2ee8b1db30cf03d5d9719ad8bb5edce1cadc85f8cfef319c23d24d950b5 COPYING
diff --git a/package/libnice/libnice.mk b/package/libnice/libnice.mk
index 49c29f9a60..b2fea4d66c 100644
--- a/package/libnice/libnice.mk
+++ b/package/libnice/libnice.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBNICE_VERSION = 0.1.14
+LIBNICE_VERSION = 0.1.16
LIBNICE_SITE = http://nice.freedesktop.org/releases
LIBNICE_LICENSE = MPL-1.1 or LGPL-2.1
LIBNICE_LICENSE_FILES = COPYING COPYING.MPL COPYING.LGPL
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl
2019-08-31 13:04 [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Bernd Kuhls
@ 2019-08-31 13:04 ` Bernd Kuhls
2019-08-31 20:07 ` Baruch Siach
2019-12-16 21:16 ` Thomas Petazzoni
2019-12-16 21:14 ` [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Thomas Petazzoni
1 sibling, 2 replies; 7+ messages in thread
From: Bernd Kuhls @ 2019-08-31 13:04 UTC (permalink / raw
To: buildroot
Support for OpenSSL was added in version 0.1.15:
https://lists.freedesktop.org/archives/nice/2018-December/001443.html
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/libnice/Config.in | 2 +-
package/libnice/libnice.mk | 10 +++++++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/package/libnice/Config.in b/package/libnice/Config.in
index af8e814618..1f62c0b5c8 100644
--- a/package/libnice/Config.in
+++ b/package/libnice/Config.in
@@ -4,7 +4,7 @@ config BR2_PACKAGE_LIBNICE
depends on BR2_USE_WCHAR # libglib2
depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
depends on BR2_USE_MMU # fork()
- select BR2_PACKAGE_GNUTLS
+ select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
select BR2_PACKAGE_LIBGLIB2
help
Libnice is an implementation of the IETF's Interactive
diff --git a/package/libnice/libnice.mk b/package/libnice/libnice.mk
index b2fea4d66c..4921deab33 100644
--- a/package/libnice/libnice.mk
+++ b/package/libnice/libnice.mk
@@ -8,9 +8,17 @@ LIBNICE_VERSION = 0.1.16
LIBNICE_SITE = http://nice.freedesktop.org/releases
LIBNICE_LICENSE = MPL-1.1 or LGPL-2.1
LIBNICE_LICENSE_FILES = COPYING COPYING.MPL COPYING.LGPL
-LIBNICE_DEPENDENCIES = gnutls libglib2 host-pkgconf
+LIBNICE_DEPENDENCIES = libglib2 host-pkgconf
LIBNICE_INSTALL_STAGING = YES
+ifeq ($(BR2_PACKAGE_GNUTLS),y)
+LIBNICE_CONF_OPTS += --without-openssl
+LIBNICE_DEPENDENCIES += gnutls
+else
+LIBNICE_CONF_OPTS += --with-openssl=$(STAGING_DIR)/usr
+LIBNICE_DEPENDENCIES += openssl
+endif
+
ifeq ($(BR2_PACKAGE_GST_PLUGINS_BASE),y)
LIBNICE_CONF_OPTS += --with-gstreamer-0.10
LIBNICE_DEPENDENCIES += gst-plugins-base
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl
2019-08-31 13:04 ` [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl Bernd Kuhls
@ 2019-08-31 20:07 ` Baruch Siach
2019-09-01 7:46 ` Bernd Kuhls
2019-12-16 21:16 ` Thomas Petazzoni
1 sibling, 1 reply; 7+ messages in thread
From: Baruch Siach @ 2019-08-31 20:07 UTC (permalink / raw
To: buildroot
Hi Bernd,
On Sat, Aug 31 2019, Bernd Kuhls wrote:
> Support for OpenSSL was added in version 0.1.15:
> https://lists.freedesktop.org/archives/nice/2018-December/001443.html
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/libnice/Config.in | 2 +-
> package/libnice/libnice.mk | 10 +++++++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/package/libnice/Config.in b/package/libnice/Config.in
> index af8e814618..1f62c0b5c8 100644
> --- a/package/libnice/Config.in
> +++ b/package/libnice/Config.in
> @@ -4,7 +4,7 @@ config BR2_PACKAGE_LIBNICE
> depends on BR2_USE_WCHAR # libglib2
> depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
> depends on BR2_USE_MMU # fork()
> - select BR2_PACKAGE_GNUTLS
> + select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
Is there a reason to change the default selected crypto library from
Gnutls to Openssl?
baruch
> select BR2_PACKAGE_LIBGLIB2
> help
> Libnice is an implementation of the IETF's Interactive
> diff --git a/package/libnice/libnice.mk b/package/libnice/libnice.mk
> index b2fea4d66c..4921deab33 100644
> --- a/package/libnice/libnice.mk
> +++ b/package/libnice/libnice.mk
> @@ -8,9 +8,17 @@ LIBNICE_VERSION = 0.1.16
> LIBNICE_SITE = http://nice.freedesktop.org/releases
> LIBNICE_LICENSE = MPL-1.1 or LGPL-2.1
> LIBNICE_LICENSE_FILES = COPYING COPYING.MPL COPYING.LGPL
> -LIBNICE_DEPENDENCIES = gnutls libglib2 host-pkgconf
> +LIBNICE_DEPENDENCIES = libglib2 host-pkgconf
> LIBNICE_INSTALL_STAGING = YES
>
> +ifeq ($(BR2_PACKAGE_GNUTLS),y)
> +LIBNICE_CONF_OPTS += --without-openssl
> +LIBNICE_DEPENDENCIES += gnutls
> +else
> +LIBNICE_CONF_OPTS += --with-openssl=$(STAGING_DIR)/usr
> +LIBNICE_DEPENDENCIES += openssl
> +endif
> +
> ifeq ($(BR2_PACKAGE_GST_PLUGINS_BASE),y)
> LIBNICE_CONF_OPTS += --with-gstreamer-0.10
> LIBNICE_DEPENDENCIES += gst-plugins-base
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl
2019-08-31 20:07 ` Baruch Siach
@ 2019-09-01 7:46 ` Bernd Kuhls
2019-09-01 8:06 ` Baruch Siach
0 siblings, 1 reply; 7+ messages in thread
From: Bernd Kuhls @ 2019-09-01 7:46 UTC (permalink / raw
To: buildroot
Am Sat, 31 Aug 2019 23:07:35 +0300 schrieb Baruch Siach:
>> - select BR2_PACKAGE_GNUTLS
>> + select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
>
> Is there a reason to change the default selected crypto library from
> Gnutls to Openssl?
Hi Baruch,
yes, if
select BR2_PACKAGE_GNUTLS if !BR2_PACKAGE_OPENSSL
is used, menuconfig throws this warning:
package/openssl/Config.in:4:error: recursive dependency detected!
package/openssl/Config.in:4: symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_GNUTLS
package/gnutls/Config.in:1: symbol BR2_PACKAGE_GNUTLS is selected by BR2_PACKAGE_OPENSSL
Regards, Bernd
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl
2019-09-01 7:46 ` Bernd Kuhls
@ 2019-09-01 8:06 ` Baruch Siach
0 siblings, 0 replies; 7+ messages in thread
From: Baruch Siach @ 2019-09-01 8:06 UTC (permalink / raw
To: buildroot
Hi Bernd,
On Sun, Sep 01 2019, Bernd Kuhls wrote:
> Am Sat, 31 Aug 2019 23:07:35 +0300 schrieb Baruch Siach:
>
>>> - select BR2_PACKAGE_GNUTLS
>>> + select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
>>
>> Is there a reason to change the default selected crypto library from
>> Gnutls to Openssl?
>
> yes, if
>
> select BR2_PACKAGE_GNUTLS if !BR2_PACKAGE_OPENSSL
>
> is used, menuconfig throws this warning:
>
> package/openssl/Config.in:4:error: recursive dependency detected!
> package/openssl/Config.in:4: symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_GNUTLS
> package/gnutls/Config.in:1: symbol BR2_PACKAGE_GNUTLS is selected by BR2_PACKAGE_OPENSSL
I see.
I think this should be mentioned in the commit log. Especially since
Config.in defaults to openssl, while .mk defaults to gnutls.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16
2019-08-31 13:04 [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Bernd Kuhls
2019-08-31 13:04 ` [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl Bernd Kuhls
@ 2019-12-16 21:14 ` Thomas Petazzoni
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2019-12-16 21:14 UTC (permalink / raw
To: buildroot
On Sat, 31 Aug 2019 15:04:16 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Release notes:
> https://lists.freedesktop.org/archives/nice/2018-December/001443.html
> https://lists.freedesktop.org/archives/nice/2019-May/001444.html
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/libnice/libnice.hash | 2 +-
> package/libnice/libnice.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl
2019-08-31 13:04 ` [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl Bernd Kuhls
2019-08-31 20:07 ` Baruch Siach
@ 2019-12-16 21:16 ` Thomas Petazzoni
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2019-12-16 21:16 UTC (permalink / raw
To: buildroot
On Sat, 31 Aug 2019 15:04:17 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Support for OpenSSL was added in version 0.1.15:
> https://lists.freedesktop.org/archives/nice/2018-December/001443.html
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/libnice/Config.in | 2 +-
> package/libnice/libnice.mk | 10 +++++++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
As requested by Baruch, I've extended the commit log to explain why we
need to select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS.
I've also changed the .mk file to pass
--with-crypto-library={openssl,gnutls}, and dropped the use of
--without-openssl in the gnutls case.
Applied to master with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-16 21:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-31 13:04 [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Bernd Kuhls
2019-08-31 13:04 ` [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl Bernd Kuhls
2019-08-31 20:07 ` Baruch Siach
2019-09-01 7:46 ` Bernd Kuhls
2019-09-01 8:06 ` Baruch Siach
2019-12-16 21:16 ` Thomas Petazzoni
2019-12-16 21:14 ` [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.