* [PATCH] clk: rockchip: Fix -Wunused-const-variable
@ 2019-06-27 22:22 ` Nathan Huckleberry
0 siblings, 0 replies; 13+ messages in thread
From: Nathan Huckleberry @ 2019-06-27 22:22 UTC (permalink / raw
To: mturquette, sboyd, heiko, andy.yan, zhangqing
Cc: linux-clk, linux-arm-kernel, linux-rockchip, linux-kernel,
Nathan Huckleberry, clang-built-linux
Clang produces the following warning
drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
'mux_pll_src_3plls_p' [-Wunused-const-variable]
PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
Looks like this variable was never used. Deleting it to remove the
warning.
Cc: clang-built-linux@googlegroups.com
Link: https://github.com/ClangBuiltLinux/linux/issues/524
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/clk/rockchip/clk-rv1108.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
index 96cc6af5632c..5947d3192866 100644
--- a/drivers/clk/rockchip/clk-rv1108.c
+++ b/drivers/clk/rockchip/clk-rv1108.c
@@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
-PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" };
PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" };
PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
--
2.22.0.410.gd8fdbe21b5-goog
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] clk: rockchip: Fix -Wunused-const-variable
@ 2019-06-27 22:22 ` Nathan Huckleberry
0 siblings, 0 replies; 13+ messages in thread
From: Nathan Huckleberry @ 2019-06-27 22:22 UTC (permalink / raw
To: mturquette, sboyd, heiko, andy.yan, zhangqing
Cc: clang-built-linux, linux-kernel, Nathan Huckleberry,
linux-rockchip, linux-clk, linux-arm-kernel
Clang produces the following warning
drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
'mux_pll_src_3plls_p' [-Wunused-const-variable]
PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
Looks like this variable was never used. Deleting it to remove the
warning.
Cc: clang-built-linux@googlegroups.com
Link: https://github.com/ClangBuiltLinux/linux/issues/524
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
drivers/clk/rockchip/clk-rv1108.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
index 96cc6af5632c..5947d3192866 100644
--- a/drivers/clk/rockchip/clk-rv1108.c
+++ b/drivers/clk/rockchip/clk-rv1108.c
@@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
-PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" };
PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" };
PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
--
2.22.0.410.gd8fdbe21b5-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
2019-06-27 22:22 ` Nathan Huckleberry
@ 2019-06-27 22:32 ` Nick Desaulniers
-1 siblings, 0 replies; 13+ messages in thread
From: Nick Desaulniers @ 2019-06-27 22:32 UTC (permalink / raw
To: Nathan Huckleberry
Cc: mturquette, sboyd, heiko, andy.yan, zhangqing, linux-clk,
Linux ARM, linux-rockchip, LKML, clang-built-linux
On Thu, Jun 27, 2019 at 3:22 PM 'Nathan Huckleberry' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
>
> Clang produces the following warning
>
> drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
>
> Looks like this variable was never used. Deleting it to remove the
> warning.
Indeed, looks like it was dead when introduced in:
commit e44dde279492 ("clk: rockchip: add clock controller for rk1108")
I don't see a pattern between when mux_pll_src_4plls_p vs
mux_pll_src_2plls_p is used, so it's not clear where or even if
mux_pll_src_3plls_p should be used. Given that there hasn't been a
response to your original question
(https://groups.google.com/forum/#!topic/clang-built-linux/NqJT9OPH5C8)
and this patch is no functional change as the variable is already
dead, I don't think it will hurt to remove it. It should also boost
the signal to noise ratio of this warning.
Thanks for looking into it, and the patch.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> index 96cc6af5632c..5947d3192866 100644
> --- a/drivers/clk/rockchip/clk-rv1108.c
> +++ b/drivers/clk/rockchip/clk-rv1108.c
> @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
> PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
> PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
> PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
> -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
@ 2019-06-27 22:32 ` Nick Desaulniers
0 siblings, 0 replies; 13+ messages in thread
From: Nick Desaulniers @ 2019-06-27 22:32 UTC (permalink / raw
To: Nathan Huckleberry
Cc: heiko, clang-built-linux, sboyd, mturquette, zhangqing, LKML,
linux-rockchip, andy.yan, linux-clk, Linux ARM
On Thu, Jun 27, 2019 at 3:22 PM 'Nathan Huckleberry' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
>
> Clang produces the following warning
>
> drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
>
> Looks like this variable was never used. Deleting it to remove the
> warning.
Indeed, looks like it was dead when introduced in:
commit e44dde279492 ("clk: rockchip: add clock controller for rk1108")
I don't see a pattern between when mux_pll_src_4plls_p vs
mux_pll_src_2plls_p is used, so it's not clear where or even if
mux_pll_src_3plls_p should be used. Given that there hasn't been a
response to your original question
(https://groups.google.com/forum/#!topic/clang-built-linux/NqJT9OPH5C8)
and this patch is no functional change as the variable is already
dead, I don't think it will hurt to remove it. It should also boost
the signal to noise ratio of this warning.
Thanks for looking into it, and the patch.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> index 96cc6af5632c..5947d3192866 100644
> --- a/drivers/clk/rockchip/clk-rv1108.c
> +++ b/drivers/clk/rockchip/clk-rv1108.c
> @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
> PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
> PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
> PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
> -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
Thanks,
~Nick Desaulniers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
2019-06-27 22:22 ` Nathan Huckleberry
(?)
@ 2019-07-22 21:35 ` Stephen Boyd
-1 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2019-07-22 21:35 UTC (permalink / raw
To: Nathan Huckleberry, andy.yan, heiko, mturquette, zhangqing
Cc: linux-clk, linux-arm-kernel, linux-rockchip, linux-kernel,
Nathan Huckleberry, clang-built-linux
Quoting Nathan Huckleberry (2019-06-27 15:22:20)
> Clang produces the following warning
>
> drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
>
> Looks like this variable was never used. Deleting it to remove the
> warning.
>
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/524
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> ---
> drivers/clk/rockchip/clk-rv1108.c | 1 -
> 1 file changed, 1 deletion(-)
Heiko, can you pick this up? Looks like v5.4 material.
>
> diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> index 96cc6af5632c..5947d3192866 100644
> --- a/drivers/clk/rockchip/clk-rv1108.c
> +++ b/drivers/clk/rockchip/clk-rv1108.c
> @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
> PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
> PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
> PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
> -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" };
> PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" };
> PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
@ 2019-07-22 21:35 ` Stephen Boyd
0 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2019-07-22 21:35 UTC (permalink / raw
To: Nathan Huckleberry, andy.yan, heiko, mturquette, zhangqing
Cc: clang-built-linux, linux-kernel, Nathan Huckleberry,
linux-rockchip, linux-clk, linux-arm-kernel
Quoting Nathan Huckleberry (2019-06-27 15:22:20)
> Clang produces the following warning
>
> drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
>
> Looks like this variable was never used. Deleting it to remove the
> warning.
>
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/524
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> ---
> drivers/clk/rockchip/clk-rv1108.c | 1 -
> 1 file changed, 1 deletion(-)
Heiko, can you pick this up? Looks like v5.4 material.
>
> diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> index 96cc6af5632c..5947d3192866 100644
> --- a/drivers/clk/rockchip/clk-rv1108.c
> +++ b/drivers/clk/rockchip/clk-rv1108.c
> @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
> PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
> PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
> PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
> -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" };
> PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" };
> PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
@ 2019-07-22 21:35 ` Stephen Boyd
0 siblings, 0 replies; 13+ messages in thread
From: Stephen Boyd @ 2019-07-22 21:35 UTC (permalink / raw
To: andy.yan, heiko, mturquette, zhangqing
Cc: linux-clk, linux-arm-kernel, linux-rockchip, linux-kernel,
Nathan Huckleberry, clang-built-linux
Quoting Nathan Huckleberry (2019-06-27 15:22:20)
> Clang produces the following warning
>
> drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
>
> Looks like this variable was never used. Deleting it to remove the
> warning.
>
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/524
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> ---
> drivers/clk/rockchip/clk-rv1108.c | 1 -
> 1 file changed, 1 deletion(-)
Heiko, can you pick this up? Looks like v5.4 material.
>
> diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> index 96cc6af5632c..5947d3192866 100644
> --- a/drivers/clk/rockchip/clk-rv1108.c
> +++ b/drivers/clk/rockchip/clk-rv1108.c
> @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
> PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
> PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
> PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
> -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" };
> PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" };
> PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
2019-07-22 21:35 ` Stephen Boyd
@ 2019-07-22 21:44 ` Heiko Stuebner
-1 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2019-07-22 21:44 UTC (permalink / raw
To: Stephen Boyd
Cc: Nathan Huckleberry, andy.yan, mturquette, zhangqing, linux-clk,
linux-arm-kernel, linux-rockchip, linux-kernel, clang-built-linux
Hi Stephen,
Am Montag, 22. Juli 2019, 23:35:18 CEST schrieb Stephen Boyd:
> Quoting Nathan Huckleberry (2019-06-27 15:22:20)
> > Clang produces the following warning
> >
> > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> > 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> >
> > Looks like this variable was never used. Deleting it to remove the
> > warning.
> >
> > Cc: clang-built-linux@googlegroups.com
> > Link: https://github.com/ClangBuiltLinux/linux/issues/524
> > Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> > ---
> > drivers/clk/rockchip/clk-rv1108.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Heiko, can you pick this up? Looks like v5.4 material.
yep ... I'm planning to do that :-)
Heiko
> > diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> > index 96cc6af5632c..5947d3192866 100644
> > --- a/drivers/clk/rockchip/clk-rv1108.c
> > +++ b/drivers/clk/rockchip/clk-rv1108.c
> > @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
> > PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
> > PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
> > PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
> > -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> > PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" };
> > PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" };
> > PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
@ 2019-07-22 21:44 ` Heiko Stuebner
0 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2019-07-22 21:44 UTC (permalink / raw
To: Stephen Boyd
Cc: clang-built-linux, mturquette, zhangqing, linux-kernel,
Nathan Huckleberry, linux-rockchip, andy.yan, linux-clk,
linux-arm-kernel
Hi Stephen,
Am Montag, 22. Juli 2019, 23:35:18 CEST schrieb Stephen Boyd:
> Quoting Nathan Huckleberry (2019-06-27 15:22:20)
> > Clang produces the following warning
> >
> > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> > 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> >
> > Looks like this variable was never used. Deleting it to remove the
> > warning.
> >
> > Cc: clang-built-linux@googlegroups.com
> > Link: https://github.com/ClangBuiltLinux/linux/issues/524
> > Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> > ---
> > drivers/clk/rockchip/clk-rv1108.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Heiko, can you pick this up? Looks like v5.4 material.
yep ... I'm planning to do that :-)
Heiko
> > diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> > index 96cc6af5632c..5947d3192866 100644
> > --- a/drivers/clk/rockchip/clk-rv1108.c
> > +++ b/drivers/clk/rockchip/clk-rv1108.c
> > @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
> > PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
> > PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
> > PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
> > -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> > PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" };
> > PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" };
> > PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
2019-06-27 22:22 ` Nathan Huckleberry
@ 2019-07-25 19:47 ` Heiko Stuebner
-1 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2019-07-25 19:47 UTC (permalink / raw
To: Nathan Huckleberry
Cc: mturquette, sboyd, andy.yan, zhangqing, linux-clk,
linux-arm-kernel, linux-rockchip, linux-kernel, clang-built-linux
Am Freitag, 28. Juni 2019, 00:22:20 CEST schrieb Nathan Huckleberry:
> Clang produces the following warning
>
> drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
>
> Looks like this variable was never used. Deleting it to remove the
> warning.
>
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/524
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
applied for 5.4
Thanks
Heiko
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
@ 2019-07-25 19:47 ` Heiko Stuebner
0 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2019-07-25 19:47 UTC (permalink / raw
To: Nathan Huckleberry
Cc: clang-built-linux, sboyd, mturquette, zhangqing, linux-kernel,
linux-rockchip, andy.yan, linux-clk, linux-arm-kernel
Am Freitag, 28. Juni 2019, 00:22:20 CEST schrieb Nathan Huckleberry:
> Clang produces the following warning
>
> drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
>
> Looks like this variable was never used. Deleting it to remove the
> warning.
>
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/524
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
applied for 5.4
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
2019-06-27 22:32 ` Nick Desaulniers
@ 2019-07-25 19:49 ` Heiko Stuebner
-1 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2019-07-25 19:49 UTC (permalink / raw
To: Nick Desaulniers
Cc: Nathan Huckleberry, mturquette, sboyd, andy.yan, zhangqing,
linux-clk, Linux ARM, linux-rockchip, LKML, clang-built-linux
Am Freitag, 28. Juni 2019, 00:32:38 CEST schrieb Nick Desaulniers:
> On Thu, Jun 27, 2019 at 3:22 PM 'Nathan Huckleberry' via Clang Built
> Linux <clang-built-linux@googlegroups.com> wrote:
> >
> > Clang produces the following warning
> >
> > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> > 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> >
> > Looks like this variable was never used. Deleting it to remove the
> > warning.
>
> Indeed, looks like it was dead when introduced in:
> commit e44dde279492 ("clk: rockchip: add clock controller for rk1108")
>
> I don't see a pattern between when mux_pll_src_4plls_p vs
> mux_pll_src_2plls_p is used, so it's not clear where or even if
> mux_pll_src_3plls_p should be used.
The possible sources for a clock really differ often, so there is no general
rule on when to use which sources ... except looking it up in the soc
manual. And I guess any possible conflict will turn up when someone
wants to use a clock that currently may reference the wrong sources.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
@ 2019-07-25 19:49 ` Heiko Stuebner
0 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2019-07-25 19:49 UTC (permalink / raw
To: Nick Desaulniers
Cc: clang-built-linux, sboyd, mturquette, zhangqing, LKML,
Nathan Huckleberry, linux-rockchip, andy.yan, linux-clk,
Linux ARM
Am Freitag, 28. Juni 2019, 00:32:38 CEST schrieb Nick Desaulniers:
> On Thu, Jun 27, 2019 at 3:22 PM 'Nathan Huckleberry' via Clang Built
> Linux <clang-built-linux@googlegroups.com> wrote:
> >
> > Clang produces the following warning
> >
> > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> > 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> >
> > Looks like this variable was never used. Deleting it to remove the
> > warning.
>
> Indeed, looks like it was dead when introduced in:
> commit e44dde279492 ("clk: rockchip: add clock controller for rk1108")
>
> I don't see a pattern between when mux_pll_src_4plls_p vs
> mux_pll_src_2plls_p is used, so it's not clear where or even if
> mux_pll_src_3plls_p should be used.
The possible sources for a clock really differ often, so there is no general
rule on when to use which sources ... except looking it up in the soc
manual. And I guess any possible conflict will turn up when someone
wants to use a clock that currently may reference the wrong sources.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-07-25 19:49 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-27 22:22 [PATCH] clk: rockchip: Fix -Wunused-const-variable Nathan Huckleberry
2019-06-27 22:22 ` Nathan Huckleberry
2019-06-27 22:32 ` Nick Desaulniers
2019-06-27 22:32 ` Nick Desaulniers
2019-07-25 19:49 ` Heiko Stuebner
2019-07-25 19:49 ` Heiko Stuebner
2019-07-22 21:35 ` Stephen Boyd
2019-07-22 21:35 ` Stephen Boyd
2019-07-22 21:35 ` Stephen Boyd
2019-07-22 21:44 ` Heiko Stuebner
2019-07-22 21:44 ` Heiko Stuebner
2019-07-25 19:47 ` Heiko Stuebner
2019-07-25 19:47 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.