* [PATCH 27/45] net: remove duplicate includes
@ 2017-12-11 16:39 Pravin Shedge
2017-12-11 19:04 ` Pablo Neira Ayuso
2017-12-13 18:19 ` David Miller
0 siblings, 2 replies; 7+ messages in thread
From: Pravin Shedge @ 2017-12-11 16:39 UTC (permalink / raw
To: netdev, netfilter-devel, coreteam, davem, andrew, vivien.didelot,
f.fainelli, pablo, kadlec, fw, jhs, xiyou.wangcong, mingo,
rmk+kernel
Cc: pravin.shedge4linux, linux-kernel
These duplicate includes have been found with scripts/checkincludes.pl but
they have been removed manually to avoid removing false positives.
Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
---
net/core/netprio_cgroup.c | 1 -
net/dsa/slave.c | 1 -
net/netfilter/nf_conntrack_netlink.c | 1 -
net/sched/act_meta_mark.c | 1 -
net/sched/act_meta_skbtcindex.c | 1 -
net/sched/cls_api.c | 1 -
net/sched/cls_u32.c | 1 -
7 files changed, 7 deletions(-)
diff --git a/net/core/netprio_cgroup.c b/net/core/netprio_cgroup.c
index 1c48109..b905747 100644
--- a/net/core/netprio_cgroup.c
+++ b/net/core/netprio_cgroup.c
@@ -14,7 +14,6 @@
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/types.h>
-#include <linux/module.h>
#include <linux/string.h>
#include <linux/errno.h>
#include <linux/skbuff.h>
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index d6e7a64..a95a55f 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -16,7 +16,6 @@
#include <linux/of_net.h>
#include <linux/of_mdio.h>
#include <linux/mdio.h>
-#include <linux/list.h>
#include <net/rtnetlink.h>
#include <net/pkt_cls.h>
#include <net/tc_act/tc_mirred.h>
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index 59c0899..332b518 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -45,7 +45,6 @@
#include <net/netfilter/nf_conntrack_zones.h>
#include <net/netfilter/nf_conntrack_timestamp.h>
#include <net/netfilter/nf_conntrack_labels.h>
-#include <net/netfilter/nf_conntrack_seqadj.h>
#include <net/netfilter/nf_conntrack_synproxy.h>
#ifdef CONFIG_NF_NAT_NEEDED
#include <net/netfilter/nf_nat_core.h>
diff --git a/net/sched/act_meta_mark.c b/net/sched/act_meta_mark.c
index 1e3f10e..6445184 100644
--- a/net/sched/act_meta_mark.c
+++ b/net/sched/act_meta_mark.c
@@ -22,7 +22,6 @@
#include <net/pkt_sched.h>
#include <uapi/linux/tc_act/tc_ife.h>
#include <net/tc_act/tc_ife.h>
-#include <linux/rtnetlink.h>
static int skbmark_encode(struct sk_buff *skb, void *skbdata,
struct tcf_meta_info *e)
diff --git a/net/sched/act_meta_skbtcindex.c b/net/sched/act_meta_skbtcindex.c
index 2ea1f26..7221437 100644
--- a/net/sched/act_meta_skbtcindex.c
+++ b/net/sched/act_meta_skbtcindex.c
@@ -22,7 +22,6 @@
#include <net/pkt_sched.h>
#include <uapi/linux/tc_act/tc_ife.h>
#include <net/tc_act/tc_ife.h>
-#include <linux/rtnetlink.h>
static int skbtcindex_encode(struct sk_buff *skb, void *skbdata,
struct tcf_meta_info *e)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index ddcf04b..f40256a 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -23,7 +23,6 @@
#include <linux/skbuff.h>
#include <linux/init.h>
#include <linux/kmod.h>
-#include <linux/err.h>
#include <linux/slab.h>
#include <net/net_namespace.h>
#include <net/sock.h>
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index ac152b4..507859c 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -45,7 +45,6 @@
#include <net/netlink.h>
#include <net/act_api.h>
#include <net/pkt_cls.h>
-#include <linux/netdevice.h>
#include <linux/idr.h>
struct tc_u_knode {
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 27/45] net: remove duplicate includes
2017-12-11 16:39 [PATCH 27/45] net: remove duplicate includes Pravin Shedge
@ 2017-12-11 19:04 ` Pablo Neira Ayuso
2017-12-13 18:19 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: Pablo Neira Ayuso @ 2017-12-11 19:04 UTC (permalink / raw
To: Pravin Shedge
Cc: netdev, netfilter-devel, coreteam, davem, andrew, vivien.didelot,
f.fainelli, kadlec, fw, jhs, xiyou.wangcong, mingo, rmk+kernel,
linux-kernel
On Mon, Dec 11, 2017 at 10:09:46PM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
For the Netfilter chunk.
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 27/45] net: remove duplicate includes
2017-12-11 16:39 [PATCH 27/45] net: remove duplicate includes Pravin Shedge
2017-12-11 19:04 ` Pablo Neira Ayuso
@ 2017-12-13 18:19 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: David Miller @ 2017-12-13 18:19 UTC (permalink / raw
To: pravin.shedge4linux
Cc: netdev, netfilter-devel, coreteam, andrew, vivien.didelot,
f.fainelli, pablo, kadlec, fw, jhs, xiyou.wangcong, mingo,
rmk+kernel, linux-kernel
From: Pravin Shedge <pravin.shedge4linux@gmail.com>
Date: Mon, 11 Dec 2017 22:09:46 +0530
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 27/45] net: remove duplicate includes
@ 2017-12-06 17:32 Pravin Shedge
2017-12-06 20:58 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Pravin Shedge @ 2017-12-06 17:32 UTC (permalink / raw
To: netfilter-devel, coreteam, fw, andrew, davem, mingo
Cc: linux-kernel, pravin.shedge4linux
These duplicate includes have been found with scripts/checkincludes.pl but
they have been removed manually to avoid removing false positives.
Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
---
net/core/netprio_cgroup.c | 1 -
net/dsa/slave.c | 1 -
net/netfilter/nf_conntrack_netlink.c | 1 -
net/sched/act_meta_mark.c | 1 -
net/sched/act_meta_skbtcindex.c | 1 -
net/sched/cls_api.c | 1 -
net/sched/cls_u32.c | 1 -
7 files changed, 7 deletions(-)
diff --git a/net/core/netprio_cgroup.c b/net/core/netprio_cgroup.c
index 1c48109..b905747 100644
--- a/net/core/netprio_cgroup.c
+++ b/net/core/netprio_cgroup.c
@@ -14,7 +14,6 @@
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/types.h>
-#include <linux/module.h>
#include <linux/string.h>
#include <linux/errno.h>
#include <linux/skbuff.h>
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index d6e7a64..a95a55f 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -16,7 +16,6 @@
#include <linux/of_net.h>
#include <linux/of_mdio.h>
#include <linux/mdio.h>
-#include <linux/list.h>
#include <net/rtnetlink.h>
#include <net/pkt_cls.h>
#include <net/tc_act/tc_mirred.h>
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index 59c0899..332b518 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -45,7 +45,6 @@
#include <net/netfilter/nf_conntrack_zones.h>
#include <net/netfilter/nf_conntrack_timestamp.h>
#include <net/netfilter/nf_conntrack_labels.h>
-#include <net/netfilter/nf_conntrack_seqadj.h>
#include <net/netfilter/nf_conntrack_synproxy.h>
#ifdef CONFIG_NF_NAT_NEEDED
#include <net/netfilter/nf_nat_core.h>
diff --git a/net/sched/act_meta_mark.c b/net/sched/act_meta_mark.c
index 1e3f10e..6445184 100644
--- a/net/sched/act_meta_mark.c
+++ b/net/sched/act_meta_mark.c
@@ -22,7 +22,6 @@
#include <net/pkt_sched.h>
#include <uapi/linux/tc_act/tc_ife.h>
#include <net/tc_act/tc_ife.h>
-#include <linux/rtnetlink.h>
static int skbmark_encode(struct sk_buff *skb, void *skbdata,
struct tcf_meta_info *e)
diff --git a/net/sched/act_meta_skbtcindex.c b/net/sched/act_meta_skbtcindex.c
index 2ea1f26..7221437 100644
--- a/net/sched/act_meta_skbtcindex.c
+++ b/net/sched/act_meta_skbtcindex.c
@@ -22,7 +22,6 @@
#include <net/pkt_sched.h>
#include <uapi/linux/tc_act/tc_ife.h>
#include <net/tc_act/tc_ife.h>
-#include <linux/rtnetlink.h>
static int skbtcindex_encode(struct sk_buff *skb, void *skbdata,
struct tcf_meta_info *e)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index ddcf04b..f40256a 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -23,7 +23,6 @@
#include <linux/skbuff.h>
#include <linux/init.h>
#include <linux/kmod.h>
-#include <linux/err.h>
#include <linux/slab.h>
#include <net/net_namespace.h>
#include <net/sock.h>
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index ac152b4..507859c 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -45,7 +45,6 @@
#include <net/netlink.h>
#include <net/act_api.h>
#include <net/pkt_cls.h>
-#include <linux/netdevice.h>
#include <linux/idr.h>
struct tc_u_knode {
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 27/45] net: remove duplicate includes
2017-12-06 17:32 Pravin Shedge
@ 2017-12-06 20:58 ` David Miller
2017-12-10 18:00 ` Pravin Shedge
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2017-12-06 20:58 UTC (permalink / raw
To: pravin.shedge4linux
Cc: netfilter-devel, coreteam, fw, andrew, mingo, linux-kernel
From: Pravin Shedge <pravin.shedge4linux@gmail.com>
Date: Wed, 6 Dec 2017 23:02:58 +0530
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
Networking patches need to be sent to netdev@vger.kernel.org
Thank you.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 27/45] net: remove duplicate includes
2017-12-06 20:58 ` David Miller
@ 2017-12-10 18:00 ` Pravin Shedge
2017-12-11 4:04 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Pravin Shedge @ 2017-12-10 18:00 UTC (permalink / raw
To: David Miller
Cc: netfilter-devel, coreteam, fw, Andrew Lunn, Ingo Molnar,
linux-kernel, netdev
On Thu, Dec 7, 2017 at 2:28 AM, David Miller <davem@davemloft.net> wrote:
> From: Pravin Shedge <pravin.shedge4linux@gmail.com>
> Date: Wed, 6 Dec 2017 23:02:58 +0530
>
>> These duplicate includes have been found with scripts/checkincludes.pl but
>> they have been removed manually to avoid removing false positives.
>>
>> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
>
> Networking patches need to be sent to netdev@vger.kernel.org
>
> Thank you.
-- Adding netdev@vger.kernel.org for reviewing networking patches.
- Thanks & Regards,
PraviN
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 27/45] net: remove duplicate includes
2017-12-10 18:00 ` Pravin Shedge
@ 2017-12-11 4:04 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2017-12-11 4:04 UTC (permalink / raw
To: pravin.shedge4linux
Cc: netfilter-devel, coreteam, fw, andrew, mingo, linux-kernel,
netdev
From: Pravin Shedge <pravin.shedge4linux@gmail.com>
Date: Sun, 10 Dec 2017 23:30:21 +0530
> On Thu, Dec 7, 2017 at 2:28 AM, David Miller <davem@davemloft.net> wrote:
>> From: Pravin Shedge <pravin.shedge4linux@gmail.com>
>> Date: Wed, 6 Dec 2017 23:02:58 +0530
>>
>>> These duplicate includes have been found with scripts/checkincludes.pl but
>>> they have been removed manually to avoid removing false positives.
>>>
>>> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
>>
>> Networking patches need to be sent to netdev@vger.kernel.org
>>
>> Thank you.
>
> -- Adding netdev@vger.kernel.org for reviewing networking patches.
Doesn't work like that.
You have to post the actual patch freshly to the netdev mailing list
so that it gets properly queued in patchwork and can be reviewed.
You can't just add netdev to the CC: in a reply to my email, that
doesn't do any good at all.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-12-13 18:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-11 16:39 [PATCH 27/45] net: remove duplicate includes Pravin Shedge
2017-12-11 19:04 ` Pablo Neira Ayuso
2017-12-13 18:19 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2017-12-06 17:32 Pravin Shedge
2017-12-06 20:58 ` David Miller
2017-12-10 18:00 ` Pravin Shedge
2017-12-11 4:04 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.