From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 28 Sep 2017 09:11:14 -0400 Subject: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with pr_err() In-Reply-To: References: <1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com> <1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com> <20170928124307.GJ3112@bill-the-cat> Message-ID: <20170928131114.GL3112@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Sep 28, 2017 at 09:56:29PM +0900, Masahiro Yamada wrote: > Hi Tom, > > > 2017-09-28 21:43 GMT+09:00 Tom Rini : > > On Thu, Sep 28, 2017 at 03:11:05PM +0900, Masahiro Yamada wrote: > >> Hi Tom, > >> > >> 2017-09-16 14:10 GMT+09:00 Masahiro Yamada : > >> > U-Boot widely uses error() as a bit noisier variant of printf(). > >> > > >> > This macro causes name conflict with the following line in > >> > include/linux/compiler-gcc.h: > >> > > >> > # define __compiletime_error(message) __attribute__((error(message))) > >> > > >> > This prevents us from using __compiletime_error(), and makes it > >> > difficult to fully sync BUILD_BUG macros with Linux. (Notice > >> > Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().) > >> > > >> > Let's convert error() into now treewide-available pr_err(). > >> > > >> > Done with the help of Coccinelle, excluing tools/ directory. > >> > > >> > The semantic patch I used is as follows: > >> > > >> > // > >> > @@@@ > >> > -error > >> > +pr_err > >> > (...) > >> > // > >> > >> > >> Apparently, this is outdated already. > >> > >> Do you want me to update this? > >> or will you run coccinelle by yourself? > > > > Well, that was my first time running coccinelle, and it was rather > > painless. So yes, I'm happy to re-generate any coccinelle generated > > patches so long as the smpl is included in the commit message. Thanks! > > > > > OK, I will not resend this series. > This one is quite big, and would go to the moderator. > > > One more request, if you will remember, would you fix my typo in the subject? > > "replace with error() with pr_error()" > > I noticed the first "with" was unneeded. OK, will do. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: