* [PATCH] staging: unisys: visornic: Fixed Checkpatch Warnings
@ 2016-03-17 1:24 Gavin O'Leary
2016-03-17 1:35 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Gavin O'Leary @ 2016-03-17 1:24 UTC (permalink / raw
To: gregkh
Cc: david.kershner, benjamin.romer, timothy.sell, nhorman,
sparmaintainer, devel, linux-kernel, Gavin O'Leary
Fixed the coding style checkpatch warnings.
Signed-off-by: Gavin O'Leary <gavinoleary3@gmail.com>
---
drivers/staging/unisys/visornic/visornic_main.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index 0519470..0366624 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -1218,8 +1218,9 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
/* length rcvd is greater than firstfrag in this skb rcv buf */
skb->tail += RCVPOST_BUF_SIZE; /* amount in skb->data */
skb->data_len = skb->len - RCVPOST_BUF_SIZE; /* amount that
- will be in
- frag_list */
+ * will be in
+ * frag_list
+ */
} else {
/* data fits in this skb - no chaining - do
* PRECAUTIONARY check
@@ -1315,12 +1316,14 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
}
if (found_mc)
break; /* accept packet, dest
- matches a multicast
- address */
+ * matches a multicast
+ * address
+ */
}
} else if (skb->pkt_type == PACKET_HOST) {
break; /* accept packet, h_dest must match vnic
- mac address */
+ * mac address
+ */
} else if (skb->pkt_type == PACKET_OTHERHOST) {
/* something is not right */
dev_err(&devdata->netdev->dev,
@@ -1619,7 +1622,8 @@ service_resp_queue(struct uiscmdrsp *cmdrsp, struct visornic_devdata *devdata,
struct net_device *netdev;
/* TODO: CLIENT ACQUIRE -- Don't really need this at the
- * moment */
+ * moment
+ */
for (;;) {
if (!visorchannel_signalremove(devdata->dev->visorchannel,
IOCHAN_FROM_IOPART,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: unisys: visornic: Fixed Checkpatch Warnings
2016-03-17 1:24 [PATCH] staging: unisys: visornic: Fixed Checkpatch Warnings Gavin O'Leary
@ 2016-03-17 1:35 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-03-17 1:35 UTC (permalink / raw
To: Gavin O'Leary
Cc: david.kershner, benjamin.romer, timothy.sell, nhorman,
sparmaintainer, devel, linux-kernel
On Wed, Mar 16, 2016 at 06:24:47PM -0700, Gavin O'Leary wrote:
> Fixed the coding style checkpatch warnings.
Which ones? Always be specific. And only fix one type of thing at a
time.
>
> Signed-off-by: Gavin O'Leary <gavinoleary3@gmail.com>
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 0519470..0366624 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1218,8 +1218,9 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
> /* length rcvd is greater than firstfrag in this skb rcv buf */
> skb->tail += RCVPOST_BUF_SIZE; /* amount in skb->data */
> skb->data_len = skb->len - RCVPOST_BUF_SIZE; /* amount that
> - will be in
> - frag_list */
> + * will be in
> + * frag_list
> + */
Tell me that looks better :(
Please fix this properly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-17 1:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 1:24 [PATCH] staging: unisys: visornic: Fixed Checkpatch Warnings Gavin O'Leary
2016-03-17 1:35 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.