All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] alsa-lib: disable libdl for static only builds
@ 2016-01-20 21:31 Thomas Petazzoni
  0 siblings, 0 replies; only message in thread
From: Thomas Petazzoni @ 2016-01-20 21:31 UTC (permalink / raw
  To: buildroot

commit: http://git.buildroot.net/buildroot/commit/?id=1e209d022d751b7874e71858b59ca6cd320d50fc
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

-ldl includes the reference to the library that has
the symbols for loading dynamic libraries.
So there is no need for this library for static only builds.
Even though alsa-lib uses dlopen, it has functions snd_dlopen
and others which can emulate dynamic linking for the static
build of the alsa-lib library and there is no need in libdl
dlopen when static build only.
This patch fixes build failures of the shairport-sync
(and probably other packages) when static libs are used.

Fixes:
http://autobuild.buildroot.net/results/85a/85a3f01bcd4eb2ce7ac480e63b4cc04bf7c8f3e5/

[Thomas: use a single ALSA_LIB_CONF_OPTS for both --enable-shared=no
and --without-libdl.]

Signed-off-by: Lada Trimasova <ltrimas@synopsys.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/alsa-lib/alsa-lib.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
index ea2351c..2075d41 100644
--- a/package/alsa-lib/alsa-lib.mk
+++ b/package/alsa-lib/alsa-lib.mk
@@ -20,7 +20,9 @@ ALSA_LIB_CONF_OPTS = \
 
 # Can't build with static & shared at the same time (1.0.25+)
 ifeq ($(BR2_STATIC_LIBS),y)
-ALSA_LIB_CONF_OPTS += --enable-shared=no
+ALSA_LIB_CONF_OPTS += \
+	--enable-shared=no \
+	--without-libdl
 else
 ALSA_LIB_CONF_OPTS += --enable-static=no
 endif

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-01-20 21:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-20 21:31 [Buildroot] [git commit] alsa-lib: disable libdl for static only builds Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.