* [PATCH nf-next] netfilter: nftables: Change the return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void.
@ 2015-12-08 12:09 Rami Rosen
2015-12-09 13:51 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: Rami Rosen @ 2015-12-08 12:09 UTC (permalink / raw
To: pablo; +Cc: kadlec, netfilter-devel, coreteam, Rami Rosen
This patch changes the return type of the static methods nfulnl_set_timeout() and
nfulnl_set_qthresh() to be void, as there is no justification and no need for these methods to return int.
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
net/netfilter/nfnetlink_log.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index dea4676..70b6bd3 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -293,24 +293,20 @@ nfulnl_set_nlbufsiz(struct nfulnl_instance *inst, u_int32_t nlbufsiz)
return status;
}
-static int
+static void
nfulnl_set_timeout(struct nfulnl_instance *inst, u_int32_t timeout)
{
spin_lock_bh(&inst->lock);
inst->flushtimeout = timeout;
spin_unlock_bh(&inst->lock);
-
- return 0;
}
-static int
+static void
nfulnl_set_qthresh(struct nfulnl_instance *inst, u_int32_t qthresh)
{
spin_lock_bh(&inst->lock);
inst->qthreshold = qthresh;
spin_unlock_bh(&inst->lock);
-
- return 0;
}
static int
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH nf-next] netfilter: nftables: Change the return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void.
2015-12-08 12:09 [PATCH nf-next] netfilter: nftables: Change the return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void Rami Rosen
@ 2015-12-09 13:51 ` Pablo Neira Ayuso
2015-12-09 14:00 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2015-12-09 13:51 UTC (permalink / raw
To: Rami Rosen; +Cc: kadlec, netfilter-devel, coreteam
On Tue, Dec 08, 2015 at 07:09:24AM -0500, Rami Rosen wrote:
> This patch changes the return type of the static methods nfulnl_set_timeout() and
> nfulnl_set_qthresh() to be void, as there is no justification and no need for these methods to return int.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH nf-next] netfilter: nftables: Change the return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void.
2015-12-09 13:51 ` Pablo Neira Ayuso
@ 2015-12-09 14:00 ` Pablo Neira Ayuso
0 siblings, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2015-12-09 14:00 UTC (permalink / raw
To: Rami Rosen; +Cc: kadlec, netfilter-devel, coreteam
On Wed, Dec 09, 2015 at 02:51:58PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Dec 08, 2015 at 07:09:24AM -0500, Rami Rosen wrote:
> > This patch changes the return type of the static methods nfulnl_set_timeout() and
> > nfulnl_set_qthresh() to be void, as there is no justification and no need for these methods to return int.
>
> Applied, thanks.
For the record, I have renamed the title to:
"netfilter: nfnetlink_log: Change setter functions to be void"
This is not related to nftables itself, but our userspace logging
infrastructure.
Then I have trimmed off the title length a bit, I hope this retains
the original spirit of it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-09 14:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-08 12:09 [PATCH nf-next] netfilter: nftables: Change the return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void Rami Rosen
2015-12-09 13:51 ` Pablo Neira Ayuso
2015-12-09 14:00 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.