* [Patch net] net_sched: copy exts->type in tcf_exts_change()
@ 2014-10-07 0:21 Cong Wang
2014-10-07 11:33 ` Jamal Hadi Salim
2014-10-08 19:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Cong Wang @ 2014-10-07 0:21 UTC (permalink / raw
To: netdev; +Cc: Cong Wang, Jamal Hadi Salim, John Fastabend
We need to copy exts->type when committing the change, otherwise
it would be always 0. This is a quick fix for -net and -stable,
for net-next tcf_exts will be removed.
Fixes: commit 33be627159913b094bb578e83 ("net_sched: act: use standard struct list_head")
Reported-by: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
net/sched/cls_api.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index c28b0d3..4f4e08b 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -549,6 +549,7 @@ void tcf_exts_change(struct tcf_proto *tp, struct tcf_exts *dst,
tcf_tree_lock(tp);
list_splice_init(&dst->actions, &tmp);
list_splice(&src->actions, &dst->actions);
+ dst->type = src->type;
tcf_tree_unlock(tp);
tcf_action_destroy(&tmp, TCA_ACT_UNBIND);
#endif
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch net] net_sched: copy exts->type in tcf_exts_change()
2014-10-07 0:21 [Patch net] net_sched: copy exts->type in tcf_exts_change() Cong Wang
@ 2014-10-07 11:33 ` Jamal Hadi Salim
2014-10-08 19:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jamal Hadi Salim @ 2014-10-07 11:33 UTC (permalink / raw
To: Cong Wang, netdev; +Cc: John Fastabend
On 10/06/14 20:21, Cong Wang wrote:
> We need to copy exts->type when committing the change, otherwise
> it would be always 0. This is a quick fix for -net and -stable,
> for net-next tcf_exts will be removed.
>
> Fixes: commit 33be627159913b094bb578e83 ("net_sched: act: use standard struct list_head")
> Reported-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch net] net_sched: copy exts->type in tcf_exts_change()
2014-10-07 0:21 [Patch net] net_sched: copy exts->type in tcf_exts_change() Cong Wang
2014-10-07 11:33 ` Jamal Hadi Salim
@ 2014-10-08 19:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-10-08 19:41 UTC (permalink / raw
To: xiyou.wangcong; +Cc: netdev, jhs, john.fastabend
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Mon, 6 Oct 2014 17:21:54 -0700
> We need to copy exts->type when committing the change, otherwise
> it would be always 0. This is a quick fix for -net and -stable,
> for net-next tcf_exts will be removed.
>
> Fixes: commit 33be627159913b094bb578e83 ("net_sched: act: use standard struct list_head")
> Reported-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Ok, applied and queued up for -stable, I'll sort out the merge hassles
with net-next too.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-08 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-07 0:21 [Patch net] net_sched: copy exts->type in tcf_exts_change() Cong Wang
2014-10-07 11:33 ` Jamal Hadi Salim
2014-10-08 19:41 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.